View Issue Details

IDProjectCategoryView StatusLast Update
0015446ScribusUser Interfacepublic2019-01-28 09:22
Reporterale Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status newResolutionopen 
Product Version1.5.5.svn 
Target VersionFixed in Version 
Summary0015446: reorder the fields in the image tab of the properties palette
Descriptionwile working on a reset button for the image properties, i've noticed that the fields:

- do not seem to follow a strong logical ordered (at least not for me)
- do not make it easy to access the fields that are (probably) most used.

this makes it harder to find a good place for the reset button.

i suggest the following order:

- scale (the one that i almost always use...)
- position
- rotation
- image effects (only visible when an image is loaded) + extended properties (only visible for image types with extend properties)
- Colour management (visible if active)
- page number (should only be visible on multi page images? ... in this case it could also be on top...)
- PDF compression (only visible when a PDF is in the frame?)
- (reset button)

i will add a patch for this soon.
TagsNo tags attached.
PatchNo

Activities

ale

2018-09-30 08:49

manager   ~0045489

oooh... i see that the fields are alphabetically ordered:

- page number
- position
- rotation
- scale

... is this on purpose? is this what we want?

ale

2018-09-30 09:45

manager  

image-tab-order.png (116,810 bytes)
image-tab-order.png (116,810 bytes)
image-tab-order.patch (9,392 bytes)
diff --git a/scribus/ui/propertiespalette_imagebase.ui b/scribus/ui/propertiespalette_imagebase.ui
index b4932b3c2..e4b571d7e 100644
--- a/scribus/ui/propertiespalette_imagebase.ui
+++ b/scribus/ui/propertiespalette_imagebase.ui
@@ -29,81 +29,6 @@
    <property name="bottomMargin">
     <number>2</number>
    </property>
-   <item>
-    <layout class="QGridLayout" name="gridLayout">
-     <item row="2" column="0">
-      <widget class="QLabel" name="xposImgLabel">
-       <property name="text">
-        <string>&amp;X-Pos:</string>
-       </property>
-      </widget>
-     </item>
-     <item row="2" column="1">
-      <widget class="ScrSpinBox" name="imageXOffsetSpinBox">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
-       <property name="toolTip">
-        <string>Horizontal offset of image within frame</string>
-       </property>
-      </widget>
-     </item>
-     <item row="4" column="0">
-      <widget class="QLabel" name="imageRotationLabel">
-       <property name="text">
-        <string>Rotation:</string>
-       </property>
-      </widget>
-     </item>
-     <item row="4" column="1">
-      <widget class="ScrSpinBox" name="imageRotation">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
-      </widget>
-     </item>
-     <item row="1" column="0">
-      <widget class="QLabel" name="imagePageNumberLabel">
-       <property name="text">
-        <string>&amp;Page Number:</string>
-       </property>
-      </widget>
-     </item>
-     <item row="3" column="0">
-      <widget class="QLabel" name="yposImgLabel">
-       <property name="text">
-        <string>&amp;Y-Pos:</string>
-       </property>
-      </widget>
-     </item>
-     <item row="3" column="1">
-      <widget class="ScrSpinBox" name="imageYOffsetSpinBox">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
-       <property name="toolTip">
-        <string>Vertical offset of image within frame</string>
-       </property>
-      </widget>
-     </item>
-     <item row="1" column="1">
-      <widget class="ScrSpinBox" name="imagePageNumber">
-       <property name="specialValueText">
-        <string>Auto</string>
-       </property>
-      </widget>
-     </item>
-    </layout>
-   </item>
    <item>
     <widget class="QGroupBox" name="scalingGroupBox">
      <property name="title">
@@ -208,23 +133,6 @@
         </property>
        </widget>
       </item>
-      <item row="0" column="2">
-       <widget class="QToolButton" name="resetPositionScale">
-        <property name="maximumSize">
-         <size>
-          <width>22</width>
-          <height>22</height>
-         </size>
-        </property>
-        <property name="text">
-         <string>Reset Scale and Position</string>
-        </property>
-        <property name="icon">
-         <iconset>
-          <normaloff>../../resources/icons/16/edit-clear.png</normaloff>../../resources/icons/16/edit-clear.png</iconset>
-        </property>
-       </widget>
-      </item>
       <item row="7" column="1">
        <widget class="QCheckBox" name="cbProportional">
         <property name="toolTip">
@@ -275,6 +183,111 @@
      </layout>
     </widget>
    </item>
+   <item>
+    <layout class="QGridLayout" name="gridLayout">
+     <item row="1" column="0">
+      <widget class="QLabel" name="imagePageNumberLabel">
+       <property name="text">
+        <string>&amp;Page Number:</string>
+       </property>
+      </widget>
+     </item>
+     <item row="1" column="1">
+      <widget class="ScrSpinBox" name="imagePageNumber">
+       <property name="specialValueText">
+        <string>Auto</string>
+       </property>
+      </widget>
+     </item>
+     <item row="2" column="0">
+      <widget class="QLabel" name="xposImgLabel">
+       <property name="text">
+        <string>&amp;X-Pos:</string>
+       </property>
+      </widget>
+     </item>
+     <item row="2" column="1">
+      <widget class="ScrSpinBox" name="imageXOffsetSpinBox">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="toolTip">
+        <string>Horizontal offset of image within frame</string>
+       </property>
+      </widget>
+     </item>
+     <item row="3" column="0">
+      <widget class="QLabel" name="yposImgLabel">
+       <property name="text">
+        <string>&amp;Y-Pos:</string>
+       </property>
+      </widget>
+     </item>
+     <item row="3" column="1">
+      <widget class="ScrSpinBox" name="imageYOffsetSpinBox">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="toolTip">
+        <string>Vertical offset of image within frame</string>
+       </property>
+      </widget>
+     </item>
+     <item row="4" column="0">
+      <widget class="QLabel" name="imageRotationLabel">
+       <property name="text">
+        <string>Rotation:</string>
+       </property>
+      </widget>
+     </item>
+     <item row="4" column="1">
+      <widget class="ScrSpinBox" name="imageRotation">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Minimum" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </item>
+   <item>
+    <layout class="QHBoxLayout" name="horizontalLayout">
+     <item>
+      <widget class="QToolButton" name="imgEffectsButton">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="text">
+        <string>Image Effects</string>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QToolButton" name="imgExtProperties">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
+       <property name="text">
+        <string>Extended Properties</string>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </item>
    <item>
     <widget class="QGroupBox" name="colorMgmtGroup">
      <property name="title">
@@ -367,36 +380,6 @@
      </layout>
     </widget>
    </item>
-   <item>
-    <layout class="QHBoxLayout" name="horizontalLayout">
-     <item>
-      <widget class="QToolButton" name="imgEffectsButton">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
-       <property name="text">
-        <string>Image Effects</string>
-       </property>
-      </widget>
-     </item>
-     <item>
-      <widget class="QToolButton" name="imgExtProperties">
-       <property name="sizePolicy">
-        <sizepolicy hsizetype="MinimumExpanding" vsizetype="Fixed">
-         <horstretch>0</horstretch>
-         <verstretch>0</verstretch>
-        </sizepolicy>
-       </property>
-       <property name="text">
-        <string>Extended Properties</string>
-       </property>
-      </widget>
-     </item>
-    </layout>
-   </item>
    <item>
     <spacer name="verticalSpacer">
      <property name="orientation">
@@ -425,25 +408,17 @@
   </customwidget>
  </customwidgets>
  <tabstops>
-  <tabstop>imagePageNumber</tabstop>
   <tabstop>imageXOffsetSpinBox</tabstop>
   <tabstop>imageYOffsetSpinBox</tabstop>
   <tabstop>imageRotation</tabstop>
-  <tabstop>freeScale</tabstop>
-  <tabstop>imageXScaleSpinBox</tabstop>
-  <tabstop>imageYScaleSpinBox</tabstop>
-  <tabstop>imgDpiX</tabstop>
-  <tabstop>imgDpiY</tabstop>
-  <tabstop>keepImageWHRatioButton</tabstop>
-  <tabstop>keepImageDPIRatioButton</tabstop>
-  <tabstop>frameScale</tabstop>
+  <tabstop>imgEffectsButton</tabstop>
+  <tabstop>imgExtProperties</tabstop>
   <tabstop>cbProportional</tabstop>
+  <tabstop>imagePageNumber</tabstop>
   <tabstop>inputProfiles</tabstop>
   <tabstop>renderIntent</tabstop>
   <tabstop>compressionMethod</tabstop>
   <tabstop>compressionQuality</tabstop>
-  <tabstop>imgEffectsButton</tabstop>
-  <tabstop>imgExtProperties</tabstop>
  </tabstops>
  <resources/>
  <connections/>
image-tab-order.patch (9,392 bytes)

PeterBenedek

2018-09-30 16:23

developer   ~0045491

Last edited: 2018-09-30 16:25

View 2 revisions

ale, please consider introducing a new field too (field value read only).

Image name:

This would be useful.

Thanks, Peter



Scribus_imagename.png (135,726 bytes)
Scribus_imagename.png (135,726 bytes)

ale

2018-09-30 19:16

manager   ~0045492

the information is already available in the context menu, under "file info".
on the one side, this is for sure an interesting information, but i really wonder if it's wort to use PP space for it.
for the times i need the information, i'm ready to right click on the frame...

i would tend to add it in the "tooltip" in the "outline" window.

and is also accessible in the image manager.

i don't know i'm a bit hesitant to add it on top of the image tab in the PP...

ale

2019-01-28 09:20

manager   ~0045868

adding a link to the image manager?

ale

2019-01-28 09:22

manager   ~0045869

the free scale / fit to frame (/ fill the frame) radio buttons should be push buttons (with an icon) on top of "their" fields.

optionally: only show the active fields for the active fill type.

Issue History

Date Modified Username Field Change
2018-09-30 07:24 ale New Issue
2018-09-30 08:49 ale Note Added: 0045489
2018-09-30 08:52 ale Description Updated View Revisions
2018-09-30 09:19 ale Description Updated View Revisions
2018-09-30 09:45 ale File Added: image-tab-order.png
2018-09-30 09:45 ale File Added: image-tab-order.patch
2018-09-30 16:23 PeterBenedek File Added: Scribus_imagename.png
2018-09-30 16:23 PeterBenedek Note Added: 0045491
2018-09-30 16:25 PeterBenedek Note Edited: 0045491 View Revisions
2018-09-30 19:16 ale Note Added: 0045492
2019-01-28 09:20 ale Note Added: 0045868
2019-01-28 09:22 ale Note Added: 0045869