|
2018-10-23 12:13
|
scribus_barely visible icon.png (88,115 bytes) |
|
|
i don't think that scribus supports dark themes yet.. there has been some work on it, but it's not in scribus itself yet. if somebody wants to help on that, raise your hand! |
|
|
Well, if it is just taking the icons and inverting their colors, I could make you a zip-file with the png's ... |
|
|
I have to admit - I underestimated the number of icons ... it took me roughly two hours to make a baseline version. It is based on the 1.5.1 icon scheme ... I think it might work if the file is extracted to {SCRIBUS_DIRECTORY}\share\icons Then go to settings and choose the 1.5.1 for dark Icons, click ok and restart the program ... If there are icons that do not work in the current version, they can be changed easily. |
|
|
Thank you very much. It looks great! |
|
|
Thank You for the energy and sharing, Luna. It's perfect! |
|
|
i've created a branch on gitlab with the patch. the appimage is here for the next week: https://gitlab.com/impagina/scribus-patched/-/jobs/211107366/artifacts/file/build-appimage/Scribus-588197e-x86_64.AppImage the diff is here: https://gitlab.com/impagina/scribus-patched/compare/appimage...dark please test and comment! |
|
|
@Luna Nightshade, am i wrong or not all the icons have been converted? |
|
|
I am currently using the dark set with linux mint and I have not stumbled upon unconverted Icons ... Though I do believe that you need to clean-up the icon folder - there are some that I have never seen in the program itself ... If you direct me to the ones missing, I should be able to change them as well. |
|
|
i don't have a dark theme (nor now how to add one to my system... to be honest) so i cannot try myself. i've tried to get it to run on a friend's computer and the issue was mostly visible (or hard to see : - ) in the main toolbar. the properties palette looked fine to me. if you're on linux, can you try to download the appimage linked above? if you don't see the issue, you could upload a screenshot and i will probably be able to tell if it was i was seeing on cedric's computer or not... |
|
|
I downloaded the AppImage, and it does not use the System set Dark Theme (the one from the Scribusfriends ppa repository does though). I'll attach a screenshot on how it should look. Screenshot at 2019-05-13 16-49-04.png (177,302 bytes) |
|
|
ok, i got it! can you please try https://gitlab.com/impagina/scribus-patched/-/jobs/213076892/artifacts/file/build-appimage/Scribus-d6f0ffc-x86_64.AppImage ? if it's ok i will make a patch that will have to be applied on top of your zip file. |
|
|
The AppImage package still does not use the system's theme, but I see the new icons loaded. (There is apparently one image in the preferences dialogue that's not changed - but that is already missing in the original zip file, It should be fine though.) |
|
|
@luna nightshade are you using gnome or a derivative of it? probono has added a condition in the appimage to pick the gtk theme if gnome is detected (well, he has set the theme to always be the gtk one... i've modified the script to only pick gtk when gnome is detected... and not on my clean/"qt" system). in the preferences, can you change the theme and pick the one you would like to have? if i'm supposing correctly, i will have to improve the gtk detection to only set the theme to gtk if the user is using gnome and has not set the theme to be something different than the default one... https://gitlab.com/impagina/scribus-patched/blob/appimage/AppImage-package/AppRun#L61 if somebody has a clue on how to detect that, help is welcome! |
|
|
here is the ************************* P A T C H ************************* without all the images which have to be taken from @luna nightshade 7zip file! (i hope that i got the patch right and i don't miss any file... the full patch is here: https://gitlab.com/impagina/scribus-patched/compare/appimage...dark ) dark.diff (2,374 bytes) |
|
|
I am using Linux MINT 19.1 with the MATE Desktop (which apparently is a derivative of gnome 2). |
|
|
then, it's very likely that the issue you are seeing is with the way the appimage is built, not with this patch. @jghali, would you mind accepting this patch? |
|
|
@luna nightshade ... i have now a vm with mint + mate... how can I get the same theme as you have? |
|
|
I have "Mint-Y-Dark-Blue", which can be set via the "Appearance" App in the "Preferences" Category. Just set the Theme there. |
|
|
The dark icon theme has now been committed to trunk. |
|
|
thanks jean! |
- Anonymous
