View Issue Details

IDProjectCategoryView StatusLast Update
0015590ScribusInternalpublic2019-03-10 23:31
Reporterale Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status newResolutionopen 
Product Version1.5.5.svn 
Target VersionFixed in Version 
Summary0015590: Remove bool removeMenuItem(ScrAction *menuAction, const QString &parent)
Descriptionremove bool removeMenuItem(ScrAction *menuAction, const QString &parent) from

https://github.com/scribusproject/scribus/blob/master/scribus/menumanager.h#L55



it's not implemented

https://github.com/scribusproject/scribus/blob/master/scribus/menumanager.cpp#L289

and if one only looks at the .h will lose time wondering why it does not work.


on the other side, removing a menu by (QString, Qstring) would be nice...
TagsNo tags attached.
PatchNo

Activities

ale

2019-03-07 09:16

manager   ~0045972

MenuManager::runMenuAtPos(const QString &menuName, const QPoint position)

should also be removed for the very same reason (MeneManager is extended once, but the two mentioned function are not overloaded)

ale

2019-03-07 09:48

manager   ~0045973

this is also problematic:

void MenuManager::setMenuEnabled(const QString &menuName, const bool enabled)
{
    // OSX UI rules don't allow this so let's not do it elsewhere.
    //if (menuBarMenus.contains(menuName) && menuBarMenus.value(menuName)!=nullptr)
    // menuBarMenus.value(menuName)->setEnabled(enabled);
}


the "inner" comment should go to the .h file and the function can probably be commented out... (if you really want to avoid that somebody tries to implement it in the future...)

jghali

2019-03-10 23:31

administrator   ~0045986

>> MenuManager::runMenuAtPos(const QString &menuName, const QPoint position) should also be removed for the very same reason

Probably not, this function is actually used in canvasgesture_cellselect.cpp and having it implemented make in fact sense.

Issue History

Date Modified Username Field Change
2019-03-07 09:12 ale New Issue
2019-03-07 09:16 ale Note Added: 0045972
2019-03-07 09:48 ale Note Added: 0045973
2019-03-10 12:47 jghali Category - => Internal
2019-03-10 12:47 jghali Summary remove bool removeMenuItem(ScrAction *menuAction, const QString &parent) => Remove bool removeMenuItem(ScrAction *menuAction, const QString &parent)
2019-03-10 23:31 jghali Note Added: 0045986