View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015590 | Scribus | Internal | public | 2019-03-07 09:12 | 2019-03-10 23:31 |
| Reporter | ale | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Product Version | 1.5.5.svn | ||||
| Summary | 0015590: Remove bool removeMenuItem(ScrAction *menuAction, const QString &parent) | ||||
| Description | remove bool removeMenuItem(ScrAction *menuAction, const QString &parent) from https://github.com/scribusproject/scribus/blob/master/scribus/menumanager.h#L55 it's not implemented https://github.com/scribusproject/scribus/blob/master/scribus/menumanager.cpp#L289 and if one only looks at the .h will lose time wondering why it does not work. on the other side, removing a menu by (QString, Qstring) would be nice... | ||||
| Tags | No tags attached. | ||||
| Patch | No | ||||
|
|
MenuManager::runMenuAtPos(const QString &menuName, const QPoint position) should also be removed for the very same reason (MeneManager is extended once, but the two mentioned function are not overloaded) |
|
|
this is also problematic: void MenuManager::setMenuEnabled(const QString &menuName, const bool enabled) { // OSX UI rules don't allow this so let's not do it elsewhere. //if (menuBarMenus.contains(menuName) && menuBarMenus.value(menuName)!=nullptr) // menuBarMenus.value(menuName)->setEnabled(enabled); } the "inner" comment should go to the .h file and the function can probably be commented out... (if you really want to avoid that somebody tries to implement it in the future...) |
|
|
>> MenuManager::runMenuAtPos(const QString &menuName, const QPoint position) should also be removed for the very same reason Probably not, this function is actually used in canvasgesture_cellselect.cpp and having it implemented make in fact sense. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-03-07 09:12 | ale | New Issue | |
| 2019-03-07 09:16 | ale | Note Added: 0045972 | |
| 2019-03-07 09:48 | ale | Note Added: 0045973 | |
| 2019-03-10 12:47 | jghali | Category | - => Internal |
| 2019-03-10 12:47 | jghali | Summary | remove bool removeMenuItem(ScrAction *menuAction, const QString &parent) => Remove bool removeMenuItem(ScrAction *menuAction, const QString &parent) |
| 2019-03-10 23:31 | jghali | Note Added: 0045986 |
