View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0015709 | Scribus | Build System | public | 2019-06-12 08:47 | 2019-07-30 21:27 |
Reporter | ale | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Fixed in Version | 1.5.5.svn | ||||
Summary | 0015709: Missing docstring in cmake set command | ||||
Description | houz is reporting a cmake error in https://github.com/scribusproject/scribus/blob/master/CMakeLists.txt#L227 because of a missing string. i did not spot a change that might trigger this error now... but this set is indeed the only one in that "region" that has no string comment... it would be good to have one there too... and maybe this will fix houz' issue... | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
At least on Fedora (29, 30 and rawhide) this not fix the 64bit builds yet. There is still one string missing. The following is a hotfix: sed -ie 's/set(LIB_SUFFIX "64" CACHE STRING)/set(LIB_SUFFIX "64" CACHE STRING "library suffix")/' CMakeLists.txt With this, builds succeed again. |
|
Thanks for the note, I added this missing docstring. |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-06-12 08:47 | ale | New Issue | |
2019-06-12 10:14 | jghali | Summary | missing a set comment in the main CMakeLists.txt => missing docstring in set command in the main CMakeLists.txt |
2019-06-12 10:14 | jghali | Assigned To | => jghali |
2019-06-12 10:14 | jghali | Status | new => resolved |
2019-06-12 10:14 | jghali | Resolution | open => fixed |
2019-06-12 10:14 | jghali | Fixed in Version | => 1.5.5.svn |
2019-06-12 10:27 | jghali | Summary | missing docstring in set command in the main CMakeLists.txt => Missing docstring in cmake set command |
2019-06-28 13:54 | mjg | Note Added: 0046349 | |
2019-06-28 14:30 | jghali | Note Added: 0046350 | |
2019-07-30 21:27 | cbradney | Status | resolved => closed |