View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0015741 | Scribus | Internal | public | 2019-07-16 16:21 | 2019-12-08 21:24 |
Reporter | ale | Assigned To | cbradney | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 1.5.5.svn | ||||
Fixed in Version | 1.5.6.svn | ||||
Summary | 0015741: do not return int from PreferencesDialog::addItem() | ||||
Description | PreferencesDialog::addItem() retuns a counter, but the value is not read by any call to it. i suggest to remove the return value. https://gitlab.com/scribus/scribus/blob/master/scribus/ui/preferencesdialog.cpp#L290 | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
I don't think there is any benefit in doing so. That function is also a plugin api, so we may even break some user plugins by changing this function signature. |
|
i don't think that any users' plugin exist. from what we have experienced in the last couple of years, i see scribus getting more interest from "serious" users and it would be nice to clean up its code before that happens. and the benefit is: having interfaces that are not misleading, that do not require the user to check what the valid return values are, if there are no return values. |
|
API is protected anyway.. and we have a plugin API to allow this to work. I have this.. got some other changes with it too. |
Date Modified | Username | Field | Change |
---|---|---|---|
2019-07-16 16:21 | ale | New Issue | |
2019-07-16 18:56 | jghali | Category | - => Internal |
2019-07-16 19:03 | jghali | Note Added: 0046396 | |
2019-07-16 19:04 | jghali | Note Edited: 0046396 | |
2019-07-18 06:49 | ale | Note Added: 0046416 | |
2019-08-06 21:39 | cbradney | Assigned To | => cbradney |
2019-08-06 21:39 | cbradney | Status | new => assigned |
2019-08-06 21:39 | cbradney | Note Added: 0046441 | |
2019-08-06 21:40 | cbradney | Note Edited: 0046441 | |
2019-08-07 19:37 | cbradney | Status | assigned => resolved |
2019-08-07 19:37 | cbradney | Resolution | open => fixed |
2019-08-07 19:37 | cbradney | Fixed in Version | => 1.5.6.svn |
2019-12-08 21:24 | cbradney | Status | resolved => closed |