View Issue Details

IDProjectCategoryView StatusLast Update
0015928ScribusGeneralpublic2019-11-07 22:36
Reporterale Assigned Toale  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.6.svn 
Target VersionFixed in Version1.5.6.svn 
Summary0015928: Multiple duplicate on page must clear the content of the new linked text frames
Descriptionif you multiple duplicate on pages, and choose to link the new text frames to the current ones, the content of the duplicates must be cleared before doing the link.

otherwise, the text gets duplicated...
TagsNo tags attached.
PatchYes

Activities

ale

2019-11-07 20:48

manager  

clear-multiple-duplicate-in-chain.diff (478 bytes)
diff --git a/scribus/scribusdoc.cpp b/scribus/scribusdoc.cpp
index 9389f6395..6db666803 100644
--- a/scribus/scribusdoc.cpp
+++ b/scribus/scribusdoc.cpp
@@ -13731,6 +13731,7 @@ void ScribusDoc::multipleDuplicateByPage(const ItemMultipleDuplicateData& dialog
 			PageItem* item = Items->at(i);
 			if (item->itemType() != PageItem::TextFrame)
 				continue;
+			item->asTextFrame()->clearContents();
 			if (item->isInChain())
 			{
 				lastInChain->link(item->firstInChain());

jghali

2019-11-07 22:36

administrator   ~0047025

Applied! I removed the asTextFrame() part however as it is unnecessary : clearContents() is a PageItem virtual function reimplemented by PageItem_TextFrame.

Issue History

Date Modified Username Field Change
2019-11-07 20:35 ale New Issue
2019-11-07 20:35 ale Status new => assigned
2019-11-07 20:35 ale Assigned To => ale
2019-11-07 20:48 ale Summary multiple duplicate on page must clear the content of the new linked text frames => [PATCH] multiple duplicate on page must clear the content of the new linked text frames
2019-11-07 20:48 ale Patch No => Yes
2019-11-07 20:48 ale File Added: clear-multiple-duplicate-in-chain.diff
2019-11-07 22:32 jghali Summary [PATCH] multiple duplicate on page must clear the content of the new linked text frames => Multiple duplicate on page must clear the content of the new linked text frames
2019-11-07 22:36 jghali Status assigned => resolved
2019-11-07 22:36 jghali Resolution open => fixed
2019-11-07 22:36 jghali Fixed in Version => 1.5.6.svn
2019-11-07 22:36 jghali Note Added: 0047025