View Issue Details

IDProjectCategoryView StatusLast Update
0015983ScribusGeneralpublic2020-05-08 17:17
Reporterale Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
Status newResolutionopen 
Product Version1.5.6.svn 
Summary0015983: [PATCH] thirdparty/pgf: libpgf is packaged for debian and maintained
Descriptionsince libpgf is packaged for debian and maintained, wouldn't it be better to use the upstream libraries?

http://www.libpgf.org/index.php?id=3

or at least update the thirdparty code to the current one

(i've noticed that pgf exist because of warnings popping up while compiling...)
TagsNo tags attached.
PatchYes

Activities

christoph_s

2019-12-02 23:58

developer   ~0047190

I suggest option 2, because it needs to be available not only for Debian but also other distros, as well as Windows and Mac OSX.

ale

2019-12-03 11:03

manager   ~0047191

- https://software.opensuse.org/package/libpgf
- https://src.fedoraproject.org/rpms/libpgf

- for windows we never use packaged libraries, so it's about providing our own .dll (if upstream does not provide one)
- no idea how the packaging for macos works, but i guess that it will be the same as for the librevenge libraries (as an example)

all in all, i think that we should avoid providing copies of libraries that are maintained and normally distributed through other means.

cbradney

2019-12-08 21:35

administrator   ~0047214

I can get it from macports, but I am not sure why we've brought it in source. Either it was not maintained for awhile, or we had to modify significant portions of the code to make use of it, or it was a massive library we didnt need all of.

cbradney

2019-12-08 21:37

administrator   ~0047215

Author: fschmid
Date: Sun Nov 7 09:40:03 2010
New Revision: 15796

URL: http://scribus.info/websvn/listing.php?repname=Scribus&sc=1&rev=15796
Log:
Added the PGF image format, see http://www.libpgf.org for details.



To remove this, we'd need a CMake finder module to start with

ale

2019-12-08 21:47

manager   ~0047217

it has been in debian since 2012... so at the time franz added it, it's likely that it was not packaged by the distributions.

i'm not sure that a pgf file has ever been used in a scribus document, but i might try to find out if i can use the debian package...

i might have a look at it...

ale

2019-12-09 10:58

manager   ~0047227

ok, i had a look it.

libpgf does not have cmake files. so, before we can use their lib they should probably add support for cmake...
and then wait for the new version of the library to hit most distributions.

i guess that we should copy a new version then... and the next time think about removing support for it... except if it gets traction...

ale

2019-12-09 11:02

manager   ~0047228

Last edited: 2019-12-09 11:03

... oops... it has a cmakelists.txt file...

... but probably not in the version distributed by debian...

cbradney

2019-12-09 11:21

administrator   ~0047229

We aren’t removing support for the file format.

ale

2019-12-13 09:45

manager   ~0047262

Last edited: 2019-12-13 17:39

a patch is here
https://gitlab.com/scribus/scribus/merge_requests/20

and it's also attached.

libpgf.diff (269,637 bytes)   

jghali

2020-05-08 16:42

administrator   ~0047604

Last edited: 2020-05-08 16:57

I updated our libpgf copy to 7.19.3. I also re-applied some of our own patches to fix some warnings and allow it to build on Haiku.

ale

2020-05-08 17:17

manager   ~0047607

i guess that it would not be a bad idea to provide the patches upstream...

Issue History

Date Modified Username Field Change
2019-12-02 15:56 ale New Issue
2019-12-02 23:58 christoph_s Note Added: 0047190
2019-12-03 11:03 ale Note Added: 0047191
2019-12-08 21:35 cbradney Note Added: 0047214
2019-12-08 21:37 cbradney Note Added: 0047215
2019-12-08 21:47 ale Note Added: 0047217
2019-12-09 10:58 ale Note Added: 0047227
2019-12-09 11:02 ale Note Added: 0047228
2019-12-09 11:03 ale Note Edited: 0047228
2019-12-09 11:21 cbradney Note Added: 0047229
2019-12-13 09:45 ale File Added: libpgf.diff
2019-12-13 09:45 ale Note Added: 0047262
2019-12-13 10:06 ale Summary thirdparty/pgf: libpgf is packaged for debian and maintained => [PATCH] thirdparty/pgf: libpgf is packaged for debian and maintained
2019-12-13 10:06 ale Patch No => Yes
2019-12-13 17:39 ale Note Edited: 0047262
2020-05-08 16:42 jghali Note Added: 0047604
2020-05-08 16:57 jghali Note Edited: 0047604
2020-05-08 17:17 ale Note Added: 0047607