View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0015997 | Scribus | public | 2019-12-09 08:04 | 2020-11-12 08:23 | |
| Reporter | ale | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | N/A |
| Status | new | Resolution | open | ||
| Product Version | 1.5.6.svn | ||||
| Summary | 0015997: [PATCH] move the export to PDF to the main file menu | ||||
| Description | we keep on experiencing people that fail at printing with scribus (most of all with landscape documents). it's tiring to tell all those people that scribus is made for producing PDFs that will be printed at a print shop and not for direct printing on an office / home printer. and many people have a hard time accepting this fact. this patch moves the "export to pdf" to the main file menu, just before the print command. and renames it to "Produce PDF", to make it clear that it's not just one export among many others. if you don't feel like renaming the command (or have a better label than "Produce PDF") feel free to revert that part to the current label. the important part is to move the exporting Pdf at the root of the "File" menu. before the printing. | ||||
| Tags | No tags attached. | ||||
| Patch | Yes | ||||
|
|
pdf-produce.diff (4,944 bytes)
diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index 7c9cda5a2..c0fb241c9 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -147,19 +147,14 @@ void ActionManager::initFileMenuActions()
scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
name = "fileExportAsEPS";
scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
- name = "fileExportAsPDF";
- scrActions->insert(name, new ScrAction(im.loadPixmap("acroread16.png"), im.loadPixmap("acroread22.png"), "", defaultKey(name), mainWindow));
//Rest of File Menu
-// name = "fileDocSetup";
-// scrActions->insert(name, new ScrAction(im.loadPixmap("16/document-properties.png"), im.loadPixmap("22/document-properties.png"), "", defaultKey(name), mainWindow));
name = "fileDocSetup150";
scrActions->insert(name, new ScrAction(im.loadPixmap("16/document-properties.png"), im.loadPixmap("22/document-properties.png"), "", defaultKey(name), mainWindow));
-// name = "filePreferences";
-// scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
-// (*scrActions)[name]->setMenuRole(QAction::NoRole);
name = "filePreferences150";
scrActions->insert(name, new ScrAction("", defaultKey(name), mainWindow));
(*scrActions)[name]->setMenuRole(QAction::PreferencesRole);
+ name = "fileExportAsPDF";
+ scrActions->insert(name, new ScrAction(im.loadPixmap("acroread16.png"), im.loadPixmap("acroread22.png"), "", defaultKey(name), mainWindow));
name = "filePrint";
scrActions->insert(name, new ScrAction(im.loadPixmap("16/document-print.png"), im.loadPixmap("22/document-print.png"), "", defaultKey(name), mainWindow));
name = "PrintPreview";
@@ -174,6 +169,7 @@ void ActionManager::initFileMenuActions()
connect( (*scrActions)["fileNewFromTemplate"], SIGNAL(triggered()), mainWindow, SLOT(newFileFromTemplate()) );
connect( (*scrActions)["fileOpen"], SIGNAL(triggered()), mainWindow, SLOT(slotFileOpen()) );
connect( (*scrActions)["fileClose"], SIGNAL(triggered()), mainWindow, SLOT(slotFileClose()) );
+ connect( (*scrActions)["fileExportAsPDF"], SIGNAL(triggered()), mainWindow, SLOT(SaveAsPDF()) );
connect( (*scrActions)["filePrint"], SIGNAL(triggered()), mainWindow, SLOT(slotFilePrint()) );
connect( (*scrActions)["PrintPreview"], SIGNAL(triggered()), mainWindow, SLOT(printPreview()) );
connect( (*scrActions)["fileSave"], SIGNAL(triggered()), mainWindow, SLOT(slotFileSave()) );
@@ -192,7 +188,6 @@ void ActionManager::initFileMenuActions()
//File Export Menu
connect( (*scrActions)["fileExportText"], SIGNAL(triggered()), mainWindow, SLOT(SaveText()) );
connect( (*scrActions)["fileExportAsEPS"], SIGNAL(triggered()), mainWindow, SLOT(SaveAsEps()) );
- connect( (*scrActions)["fileExportAsPDF"], SIGNAL(triggered()), mainWindow, SLOT(SaveAsPDF()) );
//The rest are plugins
@@ -1497,11 +1492,9 @@ void ActionManager::languageChange()
(*scrActions)["fileExportText"]->setTexts( tr("Save &Text..."));
(*scrActions)["fileExportAsEPS"]->setTexts( tr("Save as &EPS..."));
- (*scrActions)["fileExportAsPDF"]->setTexts( tr("Save as P&DF..."));
-// (*scrActions)["fileDocSetup"]->setTexts( tr("Document &Setup (old)..."));
(*scrActions)["fileDocSetup150"]->setTexts( tr("Document &Setup..."));
-// (*scrActions)["filePreferences"]->setTexts( tr("P&references (old)..."));
(*scrActions)["filePreferences150"]->setTexts( tr("P&references..."));
+ (*scrActions)["fileExportAsPDF"]->setTexts( tr("Produce P&DF..."));
(*scrActions)["filePrint"]->setTexts( tr("&Print..."));
(*scrActions)["PrintPreview"]->setTexts( tr("Print Previe&w..."));
(*scrActions)["fileQuit"]->setTexts( tr("&Quit"));
@@ -2070,11 +2063,9 @@ void ActionManager::createDefaultMenus()
<< "fileImportVector"
<< "fileExportText"
<< "fileExportAsEPS"
- << "fileExportAsPDF"
-// << "fileDocSetup"
<< "fileDocSetup150"
-// << "filePreferences"
<< "filePreferences150"
+ << "fileExportAsPDF"
<< "filePrint"
<< "PrintPreview"
<< "fileQuit";
diff --git a/scribus/scribus.cpp b/scribus/scribus.cpp
index 07fe6aa5f..90c9cb2ce 100644
--- a/scribus/scribus.cpp
+++ b/scribus/scribus.cpp
@@ -812,11 +812,11 @@ void ScribusMainWindow::initMenuBar()
scrMenuMgr->createMenu("FileExport", tr("&Export"), "File");
scrMenuMgr->addMenuItemString("fileExportText", "FileExport");
scrMenuMgr->addMenuItemString("fileExportAsEPS", "FileExport");
- scrMenuMgr->addMenuItemString("fileExportAsPDF", "FileExport");
scrMenuMgr->addMenuItemString("SEPARATOR", "File");
scrMenuMgr->addMenuItemString("fileDocSetup150", "File");
scrMenuMgr->addMenuItemString("filePreferences150", "File");
scrMenuMgr->addMenuItemString("SEPARATOR", "File");
+ scrMenuMgr->addMenuItemString("fileExportAsPDF", "File");
scrMenuMgr->addMenuItemString("filePrint", "File");
if ( ScCore->haveGS() || ScCore->isWinGUI() )
scrMenuMgr->addMenuItemString("PrintPreview", "File");
|
|
|
That makes sense |
|
|
ping. can we have this? really, scribus IS about producing PDFs. |
