View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0016274 | Scribus | Internal | public | 2020-10-22 06:43 | 2020-11-07 14:52 |
| Reporter | ale | Assigned To | ale | ||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.5.6.svn | ||||
| Fixed in Version | 1.5.6.svn | ||||
| Summary | 0016274: Remove outdated FIXME | ||||
| Description | - the first comment does not seem to point to any valid fixme (and the code compiles without the include) - the second seem to refer to setLock and setLock does use toggleLock(). | ||||
| Tags | No tags attached. | ||||
| Attached Files | outdated-fixme.diff (970 bytes)
diff --git a/scribus/plugins/scriptplugin/cmdmani.cpp b/scribus/plugins/scriptplugin/cmdmani.cpp
index db30970e3..ce73006a1 100644
--- a/scribus/plugins/scriptplugin/cmdmani.cpp
+++ b/scribus/plugins/scriptplugin/cmdmani.cpp
@@ -11,7 +11,6 @@ for which a new license (GPL+exception) is in place.
#include "scribusview.h"
#include "sctextstream.h"
#include "selection.h"
-#include "ui/propertiespalette.h" //CB argh.. noooooooooooooooooooooooooooooooooooo FIXME see other FIXME
#include "undomanager.h"
@@ -516,8 +515,6 @@ PyObject *scribus_islocked(PyObject* /* self */, PyObject* args)
char *name = const_cast<char*>("");
if (!PyArg_ParseTuple(args, "|es", "utf-8", &name))
return nullptr;
- // FIXME: Rather than toggling the lock, we should probably let the user set the lock state
- // and instead provide a different function like toggleLock()
if (!checkHaveDocument())
return nullptr;
PageItem *item = GetUniqueItem(QString::fromUtf8(name));
| ||||
| Patch | Yes | ||||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-10-22 06:43 | ale | New Issue | |
| 2020-10-22 06:43 | ale | File Added: outdated-fixme.diff | |
| 2020-10-22 07:18 | ale | Summary | remove two outdated FIXME => [PATCH] remove two outdated FIXME |
| 2020-10-22 07:18 | ale | Patch | No => Yes |
| 2020-10-22 11:29 | jghali | Note Added: 0048179 | |
| 2020-10-22 11:29 | jghali | Category | Scripter => Internal |
| 2020-10-22 11:33 | jghali | Summary | [PATCH] remove two outdated FIXME => Remove outdated FIXME |
| 2020-10-22 11:33 | jghali | Assigned To | => ale |
| 2020-10-22 11:33 | jghali | Status | new => resolved |
| 2020-10-22 11:33 | jghali | Resolution | open => fixed |
| 2020-10-22 11:33 | jghali | Fixed in Version | => 1.5.6.svn |
| 2020-11-07 14:52 | cbradney | Status | resolved => closed |