View Issue Details

IDProjectCategoryView StatusLast Update
0016362ScribusUser Interfacepublic2020-11-28 22:42
Reporterbubu Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.7.svn 
Target VersionFixed in Version1.5.7.svn 
Summary0016362: Remove margin from arc, polygon, spiral, margin (& bleed) widgets to prevent double and triple margins in Preferences dialog
DescriptionIn Preferences dialog in general there are no margins around the elements. But there are some inserted external custom widgets witch has own margins and therefore we get finally double margins:
- Preferences / Item Tools / Regular Polygons
- Preferences / Item Tools / Arc
- Preferences / Item Tools / Spiral

As I see Arc and Spiral widget is used just once. But Polygon widget is used in Preferences dialog and in Insert > Polygon > Properties... This interface is affected by double margin issue.

Margin (and Bleed) widget is inserted 3 times in Preferences dialog:
- Preferences > Document Setup > Margins and Bleeds (there is an additional extra 3th margin.)
- Preferences > Printer
- Preferences > PDF Export > Pre-press

This patch removes all mentioned margins.
Please, review the patch. Thanks!
TagsNo tags attached.
PatchYes

Activities

bubu

2020-11-28 10:39

reporter  

Remove_extra_margins.diff (4,851 bytes)
diff --git a/scribus/ui/arcwidgetbase.ui b/scribus/ui/arcwidgetbase.ui
index 01a23e379e7b7bfa10868a562a7f1464f9e02b35..88722148953e83385fc456c290cddd6dde5aa003 100644
--- a/scribus/ui/arcwidgetbase.ui
+++ b/scribus/ui/arcwidgetbase.ui
@@ -26,6 +26,18 @@
    <string notr="true">Form</string>
   </property>
   <layout class="QHBoxLayout" name="horizontalLayout">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>
    <item>
     <layout class="QVBoxLayout" name="verticalLayout">
      <item>
diff --git a/scribus/ui/newmarginwidgetbase.ui b/scribus/ui/newmarginwidgetbase.ui
index 31327ca4f3909bc53f4f68c1693c2baa3b9513ce..27516a6cea2e18cc9455880ef6d91a6af1be4670 100644
--- a/scribus/ui/newmarginwidgetbase.ui
+++ b/scribus/ui/newmarginwidgetbase.ui
@@ -20,6 +20,18 @@
    <string notr="true">Form</string>
   </property>
   <layout class="QGridLayout" name="gridLayout_2">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>
    <item row="0" column="0">
     <layout class="QGridLayout" name="gridLayout">
      <item row="4" column="0">
diff --git a/scribus/ui/polygonwidgetbase.ui b/scribus/ui/polygonwidgetbase.ui
index 7beb4c6865c8cbb232423b0f8173aa50fefb9a1d..dffd8e9c86cca2173d064c24f00f070261ba921a 100644
--- a/scribus/ui/polygonwidgetbase.ui
+++ b/scribus/ui/polygonwidgetbase.ui
@@ -20,6 +20,18 @@
    <string notr="true"/>
   </property>
   <layout class="QGridLayout" name="gridLayout_3">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
+   <property name="bottomMargin">
+    <number>0</number>
+   </property>
    <item row="0" column="0">
     <layout class="QGridLayout" name="gridLayout">
      <item row="0" column="0">
diff --git a/scribus/ui/prefs_documentsetupbase.ui b/scribus/ui/prefs_documentsetupbase.ui
index 99f2e383f0de0f067d777cd3cad8ab09a7d58025..715eb78b74a8e94a1c57f945c5e852b190ad2d15 100644
--- a/scribus/ui/prefs_documentsetupbase.ui
+++ b/scribus/ui/prefs_documentsetupbase.ui
@@ -388,16 +388,16 @@
            <item>
             <layout class="QHBoxLayout" name="horizontalLayout_6">
              <property name="leftMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="topMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="rightMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="bottomMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <item>
               <widget class="NewMarginWidget" name="marginsWidget" native="true"/>
@@ -470,16 +470,16 @@
            <item>
             <layout class="QHBoxLayout" name="horizontalLayout_7">
              <property name="leftMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="topMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="rightMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <property name="bottomMargin">
-              <number>5</number>
+              <number>0</number>
              </property>
              <item>
               <widget class="NewMarginWidget" name="bleedsWidget" native="true"/>
diff --git a/scribus/ui/spiralwidgetbase.ui b/scribus/ui/spiralwidgetbase.ui
index 0a0af43f570b3492fc0192265d442b0263b45945..17629fa04ad334019a235361e97e3a81d6290f74 100644
--- a/scribus/ui/spiralwidgetbase.ui
+++ b/scribus/ui/spiralwidgetbase.ui
@@ -26,6 +26,15 @@
    <string notr="true">Form</string>
   </property>
   <layout class="QHBoxLayout" name="horizontalLayout">
+   <property name="leftMargin">
+    <number>0</number>
+   </property>
+   <property name="topMargin">
+    <number>0</number>
+   </property>
+   <property name="rightMargin">
+    <number>0</number>
+   </property>
    <item>
     <layout class="QVBoxLayout" name="verticalLayout">
      <item>
Remove_extra_margins.png (1,373,545 bytes)

Issue History

Date Modified Username Field Change
2020-11-28 10:39 bubu New Issue
2020-11-28 10:39 bubu File Added: Remove_extra_margins.diff
2020-11-28 10:39 bubu File Added: Remove_extra_margins.png
2020-11-28 22:42 cbradney Assigned To => cbradney
2020-11-28 22:42 cbradney Status new => resolved
2020-11-28 22:42 cbradney Resolution open => fixed
2020-11-28 22:42 cbradney Fixed in Version => 1.5.7.svn