View Issue Details

IDProjectCategoryView StatusLast Update
0016367ScribusUser Interfacepublic2020-12-08 11:31
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.7.svn 
Target VersionFixed in Version1.5.7.svn 
Summary0016367: Remove frame border from hidden scrollareas in main Preferences dialog
DescriptionWe are done with scrollareas inside tabs in 0016352. There are more 11 interfaces on Preferences dialog where are scrollareas in main panel.

There are 7 panels where the scrollbar is always hidden:
- Preferences > Path
- Preferences > Keyboard Shortcats
- Preferences > Image Catch
- Preferences > Scrapbook
- Preferences > Miscelleneous
- Preferences > Table of Contents
- Preferences > Scripter

This patch removes the frame border around the scrollareas and the standard 9px margin. The interface is more cleaner without borders. (There is no need to make background transparent.) See the attached before-after schreenshot. Review the patch, please. Thanks.

(Other 4 scrollareas are real scrollable interfaces. I leave them untached:
- prefs_printerbase.ui
- prefs_externaltoolsbase.ui
- prefs_colormanagementbase.ui
- prefs_typographybase.ui)
TagsNo tags attached.
PatchYes

Activities

bubu

2020-11-29 00:47

reporter  

non-framed_scrollareas.diff (9,197 bytes)
diff --git a/scribus/plugins/scriptplugin/prefs_scripterbase.ui b/scribus/plugins/scriptplugin/prefs_scripterbase.ui
index 7c35b7505c0cba228e9d55271bb4a2b6d80ce27e..3add1f14792e2189ba1ca64e4289485d1885a6f7 100644
--- a/scribus/plugins/scriptplugin/prefs_scripterbase.ui
+++ b/scribus/plugins/scriptplugin/prefs_scripterbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,15 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QLabel" name="extensionsTitleLabel">
          <property name="font">
diff --git a/scribus/plugins/scriptplugin_py2x/prefs_scripterbase.ui b/scribus/plugins/scriptplugin_py2x/prefs_scripterbase.ui
index 7c35b7505c0cba228e9d55271bb4a2b6d80ce27e..3add1f14792e2189ba1ca64e4289485d1885a6f7 100644
--- a/scribus/plugins/scriptplugin_py2x/prefs_scripterbase.ui
+++ b/scribus/plugins/scriptplugin_py2x/prefs_scripterbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,15 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QLabel" name="extensionsTitleLabel">
          <property name="font">
diff --git a/scribus/ui/prefs_imagecachebase.ui b/scribus/ui/prefs_imagecachebase.ui
index cad677ec6355c23f424ea1f3e8f37ddd701eccdc..69bab9bdd238775799fe6cd7e8c1b6ad142fcc16 100644
--- a/scribus/ui/prefs_imagecachebase.ui
+++ b/scribus/ui/prefs_imagecachebase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,15 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_2">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QCheckBox" name="enableImageCacheCheckBox">
          <property name="text">
diff --git a/scribus/ui/prefs_keyboardshortcutsbase.ui b/scribus/ui/prefs_keyboardshortcutsbase.ui
index 0d7db6bd5d76664f5f2fdd897ceaf2df4e9e82da..f0bd8b6d8233121399702c39ab2b5147eecd9be5 100644
--- a/scribus/ui/prefs_keyboardshortcutsbase.ui
+++ b/scribus/ui/prefs_keyboardshortcutsbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,18 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_2">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
        <item>
         <layout class="QHBoxLayout">
          <item>
diff --git a/scribus/ui/prefs_miscellaneousbase.ui b/scribus/ui/prefs_miscellaneousbase.ui
index bb863e9a1c2c2c4965c1b2d3c963f1564c674923..c2e0702e90da4e4db0d99177394a347cde687d5d 100644
--- a/scribus/ui/prefs_miscellaneousbase.ui
+++ b/scribus/ui/prefs_miscellaneousbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,15 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QCheckBox" name="confirmFontReplacementsCheckBox">
          <property name="text">
diff --git a/scribus/ui/prefs_pathsbase.ui b/scribus/ui/prefs_pathsbase.ui
index 34d766e53f261de296d157229185440959ef7d6a..31ad79b73b2f0eae13dc133a9e55abe8746904b7 100644
--- a/scribus/ui/prefs_pathsbase.ui
+++ b/scribus/ui/prefs_pathsbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,18 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_2">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
        <item>
         <layout class="QGridLayout" name="gridLayout">
          <item row="0" column="0">
diff --git a/scribus/ui/prefs_scrapbookbase.ui b/scribus/ui/prefs_scrapbookbase.ui
index 968f9f828a36af7dc5b393e956c27af4d1999fa8..dfda58729cf68e67b2653697cb29fd1fab4c625b 100644
--- a/scribus/ui/prefs_scrapbookbase.ui
+++ b/scribus/ui/prefs_scrapbookbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,18 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_2">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QCheckBox" name="autoSendCopiedToScrapCheckBox">
          <property name="text">
diff --git a/scribus/ui/prefs_tableofcontentsbase.ui b/scribus/ui/prefs_tableofcontentsbase.ui
index 8802cab6544444c699ec97abb0fccddc932573bc..dd59575b207e26cd587a1a89d02b70af76cb463f 100644
--- a/scribus/ui/prefs_tableofcontentsbase.ui
+++ b/scribus/ui/prefs_tableofcontentsbase.ui
@@ -37,6 +37,12 @@
    </item>
    <item>
     <widget class="QScrollArea" name="scrollArea">
+     <property name="frameShape">
+      <enum>QFrame::NoFrame</enum>
+     </property>
+     <property name="frameShadow">
+      <enum>QFrame::Plain</enum>
+     </property>
      <property name="widgetResizable">
       <bool>true</bool>
      </property>
@@ -50,6 +56,15 @@
        </rect>
       </property>
       <layout class="QVBoxLayout" name="verticalLayout_2">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QListWidget" name="tocListBox"/>
        </item>
non-framed_scrollareas.png (1,383,357 bytes)

jghali

2020-12-08 11:31

administrator   ~0048539

Applied, thanks!

Issue History

Date Modified Username Field Change
2020-11-29 00:47 bubu New Issue
2020-11-29 00:47 bubu File Added: non-framed_scrollareas.diff
2020-11-29 00:47 bubu File Added: non-framed_scrollareas.png
2020-12-08 11:31 jghali Assigned To => jghali
2020-12-08 11:31 jghali Status new => resolved
2020-12-08 11:31 jghali Resolution open => fixed
2020-12-08 11:31 jghali Fixed in Version => 1.5.7.svn
2020-12-08 11:31 jghali Note Added: 0048539