View Issue Details

IDProjectCategoryView StatusLast Update
0016389ScribusUser Interfacepublic2020-12-15 10:42
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.7.svn 
Target VersionFixed in Version1.5.7.svn 
Summary0016389: Update layout for Multiple Duplicate dialog
DescriptionIn this dialog I propose two changes. Please see the before-after screenshot:
- On first tab there is an unnamed group box causing an empty line. I suggest to remove the group box, it is unnecessary. Otherwise we should be add a title for it.
- On second tab there is an unnecessary spacer on the top causing form to display vertically on the middle. I suggest to remove this spacer and align form vertically on the top, because this is the default layout.

Diff is not so clear but there is nothing else. Please review the attached patch. Thanks.
TagsNo tags attached.
PatchYes

Activities

PeterBenedek

2020-12-15 10:10

developer   ~0048559

bubu, you forgot to attach the files.

bubu

2020-12-15 10:32

reporter   ~0048560

Ups, sorry.

multiple_duplicate.diff (9,709 bytes)
diff --git a/scribus/ui/multipleduplicate.ui b/scribus/ui/multipleduplicate.ui
index ca15ea3518c7fa18debe0cc10235c7873b4e086c..fea6ba66bacae26cd7646bab1d09adf2bb8d51cc 100644
--- a/scribus/ui/multipleduplicate.ui
+++ b/scribus/ui/multipleduplicate.ui
@@ -9,8 +9,8 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>329</width>
-    <height>302</height>
+    <width>426</width>
+    <height>291</height>
    </rect>
   </property>
   <property name="sizePolicy">
@@ -59,8 +59,8 @@
       <layout class="QVBoxLayout" name="verticalLayout">
        <item>
         <layout class="QGridLayout" name="gridLayout_2">
-         <item row="3" column="1">
-          <widget class="ScrSpinBox" name="vertShiftSpinBox">
+         <item row="5" column="1">
+          <widget class="ScrSpinBox" name="rotationSpinBox">
            <property name="minimumSize">
             <size>
              <width>0</width>
@@ -69,70 +69,57 @@
            </property>
           </widget>
          </item>
-         <item row="2" column="0">
-          <widget class="QLabel" name="horizShiftLabel">
+         <item row="0" column="0">
+          <widget class="QLabel" name="numberOfCopiesLabel">
            <property name="text">
-            <string>&amp;Horizontal Shift:</string>
+            <string>&amp;Number of Copies:</string>
            </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
            <property name="buddy">
-            <cstring>horizShiftSpinBox</cstring>
+            <cstring>numberOfCopiesSpinBox</cstring>
            </property>
           </widget>
          </item>
-         <item row="4" column="0">
-          <widget class="QLabel" name="rotationLabel">
+         <item row="2" column="0" colspan="2">
+          <widget class="QRadioButton" name="shiftCreatedItemsRadioButton">
            <property name="text">
-            <string>Rotation:</string>
+            <string>&amp;Shift Created Items By</string>
            </property>
-           <property name="wordWrap">
-            <bool>false</bool>
+           <property name="shortcut">
+            <string>Alt+S</string>
            </property>
           </widget>
          </item>
-         <item row="2" column="1">
-          <widget class="ScrSpinBox" name="horizShiftSpinBox">
+         <item row="0" column="1">
+          <widget class="QSpinBox" name="numberOfCopiesSpinBox">
            <property name="minimumSize">
             <size>
              <width>0</width>
              <height>23</height>
             </size>
            </property>
-          </widget>
-         </item>
-         <item row="3" column="0">
-          <widget class="QLabel" name="vertShiftLabel">
-           <property name="text">
-            <string>&amp;Vertical Shift:</string>
-           </property>
-           <property name="wordWrap">
-            <bool>false</bool>
+           <property name="minimum">
+            <number>1</number>
            </property>
-           <property name="buddy">
-            <cstring>vertShiftSpinBox</cstring>
+           <property name="maximum">
+            <number>999</number>
            </property>
           </widget>
          </item>
-         <item row="0" column="1">
-          <widget class="QSpinBox" name="numberOfCopiesSpinBox">
+         <item row="4" column="1">
+          <widget class="ScrSpinBox" name="vertShiftSpinBox">
            <property name="minimumSize">
             <size>
              <width>0</width>
              <height>23</height>
             </size>
            </property>
-           <property name="minimum">
-            <number>1</number>
-           </property>
-           <property name="maximum">
-            <number>999</number>
-           </property>
           </widget>
          </item>
-         <item row="4" column="1">
-          <widget class="ScrSpinBox" name="rotationSpinBox">
+         <item row="3" column="1">
+          <widget class="ScrSpinBox" name="horizShiftSpinBox">
            <property name="minimumSize">
             <size>
              <width>0</width>
@@ -141,85 +128,54 @@
            </property>
           </widget>
          </item>
-         <item row="0" column="0">
-          <widget class="QLabel" name="numberOfCopiesLabel">
+         <item row="4" column="0">
+          <widget class="QLabel" name="vertShiftLabel">
            <property name="text">
-            <string>&amp;Number of Copies:</string>
+            <string>&amp;Vertical Shift:</string>
            </property>
            <property name="wordWrap">
             <bool>false</bool>
            </property>
            <property name="buddy">
-            <cstring>numberOfCopiesSpinBox</cstring>
+            <cstring>vertShiftSpinBox</cstring>
+           </property>
+          </widget>
+         </item>
+         <item row="5" column="0">
+          <widget class="QLabel" name="rotationLabel">
+           <property name="text">
+            <string>Rotation:</string>
+           </property>
+           <property name="wordWrap">
+            <bool>false</bool>
            </property>
           </widget>
          </item>
          <item row="1" column="0" colspan="2">
-          <widget class="QGroupBox" name="copiesCreateButtonGroup">
-           <property name="enabled">
-            <bool>true</bool>
+          <widget class="QRadioButton" name="createGapRadioButton">
+           <property name="text">
+            <string>Create &amp;Gap Between Items Of</string>
            </property>
-           <property name="sizePolicy">
-            <sizepolicy hsizetype="Preferred" vsizetype="Fixed">
-             <horstretch>0</horstretch>
-             <verstretch>0</verstretch>
-            </sizepolicy>
+           <property name="shortcut">
+            <string>Alt+G</string>
            </property>
-           <property name="minimumSize">
-            <size>
-             <width>0</width>
-             <height>89</height>
-            </size>
+          </widget>
+         </item>
+         <item row="3" column="0">
+          <widget class="QLabel" name="horizShiftLabel">
+           <property name="text">
+            <string>&amp;Horizontal Shift:</string>
+           </property>
+           <property name="wordWrap">
+            <bool>false</bool>
+           </property>
+           <property name="buddy">
+            <cstring>horizShiftSpinBox</cstring>
            </property>
-           <property name="contextMenuPolicy">
-            <enum>Qt::DefaultContextMenu</enum>
-           </property>
-           <widget class="QWidget" name="layoutWidget">
-            <property name="geometry">
-             <rect>
-              <x>10</x>
-              <y>30</y>
-              <width>241</width>
-              <height>48</height>
-             </rect>
-            </property>
-            <layout class="QVBoxLayout" name="verticalLayout_3">
-             <property name="sizeConstraint">
-              <enum>QLayout::SetMinimumSize</enum>
-             </property>
-             <item>
-              <widget class="QRadioButton" name="createGapRadioButton">
-               <property name="text">
-                <string>Create &amp;Gap Between Items Of</string>
-               </property>
-               <property name="shortcut">
-                <string>Alt+G</string>
-               </property>
-              </widget>
-             </item>
-             <item>
-              <widget class="QRadioButton" name="shiftCreatedItemsRadioButton">
-               <property name="text">
-                <string>&amp;Shift Created Items By</string>
-               </property>
-               <property name="shortcut">
-                <string>Alt+S</string>
-               </property>
-              </widget>
-             </item>
-            </layout>
-           </widget>
           </widget>
          </item>
         </layout>
        </item>
-      </layout>
-     </widget>
-     <widget class="QWidget" name="tab2">
-      <attribute name="title">
-       <string>By &amp;Rows &amp;&amp; Columns</string>
-      </attribute>
-      <layout class="QVBoxLayout" name="verticalLayout_2">
        <item>
         <spacer name="verticalSpacer_2">
          <property name="orientation">
@@ -228,11 +184,18 @@
          <property name="sizeHint" stdset="0">
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>0</height>
           </size>
          </property>
         </spacer>
        </item>
+      </layout>
+     </widget>
+     <widget class="QWidget" name="tab2">
+      <attribute name="title">
+       <string>By &amp;Rows &amp;&amp; Columns</string>
+      </attribute>
+      <layout class="QVBoxLayout" name="verticalLayout_2">
        <item>
         <layout class="QGridLayout" name="gridLayout">
          <item row="1" column="0">
@@ -343,7 +306,7 @@
          <property name="sizeHint" stdset="0">
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>0</height>
           </size>
          </property>
         </spacer>
@@ -432,7 +395,7 @@
          <property name="sizeHint" stdset="0">
           <size>
            <width>20</width>
-           <height>40</height>
+           <height>0</height>
           </size>
          </property>
         </spacer>
@@ -503,8 +466,6 @@
  <tabstops>
   <tabstop>tabWidget</tabstop>
   <tabstop>numberOfCopiesSpinBox</tabstop>
-  <tabstop>createGapRadioButton</tabstop>
-  <tabstop>shiftCreatedItemsRadioButton</tabstop>
   <tabstop>horizShiftSpinBox</tabstop>
   <tabstop>vertShiftSpinBox</tabstop>
   <tabstop>rotationSpinBox</tabstop>
multiple_duplicate.diff (9,709 bytes)
multiple_duplicate.gif (53,359 bytes)
multiple_duplicate.gif (53,359 bytes)

jghali

2020-12-15 10:42

administrator   ~0048561

Applied, thanks!

Issue History

Date Modified Username Field Change
2020-12-15 08:16 bubu New Issue
2020-12-15 10:10 PeterBenedek Note Added: 0048559
2020-12-15 10:32 bubu File Added: multiple_duplicate.diff
2020-12-15 10:32 bubu File Added: multiple_duplicate.gif
2020-12-15 10:32 bubu Note Added: 0048560
2020-12-15 10:42 jghali Assigned To => jghali
2020-12-15 10:42 jghali Status new => resolved
2020-12-15 10:42 jghali Resolution open => fixed
2020-12-15 10:42 jghali Fixed in Version => 1.5.7.svn
2020-12-15 10:42 jghali Note Added: 0048561