View Issue Details

IDProjectCategoryView StatusLast Update
0016390ScribusUser Interfacepublic2020-12-18 01:09
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.5.7.svn 
Target VersionFixed in Version1.5.7.svn 
Summary0016390: Update layout for Manage Guides dialog
DescriptionI propose a several small improvement in the Manage Guides dialog:
- Decrease a little bit the default height of the dialog.
- Use default margins.
- Add a spacer in the 2nd tab. See the before-after screenshot.

Please, review the attached patch. Thanks.
TagsNo tags attached.
PatchYes

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2020-12-16 11:57

reporter  

manage_guides.diff (2,625 bytes)
diff --git a/scribus/ui/guidemanager.ui b/scribus/ui/guidemanager.ui
index 044d6fa12e5af7d8abbcf1a8be1b39921b953266..f0ed65f4dcaad7a3ab6c36e6e482f5f0d21c022e 100644
--- a/scribus/ui/guidemanager.ui
+++ b/scribus/ui/guidemanager.ui
@@ -9,28 +9,13 @@
     <x>0</x>
     <y>0</y>
     <width>432</width>
-    <height>389</height>
+    <height>368</height>
    </rect>
   </property>
   <property name="windowTitle">
    <string>Guide Manager</string>
   </property>
   <layout class="QGridLayout">
-   <property name="leftMargin">
-    <number>11</number>
-   </property>
-   <property name="topMargin">
-    <number>11</number>
-   </property>
-   <property name="rightMargin">
-    <number>11</number>
-   </property>
-   <property name="bottomMargin">
-    <number>11</number>
-   </property>
-   <property name="spacing">
-    <number>6</number>
-   </property>
    <item row="0" column="0">
     <widget class="QTabWidget" name="tabWidget">
      <property name="currentIndex">
@@ -168,6 +153,19 @@
        <string>&amp;Column/Row</string>
       </attribute>
       <layout class="QGridLayout">
+       <item row="2" column="0" colspan="2">
+        <widget class="QPushButton" name="applyToAllAutoButton">
+         <property name="toolTip">
+          <string>Apply the shown guides to all pages in the document</string>
+         </property>
+         <property name="text">
+          <string>Appl&amp;y to All Pages</string>
+         </property>
+         <property name="shortcut">
+          <string>Alt+Y</string>
+         </property>
+        </widget>
+       </item>
        <item row="0" column="0">
         <widget class="QGroupBox" name="horizontalAutoGroup">
          <property name="title">
@@ -378,18 +376,18 @@
          </layout>
         </widget>
        </item>
-       <item row="1" column="0" colspan="2">
-        <widget class="QPushButton" name="applyToAllAutoButton">
-         <property name="toolTip">
-          <string>Apply the shown guides to all pages in the document</string>
-         </property>
-         <property name="text">
-          <string>Appl&amp;y to All Pages</string>
+       <item row="1" column="0">
+        <spacer name="verticalSpacer">
+         <property name="orientation">
+          <enum>Qt::Vertical</enum>
          </property>
-         <property name="shortcut">
-          <string>Alt+Y</string>
+         <property name="sizeHint" stdset="0">
+          <size>
+           <width>20</width>
+           <height>0</height>
+          </size>
          </property>
-        </widget>
+        </spacer>
        </item>
       </layout>
      </widget>
manage_guides.diff (2,625 bytes)
manage_guides.gif (40,504 bytes)
manage_guides.gif (40,504 bytes)

jghali

2020-12-18 01:09

administrator   ~0048587

Applied, thanks!

Issue History

Date Modified Username Field Change
2020-12-16 11:57 bubu New Issue
2020-12-16 11:57 bubu File Added: manage_guides.diff
2020-12-16 11:57 bubu File Added: manage_guides.gif
2020-12-17 08:13 PeterBenedek Relationship added child of 0013906
2020-12-18 01:09 jghali Assigned To => jghali
2020-12-18 01:09 jghali Status new => resolved
2020-12-18 01:09 jghali Resolution open => fixed
2020-12-18 01:09 jghali Fixed in Version => 1.5.7.svn
2020-12-18 01:09 jghali Note Added: 0048587