View Issue Details

IDProjectCategoryView StatusLast Update
0016512ScribusUser Interfacepublic2021-03-21 14:56
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016512: Shrink eyedropper dialog for new color name
DescriptionI propose this little fix before string freeze.

See the attached screenshot. Please review it. Thanks.
TagsNo tags attached.
Attached Files
0001-Shrink-eyedropper-dialog-for-new-color-name.patch (1,676 bytes)   
From 4d951431bdbf96d69a96d44bc205a64c1c84fcca Mon Sep 17 00:00:00 2001
Message-Id: <4d951431bdbf96d69a96d44bc205a64c1c84fcca.1615118667.git.bubu@ujevangelizacio.hu>
From: =?UTF-8?q?Gyuris=20Gell=C3=A9rt?= <bubu@ujevangelizacio.hu>
Date: Sun, 7 Mar 2021 13:04:17 +0100
Subject: [PATCH] Shrink eyedropper dialog for new color name

---
 scribus/canvasmode_eyedropper.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scribus/canvasmode_eyedropper.cpp b/scribus/canvasmode_eyedropper.cpp
index 4cb2464d2..f4654e012 100644
--- a/scribus/canvasmode_eyedropper.cpp
+++ b/scribus/canvasmode_eyedropper.cpp
@@ -178,14 +178,14 @@ void CanvasMode_EyeDropper::mouseReleaseEvent(QMouseEvent *m)
 	{
 		bool ok;
 		bool nameFound = false;
-		QString questionString = "<qt>" + tr("The selected color does not exist in the document's color set. Please enter a name for this new color.") + "</qt>";
+		QString questionString = "<qt>" + tr("The selected color does not exist in the document's color set.") + "<br>" + ("Please enter a name for this new color.") + "</qt>";
 		do
 		{
 			colorName = QInputDialog::getText(m_ScMW, tr("Color Not Found"), questionString, QLineEdit::Normal, tr("RGB %1").arg(selectedColor.name()), &ok);
 			if (ok)
 			{
 				if (m_doc->PageColors.contains(colorName))
-					questionString = "<qt>" + tr("The name you have selected already exists. Please enter a different name for this new color.") + "</qt>";
+					questionString = "<qt>" + tr("The name you have selected already exists.") + "<br>" + (" Please enter a different name for this new color.") + "</qt>";
 				else
 					nameFound = true;
 			}
-- 
2.27.0

eyedropper.gif (34,464 bytes)   
eyedropper.gif (34,464 bytes)   
PatchNo

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

jghali

2021-03-07 21:44

administrator   ~0048921

Applied, thanks!

FirasH

2021-03-21 14:56

reporter   ~0048983

Thanks!
Fixed in 1.5.7.svn (24555)

Issue History

Date Modified Username Field Change
2021-03-07 12:07 bubu New Issue
2021-03-07 12:07 bubu File Added: 0001-Shrink-eyedropper-dialog-for-new-color-name.patch
2021-03-07 12:07 bubu File Added: eyedropper.gif
2021-03-07 13:48 PeterBenedek Relationship added child of 0013906
2021-03-07 21:44 jghali Assigned To => jghali
2021-03-07 21:44 jghali Status new => resolved
2021-03-07 21:44 jghali Resolution open => fixed
2021-03-07 21:44 jghali Fixed in Version => 1.5.7.svn
2021-03-07 21:44 jghali Note Added: 0048921
2021-03-21 14:56 FirasH Status resolved => closed
2021-03-21 14:56 FirasH Note Added: 0048983