View Issue Details

IDProjectCategoryView StatusLast Update
0016668ScribusOS-MacOSXpublic2021-11-09 21:39
Reporterluzpaz Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.8.svn 
Fixed in Version1.5.8.svn 
Summary0016668: LGTM: fix syntax error missing closing parenthesis in OSX-package/linktools/mkappbundle.py
Descriptionref: https://lgtm.com/projects/g/scribusproject/scribus/alerts/?mode=tree&ruleFocus=4860085
TagsNo tags attached.
PatchYes

Activities

luzpaz

2021-10-27 18:58

reporter  

scribus-fix-osx-linktools.patch (906 bytes)   
From d433422e84afe5b677df715703e47dd60637f423 Mon Sep 17 00:00:00 2001
From: luz paz <luzpaz@users.noreply.github.com>
Date: Sun, 24 Oct 2021 14:43:11 -0400
Subject: [PATCH] LGTM: fix syntax error missing closing parenthesis

ref: https://lgtm.com/projects/g/scribusproject/scribus/alerts/?mode=tree&ruleFocus=4860085
---
 OSX-package/linktools/mkappbundle.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/OSX-package/linktools/mkappbundle.py b/OSX-package/linktools/mkappbundle.py
index 7b51eda715..dccdf17ccf 100755
--- a/OSX-package/linktools/mkappbundle.py
+++ b/OSX-package/linktools/mkappbundle.py
@@ -83,5 +83,5 @@ if not os.path.exists(binPath):
 if binfile != None:
 	shutil.copy(binfile, os.path.join(binPath, appName))
 			
-shutil.copy(infofile, os.path.join(bundle, "Contents/Info.plist")
+shutil.copy(infofile, os.path.join(bundle, "Contents/Info.plist"))
 
-- 
2.33.0

cbradney

2021-10-27 19:32

administrator   ~0049314

I have committed this change however I would not have a clue if this file even works. It is not what I use to make our OSX bundles. We can probably delete it in the future.

Issue History

Date Modified Username Field Change
2021-10-27 18:58 luzpaz New Issue
2021-10-27 18:58 luzpaz File Added: scribus-fix-osx-linktools.patch
2021-10-27 19:32 cbradney Note Added: 0049314
2021-10-27 19:32 cbradney Assigned To => cbradney
2021-10-27 19:32 cbradney Status new => resolved
2021-10-27 19:32 cbradney Resolution open => fixed
2021-10-27 19:32 cbradney Fixed in Version => 1.5.8.svn
2021-10-28 06:53 jghali Summary [PATCH] LGTM: fix syntax error missing closing parenthesis in OSX-package/linktools/mkappbundle.py => LGTM: fix syntax error missing closing parenthesis in OSX-package/linktools/mkappbundle.py
2021-10-28 20:06 jghali Priority high => normal
2021-11-09 21:39 cbradney Status resolved => closed