View Issue Details

IDProjectCategoryView StatusLast Update
0016878ScribusUser Interfacepublic2023-05-29 18:56
Reporterpmjdebruijn Assigned Tojghali  
Status closedResolutionfixed 
Product Version1.5.9.svn 
Fixed in Version1.5.9.svn 
Summary0016878: File selection dialog box always reverts to small size (reopen)
Description0016619 did not resolve the issue where many of the dialog boxes are unusable by default, and require resizing every time they are opened.

git-svn-id: svn:// 11d20701-8431-0410-a711-e3c959e3b870 apparently wasn't a full fix.

The patch refers to

m_fileDialogPrefs = PrefsManager::instance().prefsFile->getContext("customfdialog", false);
int newWidth = qMax(0, qMin(this->width() + fdWidth - fileDialog->width(), scr.width()));
int newHeight = qMax(0, qMin(this->height() + fdHeight - fileDialog->height(), scr.height()));

But it seems those prefs aren't being saved anywhere, and regardless of that, there should possibly be a hardcoded minimum? Maybe 720x600 (same as the New Document dialog), or something along those lines.

I'd be happy to test any patch.
TagsNo tags attached.



2023-01-07 15:33

reporter   ~0049858

It seems the dialog size is being saved, but there's something weird going on with the open image dialog, I'll have to dig a little further...


2023-01-15 12:57

reporter   ~0049930

I think I found why the the file dialog is unusable by default, no clue why that line ever made it into there in the first place, but I'm sure there will be some historical reason, for some long gone Qt version or something.
customfdialog.patch (538 bytes)   
Index: a/scribus/ui/customfdialog.cpp
--- a/scribus/ui/customfdialog.cpp	(revision 25257)
+++ a/scribus/ui/customfdialog.cpp	(working copy)
@@ -488,7 +488,6 @@
 	connect(fileDialog, SIGNAL(filesSelected(const QStringList &)), this, SLOT(accept()));
 	connect(fileDialog, SIGNAL(accepted()), this, SLOT(accept()));
 	connect(fileDialog, SIGNAL(rejected()), this, SLOT(reject()));
-	resize(minimumSizeHint());
 void CustomFDialog::closeEvent(QCloseEvent *closeEvent)
customfdialog.patch (538 bytes)   


2023-01-17 18:46

reporter   ~0049943

This is how the open dialog looks after the suggested patch:
scribus_open_dailog.png (69,030 bytes)   
scribus_open_dailog.png (69,030 bytes)   


2023-01-22 15:07

administrator   ~0049964

Thanks, I've applied your patch. Is there anything more to be done in this issue?


2023-01-24 16:43

reporter   ~0049969

No probably not, you can close this now. Thanks!


2023-01-24 20:14

administrator   ~0049973

Ok, closing then.

Issue History

Date Modified Username Field Change
2023-01-02 16:21 pmjdebruijn New Issue
2023-01-07 15:33 pmjdebruijn Note Added: 0049858
2023-01-15 12:57 pmjdebruijn Note Added: 0049930
2023-01-15 12:57 pmjdebruijn File Added: customfdialog.patch
2023-01-17 18:46 pmjdebruijn Note Added: 0049943
2023-01-17 18:46 pmjdebruijn File Added: scribus_open_dailog.png
2023-01-22 15:07 jghali Note Added: 0049964
2023-01-24 16:43 pmjdebruijn Note Added: 0049969
2023-01-24 20:14 jghali Assigned To => jghali
2023-01-24 20:14 jghali Status new => resolved
2023-01-24 20:14 jghali Resolution open => fixed
2023-01-24 20:14 jghali Fixed in Version => 1.5.9.svn
2023-01-24 20:14 jghali Note Added: 0049973
2023-05-29 18:56 cbradney Status resolved => closed