View Issue Details

IDProjectCategoryView StatusLast Update
0016899ScribusBuild Systempublic2023-05-29 18:56
Reporterpmjdebruijn Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.6.0.svn 
Fixed in Version1.6.0.svn 
Summary0016899: No Document Icon is installed on Linux
DescriptionScribus documents on Linux, get a generic unknown file icon on Linux, which isn't great.

I've attached a basic design, it's based on: https://github.com/elementary/icons/blob/master/mimes/64/text-x-preview.svg

The icon should get installed to: /usr/share/icons/hicolor/64x64/mimetypes/application-vnd.scribus.png
TagsNo tags attached.
PatchNo

Activities

pmjdebruijn

2023-01-16 17:03

reporter  

application-vnd.scribus.png (2,739 bytes)   
application-vnd.scribus.png (2,739 bytes)   

jghali

2023-01-19 23:03

administrator   ~0049954

Thanks, I committed your icon to 1.5.x branch and trunk. May I ask you to provide us the svg you used to generate this icon? I'd like to use it to generate document icons for the other resolutions.

pmjdebruijn

2023-01-20 17:53

reporter   ~0049957

Sure, here it is, keep in mind this is really optimized for 64px, so it probably won't look particularly good for the other resolutions.

jghali

2023-01-21 00:43

administrator   ~0049961

Thank you very much. I've now added 16x16, 32x32, 128x128 and 256x256 document icons.

mjg

2023-01-21 12:41

reporter   ~0049962

While I agree that having a document icon is nice, the implementation breaks when multiple versions of scribus are installed in parallel. Parallel installs are important to some of us because of the need to work with legacy files. Short of containers and virtualisation, parallel installs are the easiest option, and so far scribus supports this explicitely via `WANT_VERSIONING=YES`. In particular, the program icon is installed via
```
                INSTALL(FILES
                        icon_${res}.png
                        RENAME scribus${TAG_VERSION}.png
                        DESTINATION ${SYSICONDIR}/${res}/apps/
                )
```
leading to non-conflicting installs.

The new document icon is installed unversioned. This leads to file conflicts for multiple installs. I'm not sure what the best way forward is - in fact, onw could even associate different mime subtypes based on document versions here. Maybe the easiest route is to use
```
        FOREACH(res 16x16 32x32 64x64 128x128 256x256)
                INSTALL(FILES
                        application-vnd.scribus_${res}.png
                        RENAME application-vnd.scribus${TAG_VERSION}.png
                        DESTINATION ${SYSICONDIR}/${res}/mimetypes/
                )
        ENDFOREACH(res)
```
which is a no-op change for normal (unversioned) installs. I guess this requires a corresponding change to the mime xml file. (I'll think about a change there.)

mjg

2023-01-21 18:23

reporter   ~0049963

As an update, I just noticed that at least on my distro (Fedora), identical files in indenctical locations (with identical attributes) do not make packages conflict, so all is fine here. Sorry for the noise.

Issue History

Date Modified Username Field Change
2023-01-16 17:03 pmjdebruijn New Issue
2023-01-16 17:03 pmjdebruijn File Added: application-vnd.scribus.png
2023-01-19 23:03 jghali Note Added: 0049954
2023-01-20 17:53 pmjdebruijn Note Added: 0049957
2023-01-20 17:53 pmjdebruijn File Added: scribus-document-elementary-clean.svg
2023-01-21 00:43 jghali Assigned To => jghali
2023-01-21 00:43 jghali Status new => resolved
2023-01-21 00:43 jghali Resolution open => fixed
2023-01-21 00:43 jghali Fixed in Version => 1.6.0.svn
2023-01-21 00:43 jghali Note Added: 0049961
2023-01-21 12:41 mjg Note Added: 0049962
2023-01-21 18:23 mjg Note Added: 0049963
2023-05-29 18:56 cbradney Status resolved => closed