View Issue Details

IDProjectCategoryView StatusLast Update
0016906ScribusGeneralpublic2023-05-29 18:56
Reporterapp4soft Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.6.0.svn 
Fixed in Version1.6.0.svn 
Summary0016906: Import of Adobe Color Book palettes doesn't work
DescriptionAdd support for import Adobe Color Book (.acb) as a palette into Scribus via "Edit > Colors and Fills > Import".

Krita app has already support for it: https://github.com/KDE/krita/commit/6c7ed0521

ACB-file sample (attached) provided by Krita devs: https://github.com/KDE/krita/tree/master/libs/pigment/tests/data
Additional InformationAdobe Color Book File Format Specification (.acb):

- https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/#50577411_pgfId-1066780
- https://magnetiq.ca/pages/acb-spec/
- https://github.com/atesgoral/acb
- https://github.com/jacobbubu/acb
Tagscolors, import, palette
PatchNo

Activities

app4soft

2023-02-03 01:41

reporter  

photoshop.acb (686 bytes)

jghali

2023-02-03 19:17

administrator   ~0049983

>> ACB-file sample (attached) provided by Krita devs: https://github.com/KDE/krita/tree/master/libs/pigment/tests/data

That acb test file is totally broken. The color names contains additional null termination characters which should not be there.

jghali

2023-02-03 19:35

administrator   ~0049984

Moreover the string data lengths in that file are inconsistent with the presence of these additional null termination characters.

jghali

2023-02-03 19:45

administrator   ~0049985

Last edited: 2023-02-03 21:54

Indesign CS2 and Photoshop CS2 refuse to read that file, so that definitely discards it as a valid test file.
The files available at https://github.com/jacobbubu/acb are valid acb files.

jghali

2023-02-03 21:58

administrator   ~0049986

In fact 1.5.x theoretically already support import of .acb files, but to say the least, import code was a bit broken. This is now fixed in 1.5.9.svn and trunk. I've also made the code more robust against broken files such as the photoshop.acb file mentionned above.

app4soft

2023-02-03 23:46

reporter   ~0049987

> This is now fixed in 1.5.9.svn and trunk

Thanks!

May I ask you about where I can get AppImage binary for latest 1.5.9.svn?

jghali

2023-02-04 12:42

administrator   ~0049988

Well unfortunately due to recent changes on GitLab side, there is currently no automatic generation of AppImages for svn code. In order to get svn code, you will have to compile Scribus yourself.

ale

2023-02-04 13:38

manager   ~0049989

euh...

https://impagina.org/download#nightly_scribus_1.5.x_for_linux

i'm still too lazy to setup a workflow for 1.7, but for 1.5.x it mostly does work...

jghali

2023-02-04 23:11

administrator   ~0049990

Ooops, I was tricked by the lack of CI menu in main scribus project.
Btw I will move soon my AppImage build environment from Ubuntu 18.04 to Ubuntu 20.04 as 18.04 is going out of support soon (in April).

app4soft

2023-02-05 05:33

reporter   ~0049991

> euh... https://impagina.org/download#nightly_scribus_1.5.x_for_linux

Last time I looked at Impagina page there was a link to `scribus/scribus` GitLab CI, which actually does not exists.

Now I found `scribus/scribus16` GitLab CI and just grabbed AppImage - ACB import works fine!

Thanks!

> i'm still too lazy to setup a workflow for 1.7

I still hope to see 1.7 AppImages anytime soon)

ale

2023-02-05 09:26

manager   ~0049994

for 1.7, what is missing is a docker image with qt6 (and maybe other updated dependencies).

i don't have a use for an appimage (and i don't know how many people would be interested in having a daily appimage for 1.7) and i'm not really proficient in creating docker based workflows...
... so i welcome contributions...

the discussion can be continued here: https://gitlab.com/scribus/scribus/-/issues/17

Issue History

Date Modified Username Field Change
2023-02-03 01:41 app4soft New Issue
2023-02-03 01:41 app4soft Tag Attached: colors
2023-02-03 01:41 app4soft Tag Attached: import
2023-02-03 01:41 app4soft Tag Attached: palette
2023-02-03 01:41 app4soft File Added: photoshop.acb
2023-02-03 19:17 jghali Note Added: 0049983
2023-02-03 19:35 jghali Note Added: 0049984
2023-02-03 19:45 jghali Note Added: 0049985
2023-02-03 21:03 jghali Note Edited: 0049985
2023-02-03 21:54 jghali Note Edited: 0049985
2023-02-03 21:55 jghali Summary Add support for import Adobe Color Book palettes => Import of Adobe Color Book palettes dopesn't work
2023-02-03 21:55 jghali Summary Import of Adobe Color Book palettes dopesn't work => Import of Adobe Color Book palettes doesn't work
2023-02-03 21:56 jghali Product Version => 1.6.0.svn
2023-02-03 21:58 jghali Note Added: 0049986
2023-02-03 21:58 jghali Assigned To => jghali
2023-02-03 21:58 jghali Status new => resolved
2023-02-03 21:58 jghali Resolution open => fixed
2023-02-03 21:58 jghali Fixed in Version => 1.6.0.svn
2023-02-03 23:46 app4soft Note Added: 0049987
2023-02-04 12:42 jghali Note Added: 0049988
2023-02-04 13:38 ale Note Added: 0049989
2023-02-04 23:11 jghali Note Added: 0049990
2023-02-05 05:33 app4soft Note Added: 0049991
2023-02-05 09:26 ale Note Added: 0049994
2023-05-29 18:56 cbradney Status resolved => closed