|
|
p.s. i've tested pdflatex with this sample document in the terminal and it did work... \documentclass{article} \begin{document} Hello World! \end{document} |
|
|
using the modern syntax for connects helps finding the error: connect(latex, &QProcess::errorOccurred, this, &PageItem_LatexFrame::latexError); while connect(latex, &QProcess::error, this, &PageItem_LatexFrame::latexError); does not compile, connecting errorOccurred gives me an error message and tells me to check the (i guess supposed empty) path. latex-frame-error-check-path.png (15,205 bytes) |
|
|
using the full path to pdflatex in the settings does not help either. |
|
|
also, in latexError() there is a "firstWarning" condition that makes that dialog only show for the first a latex frame is inserted (updated...) since scribus started. it should probably pop up each time a new frame is created or at least after having modified the renderer settings. |
|
|
so, while scribus fails to launch the command "pdflatex --interaction nonstopmode \"/tmp/scribus_temp_render_hVVUlp\"" . doing "cat /tmp/scribus_temp_render_hVVUlp" while the error dialog is still open, shows \documentclass[11pt]{extarticle} \usepackage[utf8]{inputenc} \usepackage[paperwidth=134.4 pt, paperheight=124.355 pt, left=0cm,top=0cm,right=0cm,bottom=0cm,nohead,nofoot]{geometry} \title{Scribus-Latex-File} \usepackage{amsmath} \author{Scribus} \pagestyle{empty} \setlength{\textwidth}{134.4 pt} \begin{document} \section*{Manual} Your \LaTeX-frames setup is working when you can read this text!\\ Placing formulas is very easy:\\ Right click $\Rightarrow$ Edit Source\\ And replace this text with your own. Here is an example: \begin{verbatim} \[J = \int r^2 \mathrm{d}m\] \end{verbatim} becomes \[J = \int r^2 \mathrm{d}m\] \end{document} the file is there. running the exact same command as above (qDebug() << fullCommand) in the terminal, while the error dialog is still open, does work. here is my last try: full_command = config->executable(); QStringList arguments {QDir::toNativeSeparators(tempFileBase)}; latex->start(full_command, arguments); also fails. there is something "interesting", though: when running from the terminal, the pdf file gets (obviously) created in the current directory and not in /tmp... still QStringList arguments {"-output-directory="+QDir::tempPath(), QDir::toNativeSeparators(tempFileBase)}; does not to seem to help either. something is wrong somewhere... but i don't seem to be able to find out what... |
|
|
I have also "pdflatex --interaction nonstopmode" but no issue here... |
|
|
At least we won't take any risk by replacing the deprecated error() signal by errorOccurred(). I just checked: errorOccurred() was already available in Qt 5.14. |
|
|
replacing latex->start(full_command); by latex->start("pdflatex", QStringList() << "--interaction nonstopmode" << tempFileBase); does work... yeah. i can replicate this in a dummy application that only triggers the QProcess so i fear that with Qt6 it's not possible anymore to put all the command line arguments in the command itself. |
|
|
I have been messing around with the code, and after removing the parameter "--interaction nonstopmode" from the arguments in the preferences, I got it to work. I fear you need to fully separate out the arguments from the command. |
|
|
>> i can replicate this in a dummy application that only triggers the QProcess so i fear that with Qt6 it's not possible anymore to put all the command line arguments in the command itself. Well, on Windows i currently do not have this problem with Qt 6.2.4. It might also be a Qt regression. What Qt version are you currently using? I expect to upgrade to Qt 6.5.0 this week-end so I'll test what happens with Qt 6.5 soon. |
|
|
it should be qt 6.4.2. |
|
|
I have the same problem on linux. In about Qt is shown as 6.2.4. Might be a difference in how linux handles these commands. P.S.: Can't the following code be removed (just before latex->start(...)) full_command.replace("%dpi", QString::number(realDpi())); if (full_command.contains("%file")) full_command.replace("%file", QString("\"%1\"").arg(QDir::toNativeSeparators(tempFileBase))); else full_command = full_command + QString(" \"%1\"").arg(QDir::toNativeSeparators(tempFileBase)); full_command.replace("%dir", QString("\"%1\"").arg(QDir::toNativeSeparators(QDir::tempPath()))); latex->setWorkingDirectory(QDir::tempPath()); double lDpi = realDpi()/72.0; full_command.replace("$scribus_height_px$", QString::number(qRound(m_height*lDpi))); full_command.replace("$scribus_width_px$", QString::number(qRound(m_width*lDpi))); QMapIterator<QString, QString> i(editorProperties); while (i.hasNext()) { i.next(); full_command.replace("$scribus_"+i.key()+"$", i.value()); } All the variables are not part of the command-string ... |
|
|
Try this patch meanwhile. 16924_render_frame_not_working.patch (2,266 bytes) |
|
|
Seems to work flawlessly. |
|
|
i did not try it, but the above code will probably fail if somebody uses the full path to pdflatex and that path happens to contain spaces (which is very unlikely on a linux default install but could easily happen on windows or ios where people need to "manually" install latex). |
|
|
In this case, the config should be split into two parts. One for the path of the executable (or the name) and one for the args, as you can't reliably split them in code. It does work as a hotfix (but so does removing the arg "--interaction nonstopmode" for pdflatex; sadly it seems that it's not possible for every external program to remove the arguments.) |
|
|
>> i did not try it, but the above code will probably fail if somebody uses the full path to pdflatex It should not because QProcess automatically quotes arguments when necessary. The full path to my latex installation contains spaces as well as the path of my temporary directory. |
|
|
Did you enter the full path to pdflatex first, or is pdflatex found by the PATH variable? Because in theory, entering a full path, should result in the following: program: "C:\Program" arguments: "Files\...\pdflatex", "--interaction", "nonstopmode" and "$TMPPATH" the arguments will work well. The problem is the full path to the program, if you need to give it. May be an edge case though. |
|
|
if i get it correctly, you are splitting by spaces the full_command from the settings QStringList args = full_command.split(' ', Qt::SkipEmptyParts); take the first item as the command QString program = args.at(0); args.removeFirst(); and use the rest as the args. if there is a space in the path, you will get the first part of the path as the program and the rest of the path with the command in the first argument... if it this is what happens, i would prefer utnik suggestion and have two fields in the settings: one for the program and one for the arguments. (for the old values currently in the settings, everything would still be in the full_program... or we could detect if the command is still at its default and if it's the case use the new default values) |
|
|
Ah! I thought you were talking about QProcess ability to run program containing spaces in its path. I was conscious of the issue you are talking about and that's why I did not commit that initial patch. I just committed another one where I use new QProcess::splitCommand() introduced in Qt 5.15 to parse command line string. This function supports parsing arguments containing spaces when these arguments are enclosed in quotes. I also found another issue which could trigger a render frame configuration error message. The issue was caused by a similar split by using space as delimiter. I fixed this separate issue in 1.5.9.svn and trunk. In the case of 1.5.9.svn I copied QProcess::splitCommand() code in our code base as Qt 5.14 is still the minimum supported Qt version in this branch. |
|
|
ok, thanks for fixing this! |
- Anonymous
