View Issue Details

IDProjectCategoryView StatusLast Update
0016970ScribusUser Interfacepublic2023-09-11 20:34
Reporterryandesign Assigned Tojghali  
PrioritylowSeveritytextReproducibilityalways
Status closedResolutionfixed 
Product Version1.7.0.svn 
Fixed in Version1.6.0.svn 
Summary0016970: About box: table tags not closed
DescriptionThe second opening HTML table tag in each of the About box tabs should be a closing table tag. See patch.
Additional InformationLooks like this problem was introduced way back in r12531 15 years ago.
TagsNo tags attached.
PatchYes

Activities

ryandesign

2023-07-01 02:05

reporter  

table.diff (693 bytes)   
Index: scribus/ui/about.cpp
===================================================================
--- scribus/ui/about.cpp	(revision 25528)
+++ scribus/ui/about.cpp	(working copy)
@@ -397,7 +397,7 @@
 				}
 			} // else is empty line
 		} // while ! atEnd
-		result += "<table>";
+		result += "</table>";
 	} // if file found
 	else
 	{
@@ -553,7 +553,7 @@
 			}
 			result += "<tr><td></td><td></td></tr><tr><td></td><td></td></tr>";
 		}
-		result += "<table>";
+		result += "</table>";
 	} // if file found
 	else
 	{
@@ -620,7 +620,7 @@
 			  isTitle = true;
 			} // else is empty line
 		} // while ! atEnd
-		result += "<table>";
+		result += "</table>";
 	} // if file found
 	else
 	{
table.diff (693 bytes)   

jghali

2023-07-01 14:03

administrator   ~0050254

Patch applied to both 1.5.x branch and trunk. Thanks!

Issue History

Date Modified Username Field Change
2023-07-01 02:05 ryandesign New Issue
2023-07-01 02:05 ryandesign File Added: table.diff
2023-07-01 14:03 jghali Assigned To => jghali
2023-07-01 14:03 jghali Status new => resolved
2023-07-01 14:03 jghali Resolution open => fixed
2023-07-01 14:03 jghali Fixed in Version => 1.6.0.svn
2023-07-01 14:03 jghali Note Added: 0050254
2023-09-11 20:34 cbradney Status resolved => closed