View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0016970 | Scribus | User Interface | public | 2023-07-01 02:05 | 2023-09-11 20:34 |
Reporter | ryandesign | Assigned To | jghali | ||
Priority | low | Severity | text | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.7.0.svn | ||||
Fixed in Version | 1.6.0.svn | ||||
Summary | 0016970: About box: table tags not closed | ||||
Description | The second opening HTML table tag in each of the About box tabs should be a closing table tag. See patch. | ||||
Additional Information | Looks like this problem was introduced way back in r12531 15 years ago. | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
|
table.diff (693 bytes)
Index: scribus/ui/about.cpp =================================================================== --- scribus/ui/about.cpp (revision 25528) +++ scribus/ui/about.cpp (working copy) @@ -397,7 +397,7 @@ } } // else is empty line } // while ! atEnd - result += "<table>"; + result += "</table>"; } // if file found else { @@ -553,7 +553,7 @@ } result += "<tr><td></td><td></td></tr><tr><td></td><td></td></tr>"; } - result += "<table>"; + result += "</table>"; } // if file found else { @@ -620,7 +620,7 @@ isTitle = true; } // else is empty line } // while ! atEnd - result += "<table>"; + result += "</table>"; } // if file found else { |
|
Patch applied to both 1.5.x branch and trunk. Thanks! |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-07-01 02:05 | ryandesign | New Issue | |
2023-07-01 02:05 | ryandesign | File Added: table.diff | |
2023-07-01 14:03 | jghali | Assigned To | => jghali |
2023-07-01 14:03 | jghali | Status | new => resolved |
2023-07-01 14:03 | jghali | Resolution | open => fixed |
2023-07-01 14:03 | jghali | Fixed in Version | => 1.6.0.svn |
2023-07-01 14:03 | jghali | Note Added: 0050254 | |
2023-09-11 20:34 | cbradney | Status | resolved => closed |