View Issue Details

IDProjectCategoryView StatusLast Update
0016978ScribusBuild Systempublic2023-09-11 20:34
Reporterryandesign Assigned Tocbradney  
PrioritylowSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.8 
Fixed in Version1.4.9.svn 
Summary0016978: Build failure due to faulty constructor in bundled lib2geom
DescriptionThe fix that was added to master in r24687 to fix 0016605 is also needed in the Version14x branch to fix the build with some compilers such as clang 11 where the error is:

scribus/plugins/tools/2geomtools/lib2geom/path.h:260:11: error: no viable overloaded '='
    inner = Bezier(x, y);
    ~~~~~ ^ ~~~~~~~~~~~~
Additional InformationThis was reported to MacPorts here: https://trac.macports.org/ticket/66704
TagsNo tags attached.
PatchYes

Relationships

duplicate of 0016605 closedjghali Compilation Error in lib2geom/path.h 

Activities

ryandesign

2023-07-08 00:50

reporter  

lib2geom.patch (777 bytes)   
--- scribus/plugins/tools/2geomtools/lib2geom/path.h.orig
+++ scribus/plugins/tools/2geomtools/lib2geom/path.h
@@ -251,14 +251,15 @@ class BezierCurve : public Curve {
 
   D2<SBasis> toSBasis() const {return inner.toSBasis(); }
 
-protected:
-  BezierCurve(Point c[]) {
-    Coord x[order+1], y[order+1];
-    for(unsigned i = 0; i <= order; i++) {
-        x[i] = c[i][X]; y[i] = c[i][Y];
-    }
-    inner = Bezier(x, y);
-  }
+// #16605: does not seem used at triggers build error with clang 12.0.1
+//protected:
+//  BezierCurve(Point c[]) {
+//    Coord x[order+1], y[order+1];
+//    for(unsigned i = 0; i <= order; i++) {
+//        x[i] = c[i][X]; y[i] = c[i][Y];
+//    }
+//    inner = Bezier(x, y);
+//  }
 };
 
 // BezierCurve<0> is meaningless; specialize it out
lib2geom.patch (777 bytes)   

cbradney

2023-07-08 13:25

administrator   ~0050269

Fixed in r25544

Note, 1.4.8 will be deprecated this year once we release 1.6.0. I understand you're keeping 1.4.8 building though so thats cool.

Issue History

Date Modified Username Field Change
2023-07-08 00:50 ryandesign New Issue
2023-07-08 00:50 ryandesign File Added: lib2geom.patch
2023-07-08 13:25 cbradney Assigned To => cbradney
2023-07-08 13:25 cbradney Status new => resolved
2023-07-08 13:25 cbradney Resolution open => fixed
2023-07-08 13:25 cbradney Fixed in Version => 1.4.9.svn
2023-07-08 13:25 cbradney Note Added: 0050269
2023-07-08 13:25 cbradney Relationship added duplicate of 0016605
2023-09-11 20:34 cbradney Status resolved => closed