View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017005 | Scribus | Integration | public | 2023-08-15 17:42 | 2023-09-11 20:34 |
Reporter | ale | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 1.5.9.svn | ||||
Fixed in Version | 1.5.9.svn | ||||
Summary | 0017005: CI fails because of podofo | ||||
Description | the CI on gitlab has been failing for the two latest builds: https://gitlab.com/scribus/scribus16/-/jobs/4875886284 the first error is: pdf_analyzer.cpp:218:21: error: 'class PoDoFo::PdfDictionary' has no member named 'FindKey'; did you mean 'AddKey'? resources = par->FindKey("Resources"); the docker file is: https://gitlab.com/scribus/scribus-ci-docker/-/blob/master/Dockerfile?ref_type=heads any clue if i need to change something or if it the podofo version detection that is failing? | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
1) You are still using Ubuntu 18.04 in your docker file. Ubuntu 18.04 is now out of support, you should move to 20.04. 2) Take the opportunity to move to Qt 5.15.4 : apt-add-repository ppa:beineri/opt-qt-5.15.4-focal |
|
3) Do not forget to update kitware ppa too: apt-add-repository 'deb https://apt.kitware.com/ubuntu/ focal main' -y |
|
It seems I will have to make bigger #ifdefs to separate podofo 0.9.x and podofo 0.10.x code : Ubuntu 20.04 only has podofo 0.9.6 and the FindKey() function has been introduced in podofo 0.9.7, which is available in Ubuntu 22.04. |
|
the reason for keeping ubuntu 18.04 as long as possible, is that it enables the appimage run on more (older) systems. i will have to switch for scribus 1.7svn, but for 1.6 it would be nice to keep it as is, if all the dependencies are met. on the other side, i've now updated the docker image to use ppa:beineri/opt-qt-5.15.2-bionic |
|
I restored the compatibility with podofo <= 0.9.6 in 1.5.x branch and trunk. I might drop 0.9.x compatibility in trunk when Ubuntu 24.04 will be released. >> the reason for keeping ubuntu 18.04 as long as possible, is that it enables the appimage run on more (older) systems. But that also means distributing AppImages with known security issues. For that reason the official AppImage I'll build for 1.6.0 will be based on Ubuntu 20.04. |
|
thanks! the pipeline went through! i will further think about upgrading... but i wonder a bit, what's the security risk of distributing a scribus appimage with older libs... i will need some more investigations... |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-08-15 17:42 | ale | New Issue | |
2023-08-16 06:18 | ale | Summary | CI fails because of poppler => CI fails because of podofo |
2023-08-16 06:19 | ale | Description Updated | |
2023-08-16 09:46 | jghali | Note Added: 0050316 | |
2023-08-16 09:57 | jghali | Note Added: 0050317 | |
2023-08-16 11:23 | jghali | Category | - => Integration |
2023-08-16 16:11 | jghali | Note Added: 0050318 | |
2023-08-16 18:12 | ale | Note Added: 0050321 | |
2023-08-17 07:14 | jghali | Assigned To | => jghali |
2023-08-17 07:14 | jghali | Status | new => resolved |
2023-08-17 07:14 | jghali | Resolution | open => fixed |
2023-08-17 07:14 | jghali | Fixed in Version | => 1.5.9.svn |
2023-08-17 07:14 | jghali | Note Added: 0050322 | |
2023-08-17 08:09 | ale | Note Added: 0050323 | |
2023-09-11 20:34 | cbradney | Status | resolved => closed |