View Issue Details

IDProjectCategoryView StatusLast Update
0017021ScribusGeneralpublic2023-11-04 09:09
Reporterale Assigned Toale  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.6.0.svn 
Fixed in Version1.6.0.svn 
Summary0017021: for loop defect
Descriptionooops:

according to

https://github.com/scribusproject/scribus/issues/173

for (uint gid = 0; gid <= maxGid; ++gid);

from https://github.com/scribusproject/scribus/blob/master/scribus/fonts/cff.cpp#L1551

has a trailing semi colon that should not be there!
TagsNo tags attached.
PatchNo

Activities

cbradney

2023-10-06 21:12

administrator   ~0050362

Thanks Ale

ale

2023-10-07 07:37

manager   ~0050365

... I wonder if it would not be better to remove the whole

#ifdef UNTESTET_CFF_MAKEENCODING

It seems to be dead code added by Andreas in 2015 and it has not be touched since that time.

Or, if somebody understands what the snippet is supposed to do, there should IMO be a comment stating the meaning of it and the condition for the code to be enabled...

Issue History

Date Modified Username Field Change
2023-10-06 10:40 ale New Issue
2023-10-06 21:11 cbradney Product Version 1.7.0.svn => 1.6.0.svn
2023-10-06 21:12 cbradney Assigned To => ale
2023-10-06 21:12 cbradney Status new => resolved
2023-10-06 21:12 cbradney Resolution open => fixed
2023-10-06 21:12 cbradney Fixed in Version => 1.6.0.svn
2023-10-06 21:12 cbradney Note Added: 0050362
2023-10-07 07:37 ale Note Added: 0050365
2023-11-04 09:09 cbradney Status resolved => closed