View Issue Details

IDProjectCategoryView StatusLast Update
0017115ScribusUsabilitypublic2025-05-12 20:45
Reporterpmjdebruijn Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version1.6.2.svn 
Target Version1.7 milestoneFixed in Version1.7.1.svn 
Summary0017115: New Page Sizes
DescriptionThis removes duplicates US Legal / US Legal, they are already added as "Legal" and "Letter".

Adds Novella, Digest (Half Letter), US Trade, Crown Quarto, Comic Book all are easily accessible via services like Lulu.com
TagsNo tags attached.
PatchYes

Relationships

related to 0017247 closednitramr Indigo UI: New Document Dialog 

Activities

pmjdebruijn

2024-01-10 17:34

reporter  

pagesize.patch (2,247 bytes)   
diff -Nurpd a/scribus/pagesize.cpp b/scribus/pagesize.cpp
--- a/scribus/pagesize.cpp	2024-01-07 18:07:09.000000000 +0100
+++ b/scribus/pagesize.cpp	2024-01-10 18:14:41.401677045 +0100
@@ -343,24 +343,6 @@ void PageSize::generateSizeList()
 	info.pageUnitIndex = SC_MM;
 	info.trSizeName = QObject::tr("Compact Disc");
 	m_pageSizeList.insert("Compact Disc", info);
-	//Letter Half
-	info.width = mm2pts(139.7);
-	info.height = mm2pts(215.9);
-	info.pageUnitIndex = SC_MM;
-	info.trSizeName = QObject::tr("Letter Half");
-	m_pageSizeList.insert("Letter Half", info);
-	//US Letter
-	info.width = mm2pts(215.9);
-	info.height = mm2pts(279.4);
-	info.pageUnitIndex = SC_MM;
-	info.trSizeName = QObject::tr("US Letter");
-	m_pageSizeList.insert("US Letter", info);
-	//US Legal
-	info.width = mm2pts(215.9);
-	info.height = mm2pts(355.6);
-	info.pageUnitIndex = SC_MM;
-	info.trSizeName = QObject::tr("US Legal");
-	m_pageSizeList.insert("US Legal", info);
 	//11x17
 	info.width = in2pts(11);
 	info.height = in2pts(17);
@@ -417,11 +399,43 @@ void PageSize::generateSizeList()
 	info.trSizeName = QObject::tr("27x39 (Arch E3)");
 	m_pageSizeList.insert("27x39 (Arch E3)", info);
 
-	//Executive
+	//Novella
+	info.width = in2pts(5);
+	info.height = in2pts(8);
+	info.pageUnitIndex = SC_IN;
+	info.trSizeName = QObject::tr("Novella");
+	m_pageSizeList.insert("Novella", info);
+
+	//Digest (Half Letter)
+	info.width = in2pts(5.5);
+	info.height = in2pts(8.5);
+	info.pageUnitIndex = SC_IN;
+	info.trSizeName = QObject::tr("Digest (Half Letter)");
+	m_pageSizeList.insert("Digest (Half Letter)", info);
+
+	//US Trade
+	info.width = in2pts(6);
+	info.height = in2pts(9);
+	info.pageUnitIndex = SC_IN;
+	info.trSizeName = QObject::tr("US Trade");
+	m_pageSizeList.insert("US Trade", info);
+
+	//Crown Quarto
+	info.width = mm2pts(189);
+	info.height = mm2pts(246);
+	info.pageUnitIndex = SC_MM;
+	info.trSizeName = QObject::tr("Crown Quarto");
+	m_pageSizeList.insert("Crown Quarto", info);
+
+	//Comic Book
+	info.width = in2pts(6.63);
+	info.height = in2pts(10.25);
+	info.pageUnitIndex = SC_IN;
+	info.trSizeName = QObject::tr("Comic Book");
+	m_pageSizeList.insert("Comic Book", info);
+
 	//Folio
 	//Ledger
-	//Legal
-	//Letter
 	//Tabloid
 }
 
pagesize.patch (2,247 bytes)   

ale

2025-05-12 18:52

manager   ~0052514

According to nitramr, this patch does not apply anymore...

But

a. it's more than a year, since the patch has been created, and I think that it's not the author that is to blame.
b. the patch seems to be simple enough, that it should be easy to apply it "manually"... and who would dare to do another patch now, and see it laying around for years, before it's deprecated again?

nitramr

2025-05-12 20:13

developer   ~0052515

Patch add missing formats for Comic Book and Crown Quarto.

Might be the patch has offset issues, because my code base currently includes changes from https://bugs.scribus.net/view.php?id=17476
pagesizes_2025-05-12_01.patch (1,090 bytes)   
Index: scribus/pagesize.cpp
===================================================================
--- scribus/pagesize.cpp	(Revision 26861)
+++ scribus/pagesize.cpp	(Arbeitskopie)
@@ -264,6 +297,7 @@
 	// https://papersizes.io/books/	
 	// https://paper-size.com/size/12mo-books-sizes.html
 	// https://en.wikipedia.org/wiki/Book_size
+	// https://blissetts.com/sizes-stocks-more
 	PageSizeInfo::Category catBooks =  PageSizeInfo::Book;
 	QString prefix = "Book_";
 	addPageSize(prefix + "Folio", QObject::tr("Folio"), 12.0, 19.0, SC_IN, catBooks);
@@ -283,6 +317,8 @@
 	addPageSize(prefix + "A Format", QObject::tr("A Format"), 4.25, 7.0, SC_IN, catBooks);
 	addPageSize(prefix + "B Format", QObject::tr("B Format"), 5.1, 7.75, SC_IN, catBooks);
 	addPageSize(prefix + "C Format", QObject::tr("C Format"), 5.25, 8.5, SC_IN, catBooks);
+	addPageSize(prefix + "Comic Book", QObject::tr("Comic Book"), 6.63, 10.25, SC_IN, catBooks);
+	addPageSize(prefix + "Crown Quarto", QObject::tr("Crown Quarto"), 189, 246, SC_MM, catBooks);
 
 	// Business Cards
 	// https://papersizes.io/business-card/	
pagesizes_2025-05-12_01.patch (1,090 bytes)   

Issue History

Date Modified Username Field Change
2024-01-10 17:34 pmjdebruijn New Issue
2024-01-10 17:34 pmjdebruijn File Added: pagesize.patch
2024-09-11 21:09 nitramr Relationship added related to 0017247
2025-05-12 18:52 ale Note Added: 0052514
2025-05-12 20:13 nitramr Note Added: 0052515
2025-05-12 20:13 nitramr File Added: pagesizes_2025-05-12_01.patch
2025-05-12 20:13 nitramr Target Version => 1.7 milestone
2025-05-12 20:45 cbradney Assigned To => cbradney
2025-05-12 20:45 cbradney Status new => resolved
2025-05-12 20:45 cbradney Resolution open => fixed
2025-05-12 20:45 cbradney Fixed in Version => 1.7.1.svn