View Issue Details

IDProjectCategoryView StatusLast Update
0017124ScribusInternalpublic2024-02-12 21:10
Reporterale Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
Product Version1.7.0.svn 
Fixed in Version1.6.2.svn 
Summary0017124: Useless m_item check in StyleManager

we have

    SMReplaceDia dia(selected, tmp, this);
    if (dia.exec() && m_item)

why is m_item checked *after* the dialog is executed?
and what does it check?

as far i can tell, m_item is already checked on line 307 and won't change on its way to line 317...

if at all, m_item should imo be checked before showing the dialog not afterwards...
TagsNo tags attached.



2024-01-19 20:37

administrator   ~0050912

Last edited: 2024-01-19 20:41

It seems this check is indeed useless: m_item is already checked at this stage.

Issue History

Date Modified Username Field Change
2024-01-14 10:13 ale New Issue
2024-01-14 10:14 ale Summary why fi m_item and why there? => why if m_item and why there?
2024-01-19 20:37 jghali Note Added: 0050912
2024-01-19 20:38 jghali Category General => Internal
2024-01-19 20:38 jghali Summary why if m_item and why there? => Useless m_item check in StyleManager
2024-01-19 20:41 jghali Note Edited: 0050912
2024-01-19 21:14 jghali Assigned To => jghali
2024-01-19 21:14 jghali Status new => resolved
2024-01-19 21:14 jghali Resolution open => fixed
2024-01-19 21:14 jghali Fixed in Version => 1.6.2.svn
2024-02-12 21:10 cbradney Status resolved => closed