View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017124 | Scribus | Internal | public | 2024-01-14 10:13 | 2024-02-12 21:10 |
Reporter | ale | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | have not tried |
Status | closed | Resolution | fixed | ||
Product Version | 1.7.0.svn | ||||
Fixed in Version | 1.6.2.svn | ||||
Summary | 0017124: Useless m_item check in StyleManager | ||||
Description | in https://gitlab.com/scribus/scribus/-/blob/master/scribus/ui/stylemanager.cpp?ref_type=heads#L317 we have SMReplaceDia dia(selected, tmp, this); if (dia.exec() && m_item) { why is m_item checked *after* the dialog is executed? and what does it check? as far i can tell, m_item is already checked on line 307 and won't change on its way to line 317... if at all, m_item should imo be checked before showing the dialog not afterwards... | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
Date Modified | Username | Field | Change |
---|---|---|---|
2024-01-14 10:13 | ale | New Issue | |
2024-01-14 10:14 | ale | Summary | why fi m_item and why there? => why if m_item and why there? |
2024-01-19 20:37 | jghali | Note Added: 0050912 | |
2024-01-19 20:38 | jghali | Category | General => Internal |
2024-01-19 20:38 | jghali | Summary | why if m_item and why there? => Useless m_item check in StyleManager |
2024-01-19 20:41 | jghali | Note Edited: 0050912 | |
2024-01-19 21:14 | jghali | Assigned To | => jghali |
2024-01-19 21:14 | jghali | Status | new => resolved |
2024-01-19 21:14 | jghali | Resolution | open => fixed |
2024-01-19 21:14 | jghali | Fixed in Version | => 1.6.2.svn |
2024-02-12 21:10 | cbradney | Status | resolved => closed |