View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0017127 | Scribus | Styles | public | 2024-01-14 10:43 | 2024-01-15 11:30 |
| Reporter | ale | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | N/A |
| Status | new | Resolution | open | ||
| Product Version | 1.7.0.svn | ||||
| Summary | 0017127: [PATCH] on delete, the style manager should not propose to replace by "No Style" | ||||
| Description | i've grepped the code for "No Style" and for the paragraph and character styles this seems to be let last reference that still exists. ... except for a few dubious calls for notesParStyle() ... which i don't know what they are doing. the only context when "No Style" is still possible are the lines. i've opened 0017126 to change that. instead of adding a check for "No Style" being a valid value for the type of styles to be deleted, i (obviously?) suggest that "No Style" should not be an option for any type of style. | ||||
| Tags | patch | ||||
| Patch | Yes | ||||
|
|
no-no-style.diff (513 bytes)
diff --git a/scribus/ui/smreplacedia.cpp b/scribus/ui/smreplacedia.cpp
index a1bab06ef..13ad8c696 100644
--- a/scribus/ui/smreplacedia.cpp
+++ b/scribus/ui/smreplacedia.cpp
@@ -19,7 +19,6 @@ SMRowWidget::SMRowWidget(const QString &toBeDeleted, const QStringList& replaceO
deleteLabel = new QLabel(toBeDeleted, this);
layout->addWidget(deleteLabel);
optionsCombo = new QComboBox(this);
- optionsCombo->addItem( tr("No Style"));
optionsCombo->addItems(replaceOptions);
layout->addWidget(optionsCombo);
}
|
|
|
Patch not accepted: that would prevent inheriting parent properties when replacing a style. |
|
|
sorry, jean, i don't understand your comment here. what is the parent in this context? maybe, instead of removing the "No Style" entry, it would be enough to show a different text, one that hints to what happens behind the scene. as far i can tell, for text styles, it does not replace the current style by no style. that's almost for sure (since it's not possible to have "no style" there). if you give more hints, i can try to work on a further patch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2024-01-14 10:43 | ale | New Issue | |
| 2024-01-14 10:43 | ale | Note Added: 0050891 | |
| 2024-01-14 10:43 | ale | File Added: no-no-style.diff | |
| 2024-01-14 10:43 | ale | Patch | No => Yes |
| 2024-01-14 10:43 | ale | Tag Attached: patch | |
| 2024-01-14 23:35 | jghali | Note Added: 0050894 | |
| 2024-01-15 00:07 | jghali | Note Edited: 0050894 | |
| 2024-01-15 11:30 | ale | Note Added: 0050895 |
