View Issue Details

IDProjectCategoryView StatusLast Update
0017150ScribusProperties Palettepublic2024-02-12 21:10
Reporternitramr Assigned Tonitramr  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformDesktop PCOSUbuntuOS Version23.10 64-bit
Product Version1.6.1 
Target Version1.6 milestoneFixed in Version1.6.2.svn 
Summary0017150: Hatch colors are not part of getNamedResources()
DescriptionColors of a hatch do not appear in the color list if "Display only used color" is selected.

Patch adds missing colors to resource collection.
Steps To Reproduce1. Create new document and add one item
2. Go to color palette and select hatch for fill
3. Change the line color to, i.e. yellow
4. Check "Display only used color" in color picker
=> Item on canvas looks correct, color dropdown for line color doesn't contain previously selected color (i.e. yellow)
TagsNo tags attached.
PatchYes

Activities

nitramr

2024-01-28 19:36

developer  

fixhatchcolor_2024-01-28_01.patch (506 bytes)   
Index: scribus/pageitem.cpp
===================================================================
--- scribus/pageitem.cpp	(Revision 26012)
+++ scribus/pageitem.cpp	(Arbeitskopie)
@@ -8880,6 +8880,12 @@
 			lists.collectColor(meshGradientPatches[col].BR.colorName);
 		}
 	}
+	else if (GrType == Gradient_Hatch)
+	{
+		lists.collectColor(hatchForeground);
+		lists.collectColor(hatchBackground);
+	}
+
 	if (GrTypeStroke == 0)
 		lists.collectColor(lineColor());
 	else if (GrTypeStroke < Gradient_Pattern)

jghali

2024-01-29 21:37

administrator   ~0050955

Applied, thanks!

Issue History

Date Modified Username Field Change
2024-01-28 19:36 nitramr New Issue
2024-01-28 19:36 nitramr File Added: fixhatchcolor_2024-01-28_01.patch
2024-01-28 19:37 nitramr Summary Hatch colors are not part of getNamedResources => [PATCH] Hatch colors are not part of getNamedResources
2024-01-29 21:37 jghali Summary [PATCH] Hatch colors are not part of getNamedResources => Hatch colors are not part of getNamedResources()
2024-01-29 21:37 jghali Assigned To => nitramr
2024-01-29 21:37 jghali Status new => resolved
2024-01-29 21:37 jghali Resolution open => fixed
2024-01-29 21:37 jghali Fixed in Version => 1.6.2.svn
2024-01-29 21:37 jghali Note Added: 0050955
2024-02-12 21:10 cbradney Status resolved => closed