View Issue Details

IDProjectCategoryView StatusLast Update
0017158ScribusInternalpublic2024-02-12 21:10
Reporterale Assigned Toale  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
Product Version1.7.0.svn 
Fixed in Version1.6.2.svn 
Summary0017158: unused variable patternSpace in pdflib_core
Descriptionhttps://gitlab.com/scribus/scribus/-/blob/master/scribus/pdflib_core.cpp?ref_type=heads#L6628

patternSpace is defined and set, but never read.

there might be a bug somewhere, where it should have been used instead of something else... or it can simply be removed.
TagsNo tags attached.
PatchNo

Activities

ale

2024-02-10 11:03

manager   ~0050980

attached the trivial patch to remove the variable
no-pattern-space.diff (802 bytes)   
diff --git a/scribus/pdflib_core.cpp b/scribus/pdflib_core.cpp
index 5b0391228..bcd858464 100644
--- a/scribus/pdflib_core.cpp
+++ b/scribus/pdflib_core.cpp
@@ -6625,7 +6625,6 @@ bool PDFLibCore::PDF_PatternFillStroke(QByteArray& output, const PageItem *currI
 	double patternRotation = 0.0;
 	double patternSkewX = 0.0;
 	double patternSkewY = 0.0;
-	double patternSpace = 0.0;
 	bool mirrorX = false, mirrorY = false;
 	if (kind == 0)
 	{
@@ -6649,7 +6648,6 @@ bool PDFLibCore::PDF_PatternFillStroke(QByteArray& output, const PageItem *currI
 		patternRotation = strokePatternTrans.rotation;
 		patternSkewX = strokePatternTrans.skewX;
 		patternSkewY = strokePatternTrans.skewY;
-		patternSpace = strokePatternTrans.space;
 		currItem->strokePatternFlip(mirrorX, mirrorY);
 	}
 	else if (kind == 2)
no-pattern-space.diff (802 bytes)   

Issue History

Date Modified Username Field Change
2024-02-10 09:37 ale New Issue
2024-02-10 11:03 ale Note Added: 0050980
2024-02-10 11:03 ale File Added: no-pattern-space.diff
2024-02-11 14:45 jghali Category General => Internal
2024-02-11 17:17 jghali Assigned To => ale
2024-02-11 17:17 jghali Status new => resolved
2024-02-11 17:17 jghali Resolution open => fixed
2024-02-11 17:17 jghali Fixed in Version => 1.6.2.svn
2024-02-12 21:10 cbradney Status resolved => closed