View Issue Details

IDProjectCategoryView StatusLast Update
0017159ScribusGeneralpublic2024-02-11 18:11
Reporterale Assigned To 
PrioritynormalSeverityminorReproducibilityN/A
Status newResolutionopen 
Product Version1.7.0.svn 
Summary0017159: check for poppler version to avoid a warning
Description... and, most of all, reduce the risk of forgetting to delete the variable definition when turning off the support for poppler < 22.4.0
TagsNo tags attached.
PatchNo

Activities

ale

2024-02-11 18:11

manager   ~0050981

check-poppler-version.diff (597 bytes)   
diff --git a/scribus/plugins/import/pdf/slaoutput.cpp b/scribus/plugins/import/pdf/slaoutput.cpp
index 4e31e4b6c..91ec97213 100644
--- a/scribus/plugins/import/pdf/slaoutput.cpp
+++ b/scribus/plugins/import/pdf/slaoutput.cpp
@@ -2954,7 +2954,10 @@ void SlaOutputDev::updateFont(GfxState *state)
 	SplashFontFile *fontFile;
 	SplashFontSrc *fontsrc = nullptr;
 	Object refObj, strObj;
+#if POPPLER_ENCODED_VERSION >= POPPLER_VERSION_ENCODE(22, 4, 0)
+#else
 	int tmpBufLen = 0;
+#endif
 	int *codeToGID = nullptr;
 	const double *textMat = nullptr;
 	double m11, m12, m21, m22, fontSize;
check-poppler-version.diff (597 bytes)   

Issue History

Date Modified Username Field Change
2024-02-11 18:04 ale New Issue
2024-02-11 18:11 ale Note Added: 0050981
2024-02-11 18:11 ale File Added: check-poppler-version.diff