View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0017159 | Scribus | General | public | 2024-02-11 18:04 | 2024-09-16 20:54 |
Reporter | ale | Assigned To | ale | ||
Priority | normal | Severity | minor | Reproducibility | N/A |
Status | closed | Resolution | fixed | ||
Product Version | 1.7.0.svn | ||||
Fixed in Version | 1.6.2.svn | ||||
Summary | 0017159: check for poppler version to avoid a warning | ||||
Description | ... and, most of all, reduce the risk of forgetting to delete the variable definition when turning off the support for poppler < 22.4.0 | ||||
Tags | No tags attached. | ||||
Patch | No | ||||
|
check-poppler-version.diff (597 bytes)
diff --git a/scribus/plugins/import/pdf/slaoutput.cpp b/scribus/plugins/import/pdf/slaoutput.cpp index 4e31e4b6c..91ec97213 100644 --- a/scribus/plugins/import/pdf/slaoutput.cpp +++ b/scribus/plugins/import/pdf/slaoutput.cpp @@ -2954,7 +2954,10 @@ void SlaOutputDev::updateFont(GfxState *state) SplashFontFile *fontFile; SplashFontSrc *fontsrc = nullptr; Object refObj, strObj; +#if POPPLER_ENCODED_VERSION >= POPPLER_VERSION_ENCODE(22, 4, 0) +#else int tmpBufLen = 0; +#endif int *codeToGID = nullptr; const double *textMat = nullptr; double m11, m12, m21, m22, fontSize; |
|
Applied (with a slight change). Thanks! |
Date Modified | Username | Field | Change |
---|---|---|---|
2024-02-11 18:04 | ale | New Issue | |
2024-02-11 18:11 | ale | Note Added: 0050981 | |
2024-02-11 18:11 | ale | File Added: check-poppler-version.diff | |
2024-03-25 21:16 | jghali | Assigned To | => ale |
2024-03-25 21:16 | jghali | Status | new => resolved |
2024-03-25 21:16 | jghali | Resolution | open => fixed |
2024-03-25 21:16 | jghali | Fixed in Version | => 1.6.2.svn |
2024-03-25 21:16 | jghali | Note Added: 0051069 | |
2024-09-16 20:54 | cbradney | Status | resolved => closed |