View Issue Details

IDProjectCategoryView StatusLast Update
0017216ScribusBuild Systempublic2024-05-14 18:38
ReporterAkiSakurai Assigned To 
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionno change required 
Product Version1.7.0.svn 
Summary0017216: The pkg_search_module of PoDoFo should be optional.
DescriptionThere are no pkgconfig for PoDoFo on Homebrew, we should be able to find it using the header and library paths only.

index ca910a89b..433ba90b6 100644
--- a/cmake/modules/FindLIBPODOFO.cmake
+++ b/cmake/modules/FindLIBPODOFO.cmake
@@ -18,7 +18,7 @@ find_package(PkgConfig QUIET)
 if(DEFINED LIBPODOFO_DIR_PREFIX)
        set(ENV{PKG_CONFIG_PATH} "${LIBPODOFO_DIR_PREFIX}/lib/pkgconfig:$ENV{PKG_CONFIG_PATH}")
 endif()
-pkg_search_module(libpodofo REQUIRED libpodofo podofo)
+pkg_search_module(libpodofo libpodofo podofo)
TagsNo tags attached.
PatchNo

Activities

cbradney

2024-05-12 19:12

administrator   ~0051146

All you're changing is whether podofo is required or not. We want Scribus to have podofo at build time.
As for whether HomeBrew has the pkgconfig file, thats a different problem that is upstream.

AkiSakurai

2024-05-14 05:24

reporter   ~0051149

Resolved by upstream.
https://github.com/Homebrew/homebrew-core/commit/01a803f569315990bea29634a7e6fda201833a46

Issue History

Date Modified Username Field Change
2024-05-12 05:28 AkiSakurai New Issue
2024-05-12 19:12 cbradney Note Added: 0051146
2024-05-14 05:24 AkiSakurai Note Added: 0051149
2024-05-14 07:34 ale Status new => resolved
2024-05-14 07:34 ale Resolution open => fixed
2024-05-14 07:34 ale Status resolved => closed
2024-05-14 18:38 jghali Resolution fixed => no change required