View Issue Details

IDProjectCategoryView StatusLast Update
0017285ScribusUser Interfacepublic2024-12-23 23:18
Reporternitramr Assigned Tonitramr  
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
PlatformDesktop PCOSUbuntuOS Version24.04 64-bit
Product Version1.7.0.svn 
Target Version1.7.0Fixed in Version1.7.0.svn 
Summary0017285: Indigo UI: Text Properties Palette Redesign (+Style Manager Adjustments)
DescriptionA huge rework of the text properties panel is done. See screenshots.

What's new?
- 51 new icons (incl. some refinements of old ones)
- 21 new previews for OpenType font features
- Text panel has been divided into 3 areas (character, paragraph and layout)
- Color selection is now also done via a round color button like in the Frame Properties panel
- Paragraph and character styles can now be edited and created directly
- Line styles can also be edited and created directly
- The Hyphenation section has been expanded to include 2 buttons to enable or disable hyphenation in the text. The language selection for the text is also located there
- First Line Offset & Optical Margins have been moved to Alignment & Tabs
- Advanced Settings have been merged with the Text Effects in a new Typography section
- The Style Manager (Character Styles + Paragraph Styles) has been largely aligned with the changes in the Text Properties panel (but still needs another iteration).

This patch has some overlaps with this patch https://bugs.scribus.net/view.php?id=17283

PS: the patch file includes only modified files. New ones and all assets are in the zip file.
PPS: the patch has over 18k lines of code. Most of the changes are related to the ui files.
TagsNo tags attached.
PatchYes

Relationships

related to 0017148 new Font Features squished 
related to 0012265 closednitramr Optical margins setting too verbose and unintuitive 
related to 0016509 closednitramr Update layout for Text Properties: unify buttons, layout, new 
related to 0015914 closednitramr Indigo UI: Store the content / properties palette's panel collapsing status in the preferences 
related to 0014512 closednitramr Re-order Text Properties items so that they make sense 
related to 0008870 closednitramr Show the value of what the linespacing will be when "Align to Baseline Grid" or "Auto" is chosen in the Style Manager 

Activities

nitramr

2024-10-06 19:04

developer  

scribus_assets.zip (319,654 bytes)
sm_caracter.png (97,656 bytes)   
sm_paragraph.png (117,542 bytes)   
textprops_2024-10-06_01.patch (613,071 bytes)   
tp_collapsed.png (39,637 bytes)   
tp_expanded1.png (77,517 bytes)   
tp_expanded2.png (87,838 bytes)   

cbradney

2024-10-07 18:56

administrator   ~0051416

I will probably get the resources committed first, however:
- char styles
-- language is also used for spelling so that title needs adjusting, but that impacts the hyphenation related boxes
- para styles
-- Optical margins still has text, no icons but may be able to have icons, but Typography does have them?
--Typography - not sure those icons are the clearest
Text Props
- not sure why the colours are now in two sections. I think they should remain together. stroke colour is not typography related, as such.
- I think I would reoder the new tabs. Eg I think Layout is going to be needed more often than Orphans or Lists etc so would move it below alignment

Looking good so far!

nitramr

2024-10-10 14:20

developer   ~0051424

Hi Craig, thanks for your feedback.

>> language is also used for spelling so that title needs adjusting, but that impacts the hyphenation related boxes
I think we could rename it to "Hyphenation & Spelling". A spelling check button could be added there too? Alternative "Hyphenation & Language"

>> Optical margins still has text, no icons but may be able to have icons, but Typography does have them?
Yes, the style manager needs another iteration. A style difference to the parent style is indicated by bold text. I don't have a good solution yet how to show this difference on an icon button.
The same applies to the color selection in the style manager, it is still different.

>> I think they should remain together. stroke colour is not typography related, as such.
Yes, I agree. I can move it back to "Font" section. I can rename this section to Font & Colors too.

>> Typography - not sure those icons are the clearest
Do you mean all icons, or only the new ones for "Word Tracking" and "Glyph Extension"?

>> I think I would reoder the new tabs. Eg I think Layout is going to be needed more often than Orphans or Lists etc so would move it below alignment
If I change the order, the main headlines don't make sense anymore. I will think about a solution.

cbradney

2024-10-11 21:23

administrator   ~0051425

Its the spacing icons that just feel too small and less clear than the words.

bubu

2024-10-13 23:37

reporter   ~0051433

Nitramr, as a user I am very grateful for this improvement. Thank you for your effort. I really like this compact interface. I am very excited to see when I can use it.

Some questions or comments:
- Optical margins why needs a revert/reset button? If both button is off this means there is no optical margins.
- Hyphenate and Dehyphenate buttons: Wouldn't this be nicer to implement with a simple toggle switch?
- “Do not split paragraph” & “Keep with next paragraph”: A toggle switch would be nicer.
 Style difference to the parent: I really hate the bold indicator. It is so ugly. Just in idea: Add a revert (icon: revert or arrow to bottom) button behind the entry and a dynamic tool tip for example “Revert to parent: [parent value]”

nitramr

2024-10-14 16:58

developer   ~0051434

Hi @bubu

Thanks for your feedback.

>> Optical margins why needs a revert/reset button? If both button is off this means there is no optical margins.
I removed the default button everywhere. It's funny, the action of this button ends in an empty function with the comment "TODO". I guess the whole optical margin implementation is in an unfinished transition state. Only the right optical margin works. I also found some leftovers of an old combo box for this function in the code.

>> Hyphenate and Dehyphenate buttons: Wouldn't this be nicer to implement with a simple toggle switch?
Yes and no. The selected text does not return any information about the hyphenation status. The button just bluntly triggers an action. It takes more effort to implement a toggle switch. But overall good suggestions.

>> “Do not split paragraph” & “Keep with next paragraph”: A toggle switch would be nicer.
Yes, I will change that.

>> Just in idea: Add a revert (icon: revert or arrow to bottom) button behind the entry and a dynamic tool tip for example
Yes, looks like a solid solution at the moment. See screenshots. I created two different icons. I think the round arrow is the best choice.

@cbrandey I add some labels next to the space icons (that goes for text properties and style manager).

Also, I did a few tests to organize the sections (grouped by categories with heading, in tabs and without and categories). I think without categories is the best option at the moment.

The sections would need to be further divided to fit the categories like "Character" or "Paragraph". For example, hyphenation has a feature in both categories and so on.
I think if there is no categorization, we can sort the section by importance.

After some more code cleanups and tests, I will provide a new patch.
color_character.png (7,139 bytes)   
parent_icon_1.png (14,353 bytes)   
parent_icon_2.png (14,746 bytes)   
TP.png (80,213 bytes)   

cbradney

2024-10-15 20:07

administrator   ~0051435

Looking forward to this patch! BTW do you want me to commit those extra code files or do you have changes to those?

nitramr

2024-10-15 20:13

developer   ~0051436

Not necessary, I made changes in the new files too.

nitramr

2024-10-15 21:38

developer   ~0051437

Last edited: 2024-10-16 18:37

New files and changed ui files are in zip archive to keep the patch small.

I applied the patch with r26327 without conflicts, but the patch based on r26320.
files.zip (49,311 bytes)

cbradney

2024-10-16 20:24

administrator   ~0051441

Ok, I have committed it. Thank you!

I wanted to get it in as is but likely some changes required. Firstly the style windows shrink too much and icons/text are squished.
In the palette, spacing in the Font area is larger than others?
I think we need to group the section by "text" and "frame" configurations.. eg Font/alignment/typography... then others.
image.png (35,515 bytes)   
image-2.png (37,406 bytes)   
image-3.png (54,761 bytes)   

nitramr

2024-10-16 21:04

developer   ~0051442

Thanks, Craig! I will take a look into the issues.

>> In the palette, spacing in the Font area is larger than others?
It's only for mac like this. I didn't specify are larger spacing.

nitramr

2024-10-19 17:11

developer   ~0051459

The new patch includes the following changes:

- TextPalette: removed non-existent function
- ColorButton: fix for rendering the small color dot
- StyleManager: fix to avoid squashing the layout by setting the size policy to the preferred size
- StyleManager: lists & drop caps layout is equal to layout from text properties palette
- StyleManager: font feature layout has been rearranged to reduce the height of the dialog
- Clean up: commenting out code removed
ui_file.zip (12,649 bytes)

cbradney

2024-10-19 18:02

administrator   ~0051460

Thanks, committed :)

bubu

2024-10-23 15:31

reporter   ~0051481

@nitramr, I finally managed to build. It's fantastic! :-) Many, many thanks for your efforts.

Issue History

Date Modified Username Field Change
2024-10-06 19:04 nitramr New Issue
2024-10-06 19:04 nitramr File Added: scribus_assets.zip
2024-10-06 19:04 nitramr File Added: sm_caracter.png
2024-10-06 19:04 nitramr File Added: sm_paragraph.png
2024-10-06 19:04 nitramr File Added: textprops_2024-10-06_01.patch
2024-10-06 19:04 nitramr File Added: tp_collapsed.png
2024-10-06 19:04 nitramr File Added: tp_expanded1.png
2024-10-06 19:04 nitramr File Added: tp_expanded2.png
2024-10-07 18:56 cbradney Note Added: 0051416
2024-10-10 14:20 nitramr Note Added: 0051424
2024-10-11 21:23 cbradney Note Added: 0051425
2024-10-13 23:37 bubu Note Added: 0051433
2024-10-14 16:58 nitramr Note Added: 0051434
2024-10-14 16:58 nitramr File Added: color_character.png
2024-10-14 16:58 nitramr File Added: parent_icon_1.png
2024-10-14 16:58 nitramr File Added: parent_icon_2.png
2024-10-14 16:58 nitramr File Added: TP.png
2024-10-15 20:07 cbradney Note Added: 0051435
2024-10-15 20:13 nitramr Note Added: 0051436
2024-10-15 21:38 nitramr Note Added: 0051437
2024-10-15 21:38 nitramr File Added: files.zip
2024-10-15 21:38 nitramr File Added: textproperties_2024-10-15_01.patch
2024-10-16 18:37 nitramr Note Edited: 0051437
2024-10-16 20:24 cbradney Note Added: 0051441
2024-10-16 20:24 cbradney File Added: image.png
2024-10-16 20:24 cbradney File Added: image-2.png
2024-10-16 20:24 cbradney File Added: image-3.png
2024-10-16 21:04 nitramr Note Added: 0051442
2024-10-19 17:11 nitramr Note Added: 0051459
2024-10-19 17:11 nitramr File Added: textproperties_2024-10-19_01.patch
2024-10-19 17:11 nitramr File Added: ui_file.zip
2024-10-19 18:02 cbradney Note Added: 0051460
2024-10-22 13:24 nitramr Relationship added related to 0017148
2024-10-22 13:26 nitramr Relationship added related to 0012265
2024-10-22 14:43 nitramr Relationship added related to 0016509
2024-10-22 14:43 nitramr Relationship added related to 0015914
2024-10-22 15:58 nitramr Relationship added related to 0014512
2024-10-23 15:31 bubu Note Added: 0051481
2024-12-23 14:16 nitramr Relationship added related to 0008870
2024-12-23 15:10 cbradney Assigned To => nitramr
2024-12-23 15:10 cbradney Status new => resolved
2024-12-23 15:10 cbradney Resolution open => fixed
2024-12-23 15:10 cbradney Fixed in Version => 1.7.0.svn
2024-12-23 23:18 cbradney Status resolved => closed