|
ale
2024-12-13 08:48
manager
|
|
|
|
|
using the same red line as for the current page on the "desktop" might be a good choice...
(as you see in the screenshot, there is a bug: under some circumstances, scribus stops displaying the marker for the current page. sadly, i cannot really find out how to reproduce it.) |
|
|
|
Hi ale,
the color of the selected page in page preview widget based on "Selected Page Border" color from Preferences -> Display -> Colors.
At the moment, you can change that via settings, but you have to restart Scribus to apply the new color. The patch apply a change where it is not necessary to restart Scribus to apply the new color.
In general I agree with you, some default colors are not great.
pageselection_2024-12-13_01.patch (2,035 bytes)
Index: scribus/ui/pagepalette_pages.cpp
===================================================================
--- scribus/ui/pagepalette_pages.cpp (Revision 26480)
+++ scribus/ui/pagepalette_pages.cpp (Arbeitskopie)
@@ -25,6 +25,7 @@
#include "ui/widgets/pagelayout.h"
#include "pagepalette_pages.h"
#include "pagepalette_widgets.h"
+#include "prefsmanager.h"
#include "qobjectdefs.h"
#include "scpage.h"
#include "scribusapp.h"
@@ -445,6 +446,11 @@
currView = view;
+ if (currView == nullptr)
+ return;
+
+ pageViewWidget->pageGrid()->setSelectionColor(PrefsManager::instance().appPrefs.displayPrefs.pageBorderColor);
+
// if (currView)
// connect(currView->m_doc, SIGNAL(pagePreviewChanged()), this, SLOT(updatePagePreview()));
Index: scribus/ui/pagepalette_widgets.cpp
===================================================================
--- scribus/ui/pagepalette_widgets.cpp (Revision 26480)
+++ scribus/ui/pagepalette_widgets.cpp (Arbeitskopie)
@@ -259,23 +259,26 @@
m_documentPageSize = pageSize;
}
-void PageGrid::setRowHeight(int height)
+void PageGrid::setRowHeight(int height)
{
- // clamp sizes
- m_rowHeight = qBound(64, height, 128);
- m_rowSpace = qBound(8, height / 8, 16);
-
+ // clamp sizes
+ m_rowHeight = qBound(64, height, 128);
+ m_rowSpace = qBound(8, height / 8, 16);
+
// updateTileSize();
calculateSize();
update();
-
- PrefsContext *prefTileSize = PrefsManager::instance().prefsFile->getContext("PagePalette");
- prefTileSize->set("pagePreviewSize", height);
- PrefsManager::instance().prefsFile->write();
+
+ PrefsContext *prefTileSize = PrefsManager::instance().prefsFile->getContext("PagePalette");
+ prefTileSize->set("pagePreviewSize", height);
+ PrefsManager::instance().prefsFile->write();
}
void PageGrid::setFontSize(int size)
{
+ if (m_fontSize == size)
+ return;
+
m_fontSize = size;
update();
}
@@ -282,6 +285,9 @@
void PageGrid::setSelectionColor(QColor color)
{
+ if (m_colorSelection == color)
+ return;
+
m_colorSelection = color;
update();
}
|
|
|
|
hey,
i guess that if it's the same color in both cases, the line around the page in "Arrange Pages" is just slightly too thick for my taste... |
|
|
|
Committed, plus reduced line width to 1 |
|
|
|
yes!
the 1 px border makes the difference.
the blue progress bar is still there.
but i guess, one day, we will need to think about a general visual (and usability) improvement of the status bar.
and find a good concept for it. |
|
