View Issue Details

IDProjectCategoryView StatusLast Update
0017345ScribusUser Interfacepublic2024-12-23 23:18
Reporternitramr Assigned Tonitramr  
PrioritynormalSeverityminorReproducibilityN/A
Status closedResolutionfixed 
PlatformDesktop PCOSUbuntuOS Version24.10 64-bit
Product Version1.7.0.svn 
Target Version1.7.0Fixed in Version1.7.0.svn 
Summary0017345: UI resizing issue of preferences dialog
DescriptionThe patch fixes the following issues:
- add missing tool tips for paragraph effects in PP
- replace "3 or 4-fold layout" information in tool tip of margin widget
- UI resizing issue of preferences dialog
TagsNo tags attached.
PatchYes

Activities

nitramr

2024-12-17 16:43

developer  

tooltip_2024-12-17_01.patch (7,410 bytes)   
Index: scribus/ui/newmarginwidget.cpp
===================================================================
--- scribus/ui/newmarginwidget.cpp	(Revision 26502)
+++ scribus/ui/newmarginwidget.cpp	(Arbeitskopie)
@@ -74,11 +74,11 @@
 	{
 		topMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the top margin guide and the edge of the page" ) + "</qt>");
 		bottomMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the bottom margin guide and the edge of the page" ) + "</qt>");
-		leftMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the left margin guide and the edge of the page. If a double-sided, 3 or 4-fold layout is selected, this margin space can be used to achieve the correct margins for binding.") + "</qt>");
-		rightMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the right margin guide and the edge of the page. If a double-sided, 3 or 4-fold layout is selected, this margin space can be used to achieve the correct margins for binding.") + "</qt>");
+		leftMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the left margin guide and the edge of the page. If a double-sided layout is selected, this margin space can be used to achieve the correct margins for binding.") + "</qt>");
+		rightMarginSpinBox->setToolTip( "<qt>" + tr( "Distance between the right margin guide and the edge of the page. If a double-sided layout is selected, this margin space can be used to achieve the correct margins for binding.") + "</qt>");
 		marginLinkButton->setToolTip( "<qt>" + tr( "Ensure all margins have the same value" ) + "</qt>");
 	}
-	else if (m_flags & BleedWidgetFlags)
+	else if (m_flags & BleedWidgetFlags)
 	{
 		topMarginSpinBox->setToolTip( "<qt>" + tr( "Distance for bleed from the top of the physical page" ) + "</qt>" );
 		bottomMarginSpinBox->setToolTip( "<qt>" + tr( "Distance for bleed from the bottom of the physical page" ) + "</qt>" );
Index: scribus/ui/preferencesdialogbase.ui
===================================================================
--- scribus/ui/preferencesdialogbase.ui	(Revision 26502)
+++ scribus/ui/preferencesdialogbase.ui	(Arbeitskopie)
@@ -6,7 +6,7 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>919</width>
+    <width>827</width>
     <height>586</height>
    </rect>
   </property>
@@ -14,37 +14,40 @@
    <string>Preferences</string>
   </property>
   <layout class="QVBoxLayout" name="verticalLayout">
+   <property name="spacing">
+    <number>8</number>
+   </property>
    <property name="leftMargin">
-    <number>9</number>
+    <number>8</number>
    </property>
    <property name="topMargin">
-    <number>9</number>
+    <number>8</number>
    </property>
    <property name="rightMargin">
-    <number>9</number>
+    <number>8</number>
    </property>
    <property name="bottomMargin">
-    <number>9</number>
+    <number>8</number>
    </property>
    <item>
-    <layout class="QHBoxLayout" name="frameHorizontalLayout">
+    <layout class="QHBoxLayout" name="frameHorizontalLayout" stretch="0,0">
      <property name="spacing">
-      <number>9</number>
+      <number>8</number>
      </property>
      <item>
       <widget class="QListWidget" name="preferencesTypeList">
+       <property name="sizePolicy">
+        <sizepolicy hsizetype="Preferred" vsizetype="Expanding">
+         <horstretch>0</horstretch>
+         <verstretch>0</verstretch>
+        </sizepolicy>
+       </property>
        <property name="minimumSize">
         <size>
-         <width>0</width>
+         <width>200</width>
          <height>0</height>
         </size>
        </property>
-       <property name="maximumSize">
-        <size>
-         <width>200</width>
-         <height>16777215</height>
-        </size>
-       </property>
        <property name="horizontalScrollBarPolicy">
         <enum>Qt::ScrollBarPolicy::ScrollBarAlwaysOff</enum>
        </property>
@@ -54,9 +57,6 @@
        <property name="showDropIndicator" stdset="0">
         <bool>false</bool>
        </property>
-       <property name="dragDropMode">
-        <enum>QAbstractItemView::DragDropMode::NoDragDrop</enum>
-       </property>
        <property name="alternatingRowColors">
         <bool>true</bool>
        </property>
Index: scribus/ui/propertywidget_pareffectbase.ui
===================================================================
--- scribus/ui/propertywidget_pareffectbase.ui	(Revision 26502)
+++ scribus/ui/propertywidget_pareffectbase.ui	(Arbeitskopie)
@@ -53,7 +53,11 @@
          <number>0</number>
         </property>
         <item>
-         <widget class="QComboBox" name="peCombo"/>
+         <widget class="QComboBox" name="peCombo">
+          <property name="toolTip">
+           <string>Paragraph effect</string>
+          </property>
+         </widget>
         </item>
        </layout>
       </widget>
@@ -111,7 +115,7 @@
        <item row="0" column="1">
         <widget class="QSpinBox" name="dropCapLines">
          <property name="toolTip">
-          <string>Drop Cap Lines</string>
+          <string>Drop cap lines</string>
          </property>
          <property name="minimum">
           <number>2</number>
@@ -190,6 +194,9 @@
            <verstretch>0</verstretch>
           </sizepolicy>
          </property>
+         <property name="toolTip">
+          <string>Character for bulleted list</string>
+         </property>
          <property name="editable">
           <bool>true</bool>
          </property>
@@ -245,6 +252,9 @@
        </item>
        <item row="2" column="1">
         <widget class="QSpinBox" name="numLevelSpin">
+         <property name="toolTip">
+          <string>Hierarchy level of list numbering</string>
+         </property>
          <property name="minimum">
           <number>1</number>
          </property>
@@ -340,6 +350,9 @@
        </item>
        <item row="2" column="4">
         <widget class="QSpinBox" name="numStart">
+         <property name="toolTip">
+          <string>Starting number of the list count</string>
+         </property>
          <property name="minimum">
           <number>1</number>
          </property>
@@ -349,10 +362,18 @@
         </widget>
        </item>
        <item row="3" column="1">
-        <widget class="QLineEdit" name="numPrefix"/>
+        <widget class="QLineEdit" name="numPrefix">
+         <property name="toolTip">
+          <string>List number prefix</string>
+         </property>
+        </widget>
        </item>
        <item row="3" column="4">
-        <widget class="QLineEdit" name="numSuffix"/>
+        <widget class="QLineEdit" name="numSuffix">
+         <property name="toolTip">
+          <string>List number suffix</string>
+         </property>
+        </widget>
        </item>
        <item row="1" column="1" colspan="4">
         <widget class="NumFormatCombo" name="numFormatCombo">
@@ -362,6 +383,9 @@
            <verstretch>0</verstretch>
           </sizepolicy>
          </property>
+         <property name="toolTip">
+          <string>List numbering style</string>
+         </property>
         </widget>
        </item>
        <item row="0" column="1" colspan="4">
@@ -529,7 +553,7 @@
   <customwidget>
    <class>ScrSpinBox</class>
    <extends>QDoubleSpinBox</extends>
-   <header location="global">ui/scrspinbox.h</header>
+   <header>ui/scrspinbox.h</header>
   </customwidget>
   <customwidget>
    <class>CharStyleComboBox</class>
tooltip_2024-12-17_01.patch (7,410 bytes)   

cbradney

2024-12-17 19:46

administrator   ~0051747

Committed just the UI fix. The tooltips need to wait until 1.7.1.svn is open due to string freeze.

Issue History

Date Modified Username Field Change
2024-12-17 16:43 nitramr New Issue
2024-12-17 16:43 nitramr File Added: tooltip_2024-12-17_01.patch
2024-12-17 19:45 cbradney Issue cloned: 0017346
2024-12-17 19:46 cbradney Summary Missing tooltips and UI fixes => UI resizing issue of preferences dialog
2024-12-17 19:46 cbradney Assigned To => nitramr
2024-12-17 19:46 cbradney Status new => resolved
2024-12-17 19:46 cbradney Resolution open => fixed
2024-12-17 19:46 cbradney Fixed in Version => 1.7.0.svn
2024-12-17 19:46 cbradney Note Added: 0051747
2024-12-23 23:18 cbradney Status resolved => closed