View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001906ScribusScripterpublic2005-04-22 08:142005-05-04 21:40
ReporterTomK32 Assigned Toringerc 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Product Version1.3.0cvs 
Fixed in Version1.3.0cvs 
Summary0001906: sizeObject() sets wrong size
Descriptiondidn't we have such a problem earlier?
TagsNo tags attached.
Patch

Relationships

related to 0001882 closedringerc Dimensions are strange in scripter 

Activities

ringerc

2005-04-26 13:15

reporter   ~0004419

It might be the same issue but it's probably not worth flagging as a dupe. Sorry for the spam.

ringerc

2005-04-27 04:26

reporter   ~0004429

Looks like the interface of ScribusView::SizeObject(...) changed in 1.3 :-(

Should all be fixed now.

TomK32

2005-05-03 17:01

reporter   ~0004484

Last edited: 2005-05-03 18:02

 still wrong.

Index: cmdmani.cpp
===================================================================
RCS file: /cvs/Scribus/scribus/plugins/scriptplugin/cmdmani.cpp,v
retrieving revision 1.7.2.23
diff -u -r1.7.2.23 cmdmani.cpp
--- cmdmani.cpp 27 Apr 2005 06:26:53 -0000 1.7.2.23
+++ cmdmani.cpp 3 May 2005 20:01:50 -0000
@@ -157,7 +157,7 @@
        PageItem *item = GetUniqueItem(QString::fromUtf8(Name));
        if (item == NULL)
                return NULL;
- Carrier->view->SizeItem(x, y, item->ItemNr);
+ Carrier->view->SizeItem(PointToValue(x), PointToValue(y), item->ItemNr);
        Py_INCREF(Py_None);
        return Py_None;
 }

ringerc

2005-05-04 00:34

reporter   ~0004490

fixed; thanks. I wish the in-API unit conversion didn't exist - IMO it's awful and should be done by the user program if they want something other than points (as, eg, reportlab does - works great, and is trivially easy to use).

As things are, (a) we have two different units in the API and (b) a script can call a helper function that changes the meaning of the co-ordinate system behind its back. eew!.

As you may have guessed, I never use the unit scaling. In this case I forgot about it entirely, hence the error. Your reminder is appreciated, though a note saying "wrong with non default units" wouldn't have hurt either.

Issue History

Date Modified Username Field Change
2005-04-22 08:14 TomK32 New Issue
2005-04-22 08:20 ringerc Status new => assigned
2005-04-22 08:20 ringerc Assigned To => ringerc
2005-04-22 08:21 ringerc Projection none => minor fix
2005-04-22 08:21 ringerc Product Version => 1.3.0cvs
2005-04-26 13:12 ringerc Relationship added related to 0001882
2005-04-26 13:13 ringerc Relationship replaced duplicate of 0001882
2005-04-26 13:14 ringerc Relationship replaced related to 0001882
2005-04-26 13:15 ringerc Note Added: 0004419
2005-04-27 04:26 ringerc Status assigned => resolved
2005-04-27 04:26 ringerc Fixed in Version => 1.3.0cvs
2005-04-27 04:26 ringerc Resolution open => fixed
2005-04-27 04:26 ringerc Note Added: 0004429
2005-05-03 17:01 TomK32 Status resolved => feedback
2005-05-03 17:01 TomK32 Resolution fixed => reopened
2005-05-03 17:01 TomK32 Note Added: 0004484
2005-05-03 18:02 TomK32 Note Edited: 0004484
2005-05-03 18:13 cbradney Status feedback => assigned
2005-05-04 00:34 ringerc Note Added: 0004490
2005-05-04 04:03 ringerc Status assigned => resolved
2005-05-04 04:03 ringerc Resolution reopened => fixed
2005-05-04 21:40 cbradney Status resolved => closed