View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003455 | Scribus | Undo/Redo | public | 2006-03-17 17:57 | 2016-12-08 21:32 |
| Reporter | christoph_s | Assigned To | |||
| Priority | high | Severity | major | Reproducibility | always |
| Status | acknowledged | Resolution | open | ||
| Product Version | 1.3.4cvs | ||||
| Target Version | 1.5.5 | ||||
| Summary | 0003455: Undoing all changes should reset document status to "unchanged" | ||||
| Description | Currently, even if all changes are undone, the document status remains "changed", and the "Save" button is activated accordingly. This can be confusing to users. | ||||
| Steps To Reproduce | Open an existing document, move a frame or do something else, then redo. Scribus seems to think that something has changed, but it hasn't. OO.o shows a little more "intelligence" here. | ||||
| Tags | dirty | ||||
| Patch | No | ||||
| related to | 0012134 | confirmed | Opening the Master Page dialog is recorded as a document change | |
| related to | 0011619 | closed | jghali | Column jump is recorded as document modification |
| related to | 0013511 | closed | cbradney | copying an item should not make the document dirty |
| related to | 0012811 | new | "Changed" indicator confused with inline text editing | |
| child of | 0012500 | acknowledged | Metabug: Undo/Redo (1.5.x.svn) |
|
|
Confirmed on OSX 10.8.5 1.5svn r19366 Even when undoing back to 'Initial State' and then trying to close document will trigger a 'save' dialog. |
|
|
This issue really messes with the users head. On one hand you'd think from experience with other apps, that undoing will return the document to it's initial state and no harm done if you close the program. But No.. now there is a doubt: "Did I change something without knowing it? What if I save and mess up what I had ?!? I don't even know what I changed?!?!" |
|
|
I worked on this issue, Scribus seems to work fine now (if undo is empty, no save dialogue, and no +"*" to docName ). I'll upoload the patch after retesting it. |
|
|
i don't think that testing if undo is empty is the right way to approach this ticket. the ticket is also wrongly described: the document should not be dirty if the undo history is at the action when the document was last saved. and dirty otherwise. so, if you go back to the initial state but you saved after action three, the document should be dirty. the solution is create a pointer for each document saying at which action (if any) the document was last saved and compare it to the current action in the action list. should not be hard to do. |
|
|
btw, you don't need to save that "pointer" in the .sla file. it can safely be reinitialised when the docuemnt is opened. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2006-03-17 17:57 | christoph_s | New Issue | |
| 2006-03-17 22:06 | jo-hannes | Status | new => acknowledged |
| 2007-05-23 20:36 | christoph_s | Relationship added | child of 0005745 |
| 2014-07-25 05:29 | Kunda | Relationship added | child of 0012500 |
| 2014-07-25 05:32 | Kunda | Note Added: 0032984 | |
| 2014-07-25 05:33 | Kunda | Target Version | => 1.6 milestone |
| 2014-10-07 23:32 | Kunda | Relationship deleted | child of 0005745 |
| 2015-05-06 01:56 | Kunda | Patch | => No |
| 2015-05-06 01:56 | Kunda | Note Added: 0035043 | |
| 2015-05-06 01:56 | Kunda | Priority | normal => high |
| 2015-05-06 01:56 | Kunda | Severity | trivial => major |
| 2015-05-06 01:56 | Kunda | Target Version | 1.6 milestone => 1.5.1 |
| 2015-10-10 23:12 | Kunda | Relationship added | related to 0012134 |
| 2015-10-10 23:12 | Kunda | Relationship added | related to 0011619 |
| 2015-11-05 08:53 | Mazoon | Note Added: 0037240 | |
| 2015-11-05 10:01 | ale | Note Added: 0037246 | |
| 2015-11-05 10:05 | ale | Note Added: 0037247 | |
| 2015-11-05 12:24 | Kunda | Sticky Issue | No => Yes |
| 2015-11-19 11:52 | Kunda | Sticky Issue | Yes => No |
| 2015-11-29 13:55 | Kunda | Target Version | 1.5.1 => 1.5.2 |
| 2016-01-18 14:03 | Kunda | Relationship added | related to 0013511 |
| 2016-01-23 17:16 | cbradney | Target Version | 1.5.2 => 1.5.4.svn |
| 2016-05-12 17:14 | Kunda | Relationship added | related to 0012811 |
| 2016-05-24 13:42 | Kunda | Tag Attached: dirty | |
| 2016-12-08 21:32 | Kunda | Target Version | 1.5.4.svn => 1.5.5 |
