View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000454 | Scribus | User Interface | public | 2004-04-08 07:12 | 2024-10-23 18:42 |
| Reporter | malex | Assigned To | nitramr | ||
| Priority | normal | Severity | tweak | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | i386 | OS | Linux | OS Version | 2.6 |
| Product Version | 1.3 | ||||
| Fixed in Version | 1.7.0.svn | ||||
| Summary | 0000454: Tools>Page Palette look need to be slightly tweaked and the name changed. | ||||
| Description | 1. Make the grey border slightly larger to be consistent with "Layers" dialog. 2. Maybe "Page Palette" name is intuitive to everyone, but me. However, I'd still like to propose a name change for it to "Pages and Templates" to make its purpose clearer. | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
|
|
Martin.. this is probably done.. apart from the same arragement of the master pages area to the document pages area.. eg page border.. not sure what else? |
|
|
The patch changes the following things: - Page preview has a border - Preview mode defaults back to a list without thumbnails - Status (thumbnail / no thumbnail) is saved in the preferences file masterpage_2024-10-21_01.patch (2,557 bytes)
Index: scribus/ui/pagepalette_pages.cpp
===================================================================
--- scribus/ui/pagepalette_pages.cpp (Revision 26360)
+++ scribus/ui/pagepalette_pages.cpp (Arbeitskopie)
@@ -42,14 +42,13 @@
setSizePolicy(QSizePolicy(QSizePolicy::Minimum, QSizePolicy::Expanding));
masterPageList->setMinimumSize(QSize(200, 40));
- masterPageList->m_thumb = true;
masterPageList->setIconSize(QSize(60, 60));
- pageLayout->setHideLabelsPermanently(true);
+ pageLayout->setHideLabelsPermanently(true);
- trash->setMinimumSize(QSize(24, 24));
- trash->setMaximumSize(QSize(24, 24));
-
+ trash->setMinimumSize(QSize(24, 24));
+ trash->setMaximumSize(QSize(24, 24));
+
PageGrid *pageGrid = pageViewWidget->pageGrid();
rebuild();
@@ -336,7 +335,14 @@
: pageName;
if (masterPageList->m_thumb)
{
- pm = QPixmap::fromImage(currView->MPageToPixmap(pageName, 60));
+ pm = QPixmap::fromImage(currView->MPageToPixmap(pageName, masterPageList->iconSize().height()));
+
+ QPainter p(&pm);
+ p.setBrush(Qt::NoBrush);
+ p.setPen(Qt::black);
+ p.drawRect(pm.rect().adjusted(0, 0, -1, -1));
+ p.end();
+
item = new QListWidgetItem(QIcon(pm), pageLabel, masterPageList);
} else
item = new QListWidgetItem(pageLabel, masterPageList);
Index: scribus/ui/pagepalette_widgets.cpp
===================================================================
--- scribus/ui/pagepalette_widgets.cpp (Revision 26360)
+++ scribus/ui/pagepalette_widgets.cpp (Arbeitskopie)
@@ -40,6 +40,10 @@
SeList::SeList(QWidget* parent) : QListWidget(parent)
{
setAcceptDrops(true);
+
+ // Read prefs
+ PrefsContext *prefCollapse = PrefsManager::instance().prefsFile->getContext(m_prefsContext);
+ m_thumb = prefCollapse->getBool(m_prefsName, m_thumb);
}
void SeList::mouseReleaseEvent(QMouseEvent *m)
@@ -62,6 +66,12 @@
void SeList::toggleThumbnail()
{
m_thumb = !m_thumb;
+
+ // write prefs
+ PrefsContext *prefCollapse = PrefsManager::instance().prefsFile->getContext(m_prefsContext);
+ prefCollapse->set(m_prefsName, m_thumb);
+ PrefsManager::instance().prefsFile->write();
+
emit thumbnailChanged();
}
Index: scribus/ui/pagepalette_widgets.h
===================================================================
--- scribus/ui/pagepalette_widgets.h (Revision 26360)
+++ scribus/ui/pagepalette_widgets.h (Arbeitskopie)
@@ -75,6 +75,8 @@
QPoint m_mousePos;
bool m_mousePressed {false};
bool m_thumb {false};
+ QString m_prefsContext = "PagePalette";
+ QString m_prefsName = "showMasterThumbnails";
};
|
|
|
Do you think we should make them the same size? |
|
|
Do you mean the master page thumbnail should match the size of the pages preview? I think we can set a fixed size of 64px instead of 60. |
|
|
Committed with 64, thanks! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2004-04-08 07:12 | malex | New Issue | |
| 2004-04-08 09:44 | cbradney | View Status | @0@ => public |
| 2004-04-08 09:44 | cbradney | Description Updated | |
| 2006-02-06 17:28 | jo-hannes | Relationship added | related to 0000452 |
| 2006-02-06 17:28 | jo-hannes | Relationship added | related to 0000453 |
| 2006-02-06 17:28 | jo-hannes | Status | new => acknowledged |
| 2006-02-06 17:28 | jo-hannes | Product Version | 1.1.6 => 1.3 |
| 2006-05-18 18:57 | christoph_s | Relationship added | related to 0003837 |
| 2024-10-20 18:13 | cbradney | Assigned To | => nitramr |
| 2024-10-20 18:13 | cbradney | Status | acknowledged => assigned |
| 2024-10-20 18:13 | cbradney | Note Added: 0051465 | |
| 2024-10-21 16:54 | nitramr | Note Added: 0051471 | |
| 2024-10-21 16:54 | nitramr | File Added: masterpage_2024-10-21_01.patch | |
| 2024-10-21 18:34 | cbradney | Note Added: 0051472 | |
| 2024-10-21 18:39 | nitramr | Note Added: 0051473 | |
| 2024-10-21 19:39 | cbradney | Note Added: 0051474 | |
| 2024-10-21 19:39 | cbradney | Status | assigned => resolved |
| 2024-10-21 19:39 | cbradney | Resolution | open => fixed |
| 2024-10-21 19:39 | cbradney | Fixed in Version | => 1.7.0.svn |
| 2024-10-23 18:42 | cbradney | Status | resolved => closed |