View Issue Details

IDProjectCategoryView StatusLast Update
0000454ScribusUser Interfacepublic2024-10-23 18:42
Reportermalex Assigned Tonitramr  
PrioritynormalSeveritytweakReproducibilityalways
Status closedResolutionfixed 
Platformi386OSLinuxOS Version2.6
Product Version1.3 
Fixed in Version1.7.0.svn 
Summary0000454: Tools>Page Palette look need to be slightly tweaked and the name changed.
Description1. Make the grey border slightly larger to be consistent with "Layers" dialog.

2. Maybe "Page Palette" name is intuitive to everyone, but me. However, I'd still like to propose a name change for it to "Pages and Templates" to make its purpose clearer.
TagsNo tags attached.
Patch

Relationships

related to 0000452 assignednitramr Tools>Bookmarks look is inconsistent with other dialogs 
related to 0000453 closednitramr Tools>Outline dialog should be made consistent with other dialogs. 
related to 0003837 acknowledged Metabug: Master pages/Page templates 

Activities

cbradney

2024-10-20 18:13

administrator   ~0051465

Martin.. this is probably done.. apart from the same arragement of the master pages area to the document pages area.. eg page border.. not sure what else?

nitramr

2024-10-21 16:54

developer   ~0051471

The patch changes the following things:

- Page preview has a border
- Preview mode defaults back to a list without thumbnails
- Status (thumbnail / no thumbnail) is saved in the preferences file
masterpage_2024-10-21_01.patch (2,557 bytes)   
Index: scribus/ui/pagepalette_pages.cpp
===================================================================
--- scribus/ui/pagepalette_pages.cpp	(Revision 26360)
+++ scribus/ui/pagepalette_pages.cpp	(Arbeitskopie)
@@ -42,14 +42,13 @@
 	setSizePolicy(QSizePolicy(QSizePolicy::Minimum, QSizePolicy::Expanding));
 
 	masterPageList->setMinimumSize(QSize(200, 40));
-	masterPageList->m_thumb = true;
 	masterPageList->setIconSize(QSize(60, 60));
 
-	pageLayout->setHideLabelsPermanently(true);
+	pageLayout->setHideLabelsPermanently(true);
 
-	trash->setMinimumSize(QSize(24, 24));
-	trash->setMaximumSize(QSize(24, 24));
-
+	trash->setMinimumSize(QSize(24, 24));
+	trash->setMaximumSize(QSize(24, 24));
+
 	PageGrid *pageGrid = pageViewWidget->pageGrid();
 
 	rebuild();
@@ -336,7 +335,14 @@
 				: pageName;
 		if (masterPageList->m_thumb)
 		{
-			pm = QPixmap::fromImage(currView->MPageToPixmap(pageName, 60));
+			pm = QPixmap::fromImage(currView->MPageToPixmap(pageName, masterPageList->iconSize().height()));
+
+			QPainter p(&pm);
+			p.setBrush(Qt::NoBrush);
+			p.setPen(Qt::black);
+			p.drawRect(pm.rect().adjusted(0, 0, -1, -1));
+			p.end();
+
 			item = new QListWidgetItem(QIcon(pm), pageLabel, masterPageList);
 		} else
 			item = new QListWidgetItem(pageLabel, masterPageList);
Index: scribus/ui/pagepalette_widgets.cpp
===================================================================
--- scribus/ui/pagepalette_widgets.cpp	(Revision 26360)
+++ scribus/ui/pagepalette_widgets.cpp	(Arbeitskopie)
@@ -40,6 +40,10 @@
 SeList::SeList(QWidget* parent) : QListWidget(parent)
 {
 	setAcceptDrops(true);
+
+	// Read prefs
+	PrefsContext *prefCollapse = PrefsManager::instance().prefsFile->getContext(m_prefsContext);
+	m_thumb = prefCollapse->getBool(m_prefsName, m_thumb);
 }
 
 void SeList::mouseReleaseEvent(QMouseEvent *m)
@@ -62,6 +66,12 @@
 void SeList::toggleThumbnail()
 {
 	m_thumb = !m_thumb;
+
+	// write prefs
+	PrefsContext *prefCollapse = PrefsManager::instance().prefsFile->getContext(m_prefsContext);
+	prefCollapse->set(m_prefsName, m_thumb);
+	PrefsManager::instance().prefsFile->write();
+
 	emit thumbnailChanged();
 }
 
Index: scribus/ui/pagepalette_widgets.h
===================================================================
--- scribus/ui/pagepalette_widgets.h	(Revision 26360)
+++ scribus/ui/pagepalette_widgets.h	(Arbeitskopie)
@@ -75,6 +75,8 @@
 	QPoint m_mousePos;
 	bool m_mousePressed {false};
 	bool m_thumb {false};
+	QString m_prefsContext = "PagePalette";
+	QString m_prefsName = "showMasterThumbnails";
 
 };
 
masterpage_2024-10-21_01.patch (2,557 bytes)   

cbradney

2024-10-21 18:34

administrator   ~0051472

Do you think we should make them the same size?

nitramr

2024-10-21 18:39

developer   ~0051473

Do you mean the master page thumbnail should match the size of the pages preview? I think we can set a fixed size of 64px instead of 60.

cbradney

2024-10-21 19:39

administrator   ~0051474

Committed with 64, thanks!

Issue History

Date Modified Username Field Change
2004-04-08 07:12 malex New Issue
2004-04-08 09:44 cbradney View Status @0@ => public
2004-04-08 09:44 cbradney Description Updated
2006-02-06 17:28 jo-hannes Relationship added related to 0000452
2006-02-06 17:28 jo-hannes Relationship added related to 0000453
2006-02-06 17:28 jo-hannes Status new => acknowledged
2006-02-06 17:28 jo-hannes Product Version 1.1.6 => 1.3
2006-05-18 18:57 christoph_s Relationship added related to 0003837
2024-10-20 18:13 cbradney Assigned To => nitramr
2024-10-20 18:13 cbradney Status acknowledged => assigned
2024-10-20 18:13 cbradney Note Added: 0051465
2024-10-21 16:54 nitramr Note Added: 0051471
2024-10-21 16:54 nitramr File Added: masterpage_2024-10-21_01.patch
2024-10-21 18:34 cbradney Note Added: 0051472
2024-10-21 18:39 nitramr Note Added: 0051473
2024-10-21 19:39 cbradney Note Added: 0051474
2024-10-21 19:39 cbradney Status assigned => resolved
2024-10-21 19:39 cbradney Resolution open => fixed
2024-10-21 19:39 cbradney Fixed in Version => 1.7.0.svn
2024-10-23 18:42 cbradney Status resolved => closed