View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006991 | Scribus | Story Editor / Text Frames | public | 2008-05-01 16:16 | 2008-09-22 21:34 |
| Reporter | florian | Assigned To | jghali | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Intel 32-bit | OS | Linux | OS Version | openSuSE 10.3 |
| Product Version | 1.3.5svn | ||||
| Target Version | 1.3.5 | Fixed in Version | 1.3.5svn | ||
| Summary | 0006991: "Text overflow" warning when there is a text underflow in fact | ||||
| Description | The preflight verifier shows a warning "text overflow" in the case of two linked text frames, when the second text frame is empty due to few text | ||||
| Steps To Reproduce | 1) Create two text frames (large enough for some lines of text) and link them 2) Choose Menu-Edit-Edit Text... (Ctrl+Y) to type a word or two 3) The first text frame contains the typed word and some empty space, the second text frame does not display any text. The preflight verifier shows a warning "text overflow" and the second text frame shows a corresponding crossed square at its bottom-right corner. | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
|
2008-07-22 22:51
|
6991_text_overflow.patch (562 bytes)
Index: scribus/pageitem.cpp
===================================================================
--- scribus/pageitem.cpp (revision 12410)
+++ scribus/pageitem.cpp (working copy)
@@ -666,7 +666,8 @@
bool PageItem::frameOverflows() const
{
#ifndef NLS_PROTO
- return NextBox == NULL && itemText.length() > static_cast<int>(MaxChars);
+ return NextBox == NULL && (static_cast<int>(firstChar) < itemText.length()) && (static_cast<int>(firstChar) < MaxChars)
+ && (itemText.length() > static_cast<int>(MaxChars));
#else
return false; // FIXME:NLS
#endif
|
|
|
I've got a patch which seems to work. Just uploaded it. Please test! |
|
|
Patch now committed |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-05-01 16:16 | florian | New Issue | |
| 2008-05-01 16:23 | jghali | Relationship added | has duplicate 0006164 |
| 2008-05-01 16:23 | jghali | Target Version | => 1.3.5 |
| 2008-07-22 22:51 | jghali | File Added: 6991_text_overflow.patch | |
| 2008-07-22 22:52 | jghali | Note Added: 0020021 | |
| 2008-07-23 22:02 | jghali | Note Added: 0020025 | |
| 2008-07-23 22:02 | jghali | Status | new => resolved |
| 2008-07-23 22:02 | jghali | Fixed in Version | => 1.3.5svn |
| 2008-07-23 22:02 | jghali | Resolution | open => fixed |
| 2008-07-23 22:02 | jghali | Assigned To | => jghali |
| 2008-09-22 21:34 | cbradney | Status | resolved => closed |
| 2015-09-17 20:08 | Kunda | Category | Story Editor / Text Frames => Story Ed/Txt Frames |
| 2015-09-17 20:12 | Kunda | Category | Story Ed/Txt Frames => Story Editor / Text Frames |
