View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0007933 | Scribus | Story Editor / Text Frames | public | 2009-04-11 16:55 | 2009-11-03 03:45 |
Reporter | mecirt | Assigned To | jghali | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86-64 | OS | linux | ||
Product Version | 1.3.5svn | ||||
Target Version | 1.3.6 | Fixed in Version | 1.3.6svn | ||
Summary | 0007933: Switching between text frames non-intuitive (patch attached) | ||||
Description | Currently, switching between different text frames is rather non-intuitive. When one is in edit mode and clicks on another text frame, scribus leaves edit mode and merely selects the new frame. A double-click is necessary to move to the new frame. I am attaching a patch that resolves this problem - if one is in edit mode and clicks on another textframe, scribus does not leave edit mode and positions the cursor correctly within the new frame. | ||||
Tags | No tags attached. | ||||
Patch | |||||
2009-04-11 16:55
|
scribus-textframe-switching.patch (1,052 bytes)
Index: scribus/canvasmode_edit.cpp =================================================================== --- scribus/canvasmode_edit.cpp (revision 13359) +++ scribus/canvasmode_edit.cpp (working copy) @@ -961,25 +961,29 @@ else if (resizeGesture->frameHandle() < 0) { m_view->Deselect(true); + bool wantNormal = true; if (SeleItem(m)) { currItem = m_doc->m_Selection->itemAt(0); if ((currItem->asTextFrame()) || (currItem->asImageFrame())) { m_view->requestMode(modeEdit); + wantNormal = false; } else { m_view->requestMode(submodePaintingDone); qApp->changeOverrideCursor(QCursor(Qt::ArrowCursor)); } + if (currItem->asTextFrame()) + m_view->slotSetCurs(m->globalPos().x(), m->globalPos().y()); } else { m_view->requestMode(submodePaintingDone); qApp->changeOverrideCursor(QCursor(Qt::ArrowCursor)); } - m_view->requestMode(modeNormal); + if (wantNormal) m_view->requestMode(modeNormal); return; } } |
|
great, that would solve http://bugs.scribus.net/view.php?id=6265 |
|
We want to have a separate select tool, post 1.3.5.. I am not sure that we would wna to confuse this issue by adding this now. |
|
Sorry for the delay, patch has now been committed to both 1.3.6svn and trunk. |
|
Tested, fixed. Thanks! |
Date Modified | Username | Field | Change |
---|---|---|---|
2009-04-11 16:55 | mecirt | New Issue | |
2009-04-11 16:55 | mecirt | File Added: scribus-textframe-switching.patch | |
2009-04-11 20:53 | JLuc | Note Added: 0021520 | |
2009-04-13 21:50 | cbradney | Note Added: 0021526 | |
2009-04-13 22:22 | cbradney | Relationship added | related to 0006265 |
2009-10-04 21:57 | cbradney | Target Version | => 1.3.6 |
2009-11-02 23:25 | jghali | Note Added: 0022785 | |
2009-11-02 23:25 | jghali | Status | new => resolved |
2009-11-02 23:25 | jghali | Fixed in Version | => 1.3.6svn |
2009-11-02 23:25 | jghali | Resolution | open => fixed |
2009-11-02 23:25 | jghali | Assigned To | => jghali |
2009-11-03 03:45 | christoph_s | Note Added: 0022788 | |
2009-11-03 03:45 | christoph_s | Status | resolved => closed |
2015-09-17 20:08 | Kunda | Category | Story Editor / Text Frames => Story Ed/Txt Frames |
2015-09-17 20:12 | Kunda | Category | Story Ed/Txt Frames => Story Editor / Text Frames |