View Issue Details

IDProjectCategoryView StatusLast Update
0010174ScribusGeneralpublic2011-10-05 20:03
Reporterale Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.4.0 
Fixed in Version1.4.0svn 
Summary0010174: the return of the brownish color
Descriptionwhen changing language, a brown color gets created and is set as the default color.

on top of it, the text frames get a 1px black border as the default.

i had it with two different RC5...
(well one was on a file i got from apoage...)

other people have confirmed it on the mailing list...
TagsNo tags attached.
Patch

Activities

jghali

2011-08-12 07:03

administrator   ~0026709

Cannot reproduce.

ale

2011-09-28 09:59

manager   ~0026918

it's still there.

- remove ~/.scribus
- launch scribus
- create a document
- change the language to afrikaans
- create a text frame
- close the document without saving
- create a new document
- change back to no language (english)
- close the document
- create a new document
- create a text frame
- ta daaaa! an awful brownish background!

and: no chance to get ridd of it without nuking the settings.

jghali

2011-09-28 11:27

administrator   ~0026921

Still unable to reproduce...

ale

2011-09-28 15:03

manager   ~0026923

jiero was having this issue with 1.4RC5 this morning on ubuntu (well, probably this evening for him...).

i'm seeing it on debian and on windows i get in 1.3.9 and (after removing the preferences and updating) in 1.4RC5.

you may have to restart scribus after having reverted the language to none.

joan

2011-09-28 17:32

reporter   ~0026924

i'm having it too with 1.4RC5 on ubuntu

joan

2011-09-29 16:55

reporter   ~0026926

@jghali : maybe it only happens if the base locale is not english

@developpers :
this bug is even more easy to reproduce :
- Open preferences
- Change language to Afrikaans and apply
- Go to the tool tab in preferences and you'll see the brown background.

The problem come from translations. roughly, the color "None" is translated "Geen" in Afrikaans. but in the function updatePreferences the background color is filled with the background color in the combobox of preferences tool tab that is not already translated.

the problem can quickly be solved by implementing the virtual void languageChange() in Preferences.cpp and translate all the combo boxes.

but i think it would be better to translate all the preferences when language is changed and applied. right now it translate some buttons but all the rest stay in the old language.

i would be happy to make those changes but if someone is already working on it, i don't want to make it double. so tell me if you want me to work on it.

bubu

2011-09-29 19:51

reporter   ~0026927

Hm, this is similar to 0009530, 0009267.

jghali

2011-09-29 20:51

administrator   ~0026928

Last edited: 2011-09-29 20:56

Found how to reproduce reliably this morning.

Joan, the solution to thss specific bug is to implement languageChange() in ColorListBox, not in Preferences.cpp. Have patch almost ready...

ale

2011-09-30 09:00

manager   ~0026929

looks good now!

thanks!

joan

2011-10-01 12:20

reporter   ~0026935

jghali, i think you'll have to translate the tool tab -> background color combobox (and others) or the background value read in updatePreferences will still be with old translation and the compare will not match.

do we open a bug report for translating all the preference dialog when language is changed and applied?

jghali

2011-10-01 14:01

administrator   ~0026936

>> jghali, i think you'll have to translate the tool tab -> background color combobox (and others) or the background value read in updatePreferences will still be with old translation and the compare will not match.

This is exactly what my patch does. There is no need to make any change in the colorcombo widget itself as it depends on colorlistbox for displaying the color list.

>> do we open a bug report for translating all the preference dialog when language is changed and applied?

No because the specific language setting must not change before preference dialog is closed. Triggers in fact other problems not limited to that one. In 150svn language change is effectively applied only when closing dialog.

joan

2011-10-01 22:48

reporter   ~0026942

good!

Issue History

Date Modified Username Field Change
2011-08-12 06:53 ale New Issue
2011-08-12 07:03 jghali Note Added: 0026709
2011-09-28 09:59 ale Note Added: 0026918
2011-09-28 11:27 jghali Note Added: 0026921
2011-09-28 15:03 ale Note Added: 0026923
2011-09-28 17:32 joan Note Added: 0026924
2011-09-29 16:55 joan Note Added: 0026926
2011-09-29 19:51 bubu Note Added: 0026927
2011-09-29 20:51 jghali Note Added: 0026928
2011-09-29 20:56 jghali Note Edited: 0026928
2011-09-29 21:54 jghali Status new => resolved
2011-09-29 21:54 jghali Fixed in Version => 1.4.0svn
2011-09-29 21:54 jghali Resolution open => fixed
2011-09-29 21:54 jghali Assigned To => jghali
2011-09-30 09:00 ale Note Added: 0026929
2011-10-01 12:20 joan Note Added: 0026935
2011-10-01 14:01 jghali Note Added: 0026936
2011-10-01 22:48 joan Note Added: 0026942
2011-10-05 20:03 cbradney Status resolved => closed