View Issue Details

IDProjectCategoryView StatusLast Update
0012851ScribusText Frames / Story Editorpublic2017-04-19 11:49
ReporterJehan Assigned To 
PriorityhighSeverityminorReproducibilityalways
Status confirmedResolutionopen 
Product Version1.5.0svn 
Target Version1.5.4 
Summary0012851: User-defined 1-key shortcuts called when writing in text frame
DescriptionAs there are no shortcuts for importing a vector file, and the 'v' key is not taken by any shortcut, I decided to set it this way.

But when writing in a text frame, and pressing 'v', instead of writing the expected 'v' in the frame, it triggers the "Open" dialog for a vector file. This should not happen, and shortcuts which outputs printable characters should be disabled when in a text frame.

For instance, when pressing 'i' (image frame) or 't' (text frame), the associated shortcuts are not triggered when in a text frame (you have to get out of it first, which is a really acceptable compromise to the simplicity of 1-key shortcuts). This should be the same for user-defined shortcuts.
Steps To Reproduce1/ In "File" > "Preferences" > "Keyboard shortcuts", Set Key 'v' to "File > Get Vector File" action.

2/ create a text frame, and go in "Edit Contents in Frame" mode.

3/ Type a 'v' (there can be any text before, it does not matter).

Result: the shortcut is triggered.
Expected result: the letter 'v' should be inserted into the text frame at current cursor position.
Additional InformationTested on both Scribus 1.4.3.svn and 1.5.0.svn. Same issue everywhere.
Tagsshortcuts, workflow
Attached Files
0001-Disable-fileImportVector-in-edit-mode.patch (763 bytes)   
From 94b3d9614dbd4d404d7962a9e588d060792314bc Mon Sep 17 00:00:00 2001
From: Juraj Fedel <wtxnh-scribus@yahoo.com.au>
Date: Wed, 4 May 2016 14:29:17 +0200
Subject: [PATCH] Disable fileImportVector in edit mode

---
 scribus/actionmanager.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scribus/actionmanager.cpp b/scribus/actionmanager.cpp
index e98de86..cdd158e 100644
--- a/scribus/actionmanager.cpp
+++ b/scribus/actionmanager.cpp
@@ -204,6 +204,7 @@ void ActionManager::initFileMenuActions()
 	connect( (*scrActions)["fileExportAsPDF"], SIGNAL(triggered()), mainWindow, SLOT(SaveAsPDF()) );
 	//The rest are plugins
 	
+	*nonEditActionNames << "fileImportVector";
 	
 	(*scrActions)["fileClose"]->setShortcutContext(Qt::WidgetShortcut);
 }
-- 
2.1.4

PatchYes

Relationships

related to 0008401 assignedjghali Select color by keys triggers toolbar shortcuts 
related to 0010503 new key short cuts for nudging frames don't match. 
related to 0009749 new add a keyboard shortcut for importing a vector file 

Activities

Kunda

2015-05-15 01:40

updater   ~0035131

I can't get the shortcut to work outside (or inside of text frame, which doesn't make sense).

1) setup shortcut for Get Vector as V
2) type V on canvas
Result: nothing

1.5svn r20083

Jehan

2015-05-15 09:33

reporter   ~0035132

I did at the time I wrote this bug report. I'll test again on updated svn code, if you want. In any case, one or the other, this is not the expected result. :-)

FirasH

2015-05-15 13:49

reporter   ~0035139

This happens with other shortcuts too while editing Text Frame content on canvas.

FirasH

2015-05-15 18:31

reporter   ~0035144

A possible solution could be disabling shortcuts with single character/key or Shift+single character/key (capital letters) while in modeEdit and only allow Ctrl/Alt or any other modifier defined shortcut.

Kunda

2016-04-19 19:57

updater   ~0040315

This just started to occur for me after updating to r21215
1) open text frame in edit mode
2) type 'v'
Result: Open Vector file dialog

Kunda

2016-04-24 01:29

updater   ~0040419

MrB, can you recreate this ?

Kunda

2016-04-24 01:30

updater   ~0040420

utnik,
MrB made a 1.5.2svn nightly recently at https://sourceforge.net/projects/scribus/files/scribus-svn/1.5.2.svn/Scribus15xNightly-160420.dmg
Can you test ?

plinnell

2016-04-24 04:17

viewer   ~0040425

Defintely there. Only happens in a text frame when in edit mode. Not in the text editor.

Kunda

2016-04-24 12:58

updater   ~0040437

Related: 0008401

Laser

2016-04-24 21:06

reporter   ~0040451

Last edited: 2016-04-24 21:09

V is not a default shortcut in r21240.
But if you define it as get vector file, you cannot type v in text frame.
Like ctrl + I there should be a separation between senseful and senseless commands - at ctrl + I you get in a text frame only text files to choose as supported, in an image frame only image files.
So "get vector file" should be disabled at all frames but images ;-)

Kunda

2016-04-30 22:41

updater   ~0040653

I've disabled 'v' as a shortcut for Open Vector Dialog and the issue ceases. This isn't an ideal workaround :(

Kunda

2016-04-30 22:42

updater   ~0040654

See: 0009749

jurajF

2016-05-04 13:09

reporter   ~0040766

uploaded 0001-Disable-fileImportVector-in-edit-mode.patch will disable Import Vector dialog to appear in edit mode. It does not solve bigger problem with single key shortcut.

Issue History

Date Modified Username Field Change
2014-12-14 22:39 Jehan New Issue
2015-05-15 01:40 Kunda Note Added: 0035131
2015-05-15 09:33 Jehan Note Added: 0035132
2015-05-15 13:49 FirasH Note Added: 0035139
2015-05-15 13:49 FirasH Status new => confirmed
2015-05-15 14:01 Kunda Priority normal => high
2015-05-15 14:01 Kunda Target Version => 1.5.1
2015-05-15 18:31 FirasH Note Added: 0035144
2015-09-17 20:08 Kunda Category Story Editor / Text Frames => Story Ed/Txt Frames
2015-09-17 20:12 Kunda Category Story Ed/Txt Frames => Story Editor / Text Frames
2015-10-27 16:38 Kunda Relationship added related to 0008401
2015-10-27 16:39 Kunda Tag Attached: MABs
2016-01-23 17:16 cbradney Target Version 1.5.1 => 1.5.3
2016-02-02 12:45 Kunda Tag Attached: shortcuts
2016-04-19 19:57 Kunda Note Added: 0040315
2016-04-19 19:57 Kunda Relationship added related to 0010503
2016-04-24 01:29 Kunda Note Added: 0040419
2016-04-24 01:30 Kunda Note Added: 0040420
2016-04-24 01:34 Kunda Relationship added related to 0009749
2016-04-24 04:17 plinnell Note Added: 0040425
2016-04-24 12:58 Kunda Note Added: 0040437
2016-04-24 21:06 Laser Note Added: 0040451
2016-04-24 21:09 Laser Note Edited: 0040451
2016-04-30 22:41 Kunda Note Added: 0040653
2016-04-30 22:42 Kunda Tag Attached: workflow
2016-04-30 22:42 Kunda Note Added: 0040654
2016-05-04 13:07 jurajF File Added: 0001-Disable-fileImportVector-in-edit-mode.patch
2016-05-04 13:09 jurajF Note Added: 0040766
2016-05-04 13:54 Kunda Patch No => Yes
2016-12-08 22:04 Kunda Target Version 1.5.3 => 1.5.4
2017-04-19 11:49 JLuc Tag Detached: MABs
2025-04-27 19:16 cbradney Category Story Editor / Text Frames => Text Frames / Story Editor