View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0012892 | Scribus | Usability | public | 2015-01-16 14:44 | 2024-09-16 20:54 |
Reporter | PeterBenedek | Assigned To | nitramr | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | x86 | OS | Linux Mint | OS Version | 17 (32bit) |
Product Version | 1.5.0svn | ||||
Target Version | 1.7.0 | Fixed in Version | 1.6.3.svn | ||
Summary | 0012892: Color Management: Color Menu width increases with each use of Color Management feature | ||||
Description | Link this video: https://www.dropbox.com/s/5rc0r4txwsgcjxs/Sample.avi?dl=0 In use, the color selector width increases. | ||||
Steps To Reproduce | 1) Open new document 2) Make Text Frame 3) Insert text in Text Frame 4) Turn On or Off the "Toggle Color Managment System" switch 5) Select (Open): Properties -- Text -- Color&Effect -- Color Selector 6) Look the width 7) Goto 4 | ||||
Tags | No tags attached. | ||||
Patch | Yes | ||||
has duplicate | 0014163 | closed | PeterBenedek | Font Color Menu in Properties Palette Keeps Growing |
has duplicate | 0016789 | closed | Unable to change colour of text after several times of usage the item | |
has duplicate | 0017236 | closed | Much too wide dropdown color select menu |
|
Can reproduce on 1.5svn r19768 with just activating a text box (without text) All you need to do is toggle the 'Color Management' button on/off (2 clicks) for 5-6 iterations to visually confirm this bug. 1) Open new document 2) Make Text Frame 3) Activate and disable "Toggle Color Managment System" switch a dozen times 4) Select (Open): Properties -- Text -- Color&Effect -- Color Selector 5) Look at the width |
|
|
|
1) Open new document (TAB 1) 2) Make Text Frame 3) Open new document (TAB 2) 4) switching TAB 1 and TAB 2 (10×) 5) Select (Open): Properties -- Text -- Color&Effect -- Color Selector 6) Look at the width |
|
0016789 also concludes « After several times of doing so, the checkbox is growing wider and wider until it reaches the left border of the screen. When reaching it, it is impossible to change the color anymore. I’m running an iMac mini (Silicon). When I restart the Program the sequence starts again. » |
|
Still happens in 1.6.2 , leading to screen-width dropdown |
|
Fixed! On each color list update request, the list width increase by 24 pixels. I removed that logic and add a normal size policy to the list to fill the combo box dropdown container. colorcombo_2024-07-01_01.patch (6,611 bytes)
Index: scribus/ui/colorcombo.cpp =================================================================== --- scribus/ui/colorcombo.cpp (Revision 26191) +++ scribus/ui/colorcombo.cpp (Arbeitskopie) @@ -15,14 +15,7 @@ #include "commonstrings.h" // #include "qdebug.h" -ColorCombo::ColorCombo(QWidget* parent) : QComboBox(parent) -{ - setEditable(false); - ColorListBox* lb = new ColorListBox(this); - setModel( lb->model() ); - setItemDelegate( lb->itemDelegate() ); - setView( lb ); -} +ColorCombo::ColorCombo(QWidget* parent) : ColorCombo(false, parent) {} ColorCombo::ColorCombo(ColorCombo::PixmapType type, QWidget* parent) : QComboBox(parent) { @@ -36,6 +29,7 @@ setModel( lb->model() ); setItemDelegate( lb->itemDelegate() ); setView( lb ); + view()->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Minimum); } ColorCombo::ColorCombo(bool rw, QWidget* parent) : QComboBox(parent) @@ -45,6 +39,7 @@ setModel( lb->model() ); setItemDelegate( lb->itemDelegate() ); setView( lb ); + view()->setSizePolicy(QSizePolicy::MinimumExpanding, QSizePolicy::Minimum); } Index: scribus/ui/colorlistbox.cpp =================================================================== --- scribus/ui/colorlistbox.cpp (Revision 26191) +++ scribus/ui/colorlistbox.cpp (Arbeitskopie) @@ -175,22 +175,8 @@ int ColorListBox::initialized; int ColorListBox::sortRule; -ColorListBox::ColorListBox(QWidget * parent) - : QListView(parent) -{ - if (initialized != 12345) - sortRule = 0; - initialized = 12345; - QListView::setModel(new ColorListModel(this)); - setPixmapType(ColorListBox::widePixmap); +ColorListBox::ColorListBox(QWidget * parent) : ColorListBox(ColorListBox::widePixmap, parent) {} - connect(this, SIGNAL(clicked(QModelIndex)), this, SLOT(emitItemClicked(QModelIndex))); - connect(this, SIGNAL(doubleClicked(QModelIndex)), this, SLOT(emitItemDoubleClicked(QModelIndex))); - connect(this->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), this, SLOT(emitCurrentChanged(QModelIndex,QModelIndex))); - connect(this->selectionModel(), SIGNAL(selectionChanged(QItemSelection,QItemSelection)), this, SIGNAL(itemSelectionChanged())); - connect(this, SIGNAL(contextMenuRequested()), this, SLOT(slotRightClick())); -} - ColorListBox::ColorListBox(ColorListBox::PixmapType type, QWidget * parent) : QListView(parent) { Index: scribus/ui/propertywidget_textcolor.cpp =================================================================== --- scribus/ui/propertywidget_textcolor.cpp (Revision 26191) +++ scribus/ui/propertywidget_textcolor.cpp (Arbeitskopie) @@ -196,9 +196,6 @@ fillColor->setColors(m_doc->PageColors, true); strokeColor->setColors(m_doc->PageColors, false); backColor->setColors(m_doc->PageColors, true); - fillColor->view()->setMinimumWidth(fillColor->view()->maximumViewportSize().width() + 24); - strokeColor->view()->setMinimumWidth(strokeColor->view()->maximumViewportSize().width() + 24); - backColor->view()->setMinimumWidth(backColor->view()->maximumViewportSize().width() + 24); if (m_item) setCurrentItem(m_item); Index: scribus/ui/search.cpp =================================================================== --- scribus/ui/search.cpp (Revision 26191) +++ scribus/ui/search.cpp (Arbeitskopie) @@ -147,7 +147,6 @@ searchStrokeValue->setEditable(false); searchStrokeValue->setPixmapType(ColorCombo::fancyPixmaps); searchStrokeValue->setColors(doc->PageColors, true); - searchStrokeValue->view()->setMinimumWidth(searchStrokeValue->view()->maximumViewportSize().width() + 24); setCurrentComboItem(searchStrokeValue, doc->currentStyle.charStyle().strokeColor()); searchStrokeValue->setEnabled(false); SearchLayout->addWidget( searchStrokeValue, 8, 1 ); @@ -233,7 +232,6 @@ replaceFillValue->setEditable(false); replaceFillValue->setPixmapType(ColorCombo::fancyPixmaps); replaceFillValue->setColors(doc->PageColors, true); - replaceFillValue->view()->setMinimumWidth(replaceFillValue->view()->maximumViewportSize().width() + 24); setCurrentComboItem(replaceFillValue, doc->currentStyle.charStyle().fillColor()); replaceFillValue->setEnabled(false); ReplaceLayout->addWidget( replaceFillValue, 6, 1 ); @@ -244,7 +242,6 @@ replaceStrokeValue->setEditable(false); replaceStrokeValue->setPixmapType(ColorCombo::fancyPixmaps); replaceStrokeValue->setColors(doc->PageColors, true); - replaceStrokeValue->view()->setMinimumWidth(replaceStrokeValue->view()->maximumViewportSize().width() + 24); setCurrentComboItem(replaceStrokeValue, doc->currentStyle.charStyle().strokeColor()); replaceStrokeValue->setEnabled(false); ReplaceLayout->addWidget( replaceStrokeValue, 8, 1 ); Index: scribus/ui/smcellstylewidget.cpp =================================================================== --- scribus/ui/smcellstylewidget.cpp (Revision 26191) +++ scribus/ui/smcellstylewidget.cpp (Arbeitskopie) @@ -173,5 +173,4 @@ fillColor->clear(); fillColor->setColors(colors, true); - fillColor->view()->setMinimumWidth(fillColor->view()->maximumViewportSize().width()+24); } Index: scribus/ui/smcstylewidget.cpp =================================================================== --- scribus/ui/smcstylewidget.cpp (Revision 26191) +++ scribus/ui/smcstylewidget.cpp (Arbeitskopie) @@ -167,9 +167,6 @@ fillColor_->setColors(colors, true); strokeColor_->setColors(colors, true); backColor_->setColors(colors, true); - fillColor_->view()->setMinimumWidth(fillColor_->view()->maximumViewportSize().width()+24); - strokeColor_->view()->setMinimumWidth(strokeColor_->view()->maximumViewportSize().width()+24); - backColor_->view()->setMinimumWidth(backColor_->view()->maximumViewportSize().width()+24); } void SMCStyleWidget::handleUpdateRequest(int updateFlags) Index: scribus/ui/smpstylewidget.cpp =================================================================== --- scribus/ui/smpstylewidget.cpp (Revision 26191) +++ scribus/ui/smpstylewidget.cpp (Arbeitskopie) @@ -185,7 +185,6 @@ { backColor_->clear(); backColor_->setColors(colors, true); - backColor_->view()->setMinimumWidth(backColor_->view()->maximumViewportSize().width()+24); } void SMPStyleWidget::fillBulletStrEditCombo() Index: scribus/ui/smtablestylewidget.cpp =================================================================== --- scribus/ui/smtablestylewidget.cpp (Revision 26191) +++ scribus/ui/smtablestylewidget.cpp (Arbeitskopie) @@ -170,7 +170,6 @@ fillColor->clear(); fillColor->setColors(colors, true); - fillColor->view()->setMinimumWidth(fillColor->view()->maximumViewportSize().width()+24); } |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-01-16 14:44 | PeterBenedek | New Issue | |
2015-01-24 12:19 | Kunda | Note Added: 0034384 | |
2015-01-24 12:19 | Kunda | Status | new => confirmed |
2015-01-24 12:19 | Kunda | Target Version | => 1.5.1 |
2015-01-24 12:19 | Kunda | Summary | Color select width increases => Color Management Bug: Color Menu width increases with each use of Color Management feature |
2015-01-24 12:19 | Kunda | Steps to Reproduce Updated | |
2015-01-26 15:11 | Kunda | Note Edited: 0034384 | |
2015-02-02 00:27 | Kunda | Summary | Color Management Bug: Color Menu width increases with each use of Color Management feature => Color Management: Color Menu width increases with each use of Color Management feature |
2016-01-23 17:16 | cbradney | Target Version | 1.5.1 => 1.5.3 |
2016-06-19 05:52 | PeterBenedek | Relationship added | duplicate of 0014163 |
2016-06-19 05:57 | PeterBenedek | Relationship deleted | 0014163 |
2016-06-19 05:57 | PeterBenedek | Relationship added | has duplicate 0014163 |
2016-06-21 07:40 | PeterBenedek | File Added: 0012892.gif | |
2016-06-21 07:45 | PeterBenedek | Note Added: 0041697 | |
2016-06-21 07:46 | PeterBenedek | Note Edited: 0041697 | |
2016-12-08 22:04 | Kunda | Target Version | 1.5.3 => 1.5.4 |
2022-05-07 14:49 | PeterBenedek | Relationship added | related to 0016789 |
2022-05-09 17:01 | JLuc | Relationship replaced | has duplicate 0016789 |
2022-05-09 17:03 | JLuc | Note Added: 0049640 | |
2024-06-25 15:06 | PeterBenedek | Relationship added | has duplicate 0017236 |
2024-06-26 06:47 | JLuc | Note Added: 0051228 | |
2024-07-01 18:36 | nitramr | Assigned To | => nitramr |
2024-07-01 18:36 | nitramr | Status | confirmed => assigned |
2024-07-01 18:38 | nitramr | Note Added: 0051230 | |
2024-07-01 18:38 | nitramr | File Added: colorcombo_2024-07-01_01.patch | |
2024-07-01 18:40 | nitramr | Status | assigned => resolved |
2024-07-01 18:40 | nitramr | Resolution | open => fixed |
2024-07-01 18:51 | nitramr | Patch | No => Yes |
2024-07-08 13:03 | nitramr | Target Version | 1.5.4 => 1.7.0 |
2024-07-10 21:26 | cbradney | Fixed in Version | => 1.6.3.svn |
2024-09-16 20:54 | cbradney | Status | resolved => closed |