View Issue Details

IDProjectCategoryView StatusLast Update
0013401ScribusUsabilitypublic2015-11-03 15:28
ReporterJLuc Assigned Tocbradney  
Status closedResolutionfixed 
PlatformLinuxOSUbuntuOS Version14.04
Product Version1.5.1svn 
Fixed in Version1.5.1svn 
Summary0013401: [PATCH] Save CTRL+S is broken when in Masterpage Edit mode
DescriptionWhen in masterpage edit mode, no Save Document is possible using CTRL+S

File > Save is active and works well.
Only the CTRL+S shortcut is broken and does nothing nor issues any warning message.

There is a risk that the user believes the saving has been done properly and later looses its work.


related to 0012478 closed Notifying that Scribus is in Master Page mode if attempting to close Scribus 
related to 0003837 acknowledged Metabug: Master pages/Page templates 



2015-10-26 10:28

reporter   ~0036944

Last edited: 2015-10-26 10:30

As I have tested, even when we are in masterpage edit mode, File > Save is not active. So only we can save work after going back to Normal Page Mode.

I will try to fix it.


2015-10-27 08:20


issue13401.patch (534 bytes)   
Index: scribus/appmodehelper.cpp
--- scribus/appmodehelper.cpp	(revision 20478)
+++ scribus/appmodehelper.cpp	(working copy)
@@ -1248,7 +1248,6 @@
-	(*a_scrActions)["fileSave"]->setEnabled(b2);
 	if (b2)
issue13401.patch (534 bytes)   


2015-10-27 08:21

reporter   ~0036973

I upload patch file that fix the problem.
Now, during pagemaster edit mode you can save changes using File > save or press CTRL + S.

I did this by remove one line from appmodehelper.cpp file which was disable the (save) event in pagemaster edit mode.


2015-10-29 12:08

updater   ~0037094

Last edited: 2015-10-29 12:09

shamsa, I wonder what the repercussions are for doing that ? Why did the programmer working on this issue intentionally disable to the save event ? What was their rationale ?


2015-10-29 12:20

manager   ~0037096

imo, it should be possible to save while in master page editing mode.

if there are bugs related to it, they should be solved...


2015-11-01 05:20

reporter   ~0037140

I don't think there is important reason for making it disabled. Because already (save as) is enabled which can be used by user but it need to change document name or replace old one!

I think it is important to make sure your data is saved before going to normal mode.


2015-11-03 01:06

updater   ~0037161

Can confirm that it's possible to save while in MasterPage mode but I haven't done extensive testing to try to break it.

Fix was committed in r20516 by Craig
Patched by shamsa, Thanks!


2015-11-03 15:28

updater   ~0037188


Issue History

Date Modified Username Field Change
2015-10-08 13:12 JLuc New Issue
2015-10-26 10:28 shamsa Note Added: 0036944
2015-10-26 10:30 shamsa Note Edited: 0036944
2015-10-26 20:08 Kunda Relationship added related to 0012478
2015-10-26 20:08 Kunda Relationship added related to 0003837
2015-10-27 08:20 shamsa File Added: issue13401.patch
2015-10-27 08:21 shamsa Note Added: 0036973
2015-10-29 10:15 shamsa Tag Attached: HOST-Oman
2015-10-29 10:47 ale Summary Save CTRL+S is broken when in Masterpage Edit mode => [PATCH] Save CTRL+S is broken when in Masterpage Edit mode
2015-10-29 12:08 Kunda Note Added: 0037094
2015-10-29 12:09 Kunda Note Edited: 0037094
2015-10-29 12:20 ale Note Added: 0037096
2015-11-01 05:20 shamsa Note Added: 0037140
2015-11-02 11:31 cbradney Status new => resolved
2015-11-02 11:31 cbradney Fixed in Version => 1.5.1svn
2015-11-02 11:31 cbradney Resolution open => fixed
2015-11-02 11:31 cbradney Assigned To => cbradney
2015-11-03 01:06 Kunda Note Added: 0037161
2015-11-03 15:28 Kunda Note Added: 0037188
2015-11-03 15:28 Kunda Status resolved => closed