View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0014103ScribusProperties Palettepublic2016-05-27 08:082016-05-28 05:14
ReporterLaserAssigned ToFirasH  
PrioritylowSeveritytweakReproducibilityalways
Status closedResolutionfixed 
PlatformPCOSArchlinuxOS Versionuptodate
Product Version1.5.3.svn 
Fixed in Version1.5.3.svn 
Summary0014103: PP - Table isn't translated when changing language in Preferences
DescriptionThe Tab Table always keeps the language which is used when opening Scribus.
So if I open German Scribus and change Preferences - English, the tab stays German. And vice versa.
TagsNo tags attached.
PatchYes

Relationships

child of 0005002 acknowledged Metabug - 1.5 Non-switching translations 

Activities

Laser

2016-05-27 08:08

reporter  

PP-table.png (16,542 bytes)   
PP-table.png (16,542 bytes)   

FirasH

2016-05-27 09:40

reporter   ~0041473

Fixed with attached patch.

FirasH

2016-05-27 09:40

reporter  

14103-Patch.diff (1,917 bytes)    

diff --git a/scribus/ui/propertiespalette_table.cpp b/scribus/ui/propertiespalette_table.cpp
--- a/scribus/ui/propertiespalette_table.cpp
+++ b/scribus/ui/propertiespalette_table.cpp
@@ -601,10 +601,7 @@
 
 void PropertiesPalette_Table::languageChange()
 {
-	cellStyleCombo->setToolTip( tr("Cell style of currently selected cell"));
-	tableStyleCombo->setToolTip( tr("Table style of currently selected table"));
-	buttonClearCellStyle->setToolTip( tr("Remove Direct Cell Formatting"));
-	buttonClearTableStyle->setToolTip( tr("Remove Direct Table Formatting"));
+	retranslateUi(this);
 }
 
 void PropertiesPalette_Table::unitChange()
diff --git a/scribus/ui/propertiespalette_tablebase.ui b/scribus/ui/propertiespalette_tablebase.ui
--- a/scribus/ui/propertiespalette_tablebase.ui
+++ b/scribus/ui/propertiespalette_tablebase.ui
@@ -35,10 +35,16 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="toolTip">
+         <string>Table style of currently selected table</string>
+        </property>
        </widget>
       </item>
       <item row="0" column="2">
        <widget class="QToolButton" name="buttonClearTableStyle">
+        <property name="toolTip">
+         <string>Remove Direct Table Formatting</string>
+        </property>
         <property name="text">
          <string/>
         </property>
@@ -65,10 +71,16 @@
           <verstretch>0</verstretch>
          </sizepolicy>
         </property>
+        <property name="toolTip">
+         <string>Cell style of currently selected cell</string>
+        </property>
        </widget>
       </item>
       <item row="1" column="2">
        <widget class="QToolButton" name="buttonClearCellStyle">
+        <property name="toolTip">
+         <string>Remove Direct Cell Formatting</string>
+        </property>
         <property name="text">
          <string/>
         </property>
14103-Patch.diff (1,917 bytes)   

jghali

2016-05-27 21:51

administrator   ~0041488

Committed, thanks!

Kunda

2016-05-28 05:14

updater   ~0041489

Patch was created by Firash.
fix was committed in 21354 by jghali.
Commit fixed issue.
Thank you everyone involved.

Issue History

Date Modified Username Field Change
2016-05-27 08:08 Laser New Issue
2016-05-27 08:08 Laser File Added: PP-table.png
2016-05-27 09:40 FirasH Note Added: 0041473
2016-05-27 09:40 FirasH File Added: 14103-Patch.diff
2016-05-27 09:40 FirasH Patch No => Yes
2016-05-27 09:44 FirasH Reproducibility have not tried => always
2016-05-27 13:50 Kunda Relationship added child of 0005002
2016-05-27 21:51 jghali Note Added: 0041488
2016-05-27 21:51 jghali Status new => resolved
2016-05-27 21:51 jghali Fixed in Version => 1.5.3.svn
2016-05-27 21:51 jghali Resolution open => fixed
2016-05-27 21:51 jghali Assigned To => FirasH
2016-05-28 05:14 Kunda Note Added: 0041489
2016-05-28 05:14 Kunda Status resolved => closed