View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0016391ScribusUser Interfacepublic2020-12-16 12:542021-03-21 15:27
Reporterbubu Assigned Tojghali  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.7.svn 
Fixed in Version1.5.7.svn 
Summary0016391: Fix margins for Margins & Bleeds in Document Setup/Document Setup
DescriptionThis patch is a hotfix for r24297 reported in 0016362.

I checked my previous issues and I found that Document Setup / Margins and Bleeds in Files > Preferences is fine, but in File > Document Setup is wrong. It has an "old style" scrollbar. Sorry. In this hotfix patch I propose a solution which in good in both places.

Please review the patch. Thanks.
TagsNo tags attached.
PatchYes

Relationships

child of 0013906 acknowledged Metabug: UI enhancement proposals (1.5.x.svn) 

Activities

bubu

2020-12-16 12:54

reporter  

documentsetup.diff (1,551 bytes)    
diff --git a/scribus/ui/prefs_documentsetupbase.ui b/scribus/ui/prefs_documentsetupbase.ui
index c6e83f8f5eaaffc20d468fa969d787902fa60161..bf517a6fd3fc0248f3b90504e3164d7f8e1bb7e8 100644
--- a/scribus/ui/prefs_documentsetupbase.ui
+++ b/scribus/ui/prefs_documentsetupbase.ui
@@ -341,6 +341,18 @@
        <string>Margins &amp;&amp; Bleeds</string>
       </attribute>
       <layout class="QVBoxLayout" name="verticalLayout_3">
+       <property name="leftMargin">
+        <number>0</number>
+       </property>
+       <property name="topMargin">
+        <number>0</number>
+       </property>
+       <property name="rightMargin">
+        <number>0</number>
+       </property>
+       <property name="bottomMargin">
+        <number>0</number>
+       </property>
        <item>
         <widget class="QScrollArea" name="scrollArea">
          <property name="frameShape">
@@ -365,18 +377,6 @@
            </rect>
           </property>
           <layout class="QVBoxLayout" name="verticalLayout_5">
-           <property name="leftMargin">
-            <number>0</number>
-           </property>
-           <property name="topMargin">
-            <number>0</number>
-           </property>
-           <property name="rightMargin">
-            <number>0</number>
-           </property>
-           <property name="bottomMargin">
-            <number>0</number>
-           </property>
            <item>
             <widget class="QLabel" name="marginsTitleLabel">
              <property name="font">
documentsetup.diff (1,551 bytes)   
documentsetup.gif (85,261 bytes)   
documentsetup.gif (85,261 bytes)   

jghali

2020-12-18 01:05

administrator   ~0048586

Applied, thanks!

FirasH

2021-03-21 15:27

reporter   ~0049023

Thanks!
Fixed in 1.5.7.svn (24332)

Issue History

Date Modified Username Field Change
2020-12-16 12:54 bubu New Issue
2020-12-16 12:54 bubu File Added: documentsetup.diff
2020-12-16 12:54 bubu File Added: documentsetup.gif
2020-12-17 08:12 PeterBenedek Relationship added child of 0013906
2020-12-18 01:05 jghali Assigned To => jghali
2020-12-18 01:05 jghali Status new => resolved
2020-12-18 01:05 jghali Resolution open => fixed
2020-12-18 01:05 jghali Fixed in Version => 1.5.7.svn
2020-12-18 01:05 jghali Note Added: 0048586
2021-03-21 15:27 FirasH Status resolved => closed
2021-03-21 15:27 FirasH Note Added: 0049023