View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001653 | Scribus | Internal | public | 2005-02-09 05:55 | 2005-07-12 04:23 |
| Reporter | Assigned To | ||||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Platform | x86 Linux | OS | Fedora Core | OS Version | 3 |
| Product Version | 1.3.0cvs | ||||
| Summary | 0001653: Convert all PageItem direct member access to use getters and setters | ||||
| Description | Convert all direct access to PageItem members by other classes to use getters. Use Riku's existing setters where possible. Where appropriate, convert members to enum types, and where appropriate rename them. I think this needs doing at some point. I got part way, but found I was just causing too many errors so I'm putting it on hold for now. | ||||
| Additional Information | This is a tracking bug so that all related diffs can be easily located. When the work is complete, this bug will be closed. I'll link bugs containing new patches for this work to this bug. Issues still to consider: - Handling of PageItem types 1 and 3, which appear to be obsolete. Old document compat? Need to do some conversion on import? - Should PageItem access its own members directly or via getters? Will the compiler optimise the getter case? | ||||
| Tags | No tags attached. | ||||
| Patch | |||||
| related to | 0001747 | closed | fschmid | Naming of Object Groups? |
| parent of | 0001609 | closed | Tsoots | [PATCH] Minor PageItem cleanups |
| parent of | 0001616 | closed | cbradney | PATCH: add getters and properties for all existing setters in PageItem |
| parent of | 0001623 | closed | cbradney | PATCH: Convert more PageItem members to protected |
| parent of | 0001632 | closed | Tsoots | PATCH: add getters and properties for all existing setters in PageItem (Round 2) |
| parent of | 0001639 | closed | cbradney | PATCH: Convert PageItem::PType to a protected enumerated member |
| parent of | 0001655 | closed | Tsoots | PATCH: remove last traces of PType |
| related to | 0002376 | closed | Source code requests | |
| child of | 0002382 | acknowledged | Metabug: Code quality, structure, readability |
|
|
I'm looking at hacking together a basic test suite for scribus, at least output verification, so can look at picking this up again with somewhat less fear of making a slip of concentration and introducing some nasty lurking bug. A comprehensive set out output tests would be nice eventually. |
|
|
Due for 1.3.x sometime. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2005-02-09 05:55 |
|
New Issue | |
| 2005-02-09 05:57 |
|
Relationship added | parent of 0001609 |
| 2005-02-09 05:58 |
|
Relationship added | parent of 0001616 |
| 2005-02-09 05:58 |
|
Relationship added | parent of 0001623 |
| 2005-02-09 05:58 |
|
Relationship added | parent of 0001632 |
| 2005-02-09 05:59 |
|
Relationship added | related to 0001639 |
| 2005-02-09 05:59 |
|
Relationship replaced | parent of 0001639 |
| 2005-02-09 07:51 |
|
Assigned To | ringerc => |
| 2005-02-09 07:52 |
|
Status | assigned => new |
| 2005-02-09 07:52 |
|
Description Updated | |
| 2005-02-09 08:36 |
|
Note Added: 0003670 | |
| 2005-02-09 08:42 |
|
Relationship added | related to 0001654 |
| 2005-02-09 08:56 |
|
Relationship deleted | related to 0001654 |
| 2005-02-09 08:56 |
|
Relationship added | related to 0000165 |
| 2005-02-09 08:57 |
|
Relationship deleted | related to 0000165 |
| 2005-02-09 08:57 |
|
Relationship added | parent of 0001655 |
| 2005-07-12 04:23 |
|
Note Added: 0005545 | |
| 2005-07-12 04:23 |
|
Status | new => confirmed |
| 2005-07-12 04:23 |
|
Relationship added | related to 0001747 |
| 2005-08-03 15:46 |
|
Relationship added | related to 0002376 |
| 2005-08-03 16:26 |
|
Relationship added | related to 0002382 |
| 2005-08-03 16:27 |
|
Relationship replaced | child of 0002382 |
