|
|
Translation between path separators is done by qt. Internally all paths uses unix-style separators. So should affect display only. |
|
2006-01-10 20:04
|
win32filepaths.png (43,667 bytes) |
|
|
I'm writting QDir::convertSeparators in loading/saving. |
|
|
jghali, can you notice me when you finish next win build to test it, please? |
|
|
Seems to work ok except one little thing : when you open a new file, the file is still displayed with slashes in recent file menu (see recent_files_slashes.png ) |
|
2006-01-12 14:29
|
recent_files_slashes.png (142,006 bytes) |
|
|
the filename in the title bar is also wrong |
|
|
[20:57:36] <subik> I have some issue with 2991 (/ in windows dirs) [20:57:45] <subik> I cannot test it on linux [20:58:05] <subik> there is a lot of "/" magic [20:59:00] <subik> void ScribusMainWindow::startUpDialog() [20:59:08] <subik> bool ScribusMainWindow::slotFileNew() [21:00:28] <subik> there should be QDdir::convertSeparators() wrapper around QString fileName definition. Can you dive in it now? [21:04:00] <jghali> subik: excuse me, was discussing with jo-hannes, going to do it now [21:05:25] <subik> no prob ;) [21:05:50] <subik> but beware. it can break all document loading imho [21:07:30] <jghali> subik: i think 2991 should not be qualified as major: does not prevent scribus from wroking [21:09:42] <jghali> if it were me i would have waited 1.3.2 release [21:19:25] <subik> jghali: ok, we will fix it after release... imho there we will have to rewrite some ugly hacks with file path done by QString::find() to QFile and QDir :-/ |
|
|
changing ScribusMainWindow::updateRecent and ScribusMainWindow::removeRecent fix the issue a bit more void ScribusMainWindow::updateRecent(QString fn) { QString platfname = QDir::convertSeparators(fn); if (RecentDocs.findIndex(platfname) == -1) { RecentDocs.prepend(platfname); fileWatcher->addFile(fn); } else { RecentDocs.remove(platfname); RecentDocs.prepend(platfname); } rebuildRecentFileMenu(); } void ScribusMainWindow::removeRecent(QString fn) { QString platfname = QDir::convertSeparators(fn); if (RecentDocs.findIndex(platfname) != -1) { RecentDocs.remove(platfname); if (!fileWatcher->isActive()) fileWatcher->removeFile(fn); } rebuildRecentFileMenu(); } |
|
|
void ScribusMainWindow::loadRecent(QString fn) { QFileInfo fd(fn); if (!fd.exists()) { RecentDocs.remove(QDir::convertSeparators(fn)); fileWatcher->removeFile(fn); rebuildRecentFileMenu(); return; } loadDoc(fn); } |
|
|
Committed that stuff Jean noted |
|
|
still wrong in - preferences (docs, icc profiles...) and external tools and plugin-list. - manage pictures - open file / save file |
|
|
now there are multiple entries of the same files in the recent files menu on windows. |
|
|
you should reset the recent file list by erasing RECENT elements in scribus13.rc, have seen the same phenomenon, but it disappeared after doing so. |
|
|
that works, thx. |
|
|
hmm, does not work so well, when closing and opening again, duplicates really appear in recent file list... |
|
|
well, after more testing, it has appeared that a non complete fix has more chance to trigger bugs than anything else. Committed changes have been reverted. Safer to wait for 1.3.2 release... Really... |
|
|
In surprising places things that appear to be "just for display" may be used for I/O, stored in prefs, etc as well. I was bitten by this, though not with file separators, when renaming some GUI text in the PDF dialog. It turned out that the combo box text ended up in the PDF file... Whenever you change a GUI element's display you'll probably have to find all places in the code that access its value (ie the text of a combo box item) and make sure they don't send it anywhere unexpected and silly. |
|
|
Fixed recent file menu. |
|
|
making non-private as windows version has been released. |
|
2006-07-04 09:19
|
linux_paths_on_win_1.png (23,395 bytes) |
|
|
Please don't use ./ or ../ because it will surely miss the targeted audience (see the attached screenshot linux_paths_on_win_1.png) |
|
|
-file/dir dialogs (CustomFDialog?) -print dialog/file: (print is different to file dialog tho.. custom dialog, dont forget alternative print command too for print dialog) -new file dialog, open existing doc *title bar file name* *windows menu* -prefs->general directories -prefs->fonts additional paths -prefs->external apps *warning for unsaved doc* -export as image dialog |
|
|
Most of the issue should be now fixed in 1.3.4cvs, except file dialogs which are not fixable without patching qt. |
- Anonymous
