|
|
This is a really old request, that seems like a very basic feature for a DTP program to have.
Use Case: brochures
If I've setup guides to cover the printable space, it would be nice to just expand the text frame to the sides and set an "image centered" property so that I can guarantee the spacing without have to resort to the calculations or using a script. |
|
|
|
i'm for adding this feature to the align and distribute dialog. |
|
|
|
hello guys
I am working in this feature or something similar but I got lost in some points if any one can help me
what I did exactly that I add new combobox in PropertiesPalette_Image that will have 9 option (top-left , top-middle , botton-right ... etc) according to the choice the image will move in the frame to the new x and new y coordinate , the problem is calculating the new x,y. for that I will need width and hight for the image and the frame. so I stop their for a moment. if any one can help how to get the width and hight for the both image and frame |
|
|
|
hello again
i finish this feature
my work is as following
i add 2 combo box for alignment
first one is vertical which has three options (top ,center,bottom)
the second is horizontal which has also 3 options (left , center ,right )
if the image is smaller than the frame so you can move it by these options
the new options is in property >>> image >>> align image
thank you |
|
|
|
alignImage.diff (10,087 bytes)
Index: scribus/ui/propertiespalette_image.cpp
===================================================================
--- scribus/ui/propertiespalette_image.cpp (revision 20473)
+++ scribus/ui/propertiespalette_image.cpp (working copy)
@@ -110,6 +110,9 @@
connect(renderIntent , SIGNAL(activated(int)) , this, SLOT(handleIntent()));
connect(compressionMethod , SIGNAL(activated(int)) , this, SLOT(handleCompressionMethod()));
connect(compressionQuality , SIGNAL(activated(int)) , this, SLOT(handleCompressionQuality()));
+ connect(alignvertical , SIGNAL(currentIndexChanged(int)) , this, SLOT(alignImageVertical(int)));
+ connect(alignhorozintal , SIGNAL(currentIndexChanged(int)), this, SLOT(alignImageHorozintal(int)));
+
}
void PropertiesPalette_Image::changeEvent(QEvent *e)
@@ -890,4 +893,59 @@
}
}
+void PropertiesPalette_Image::alignImageVertical(int in){
+ double imagex,imagey,heightf ,heightim;
+ //imagex = m_item->pixm.imgInfo.xres();
+
+ if (!m_ScMW || m_ScMW->scriptIsRunning())
+ return;
+ if ((m_haveDoc) && (m_haveItem) && (m_item->asImageFrame()))
+ {
+
+ // widthim = m_item->pixm.width();
+ heightim = m_item->pixm.height();
+ // widthf = m_item->width();
+ heightf = m_item->height();
+
+ if (in == 0);
+ else if (in == 1)imagey = 0;
+ else if (in == 2)imagey = (heightf- heightim)/2.0;
+ else imagey = heightf - heightim ;
+
+ imagex = m_item->imageXOffset();
+ m_doc->itemSelection_SetImageOffset(imagex, imagey);
+ m_item->update();
+
+ }
+ else ;//add error massage
+
+}
+void PropertiesPalette_Image::alignImageHorozintal(int in){
+ double imagex,imagey,widthf,widthim;
+ //imagex = m_item->pixm.imgInfo.xres();
+
+
+ if (!m_ScMW || m_ScMW->scriptIsRunning())
+ return;
+ if ((m_haveDoc) && (m_haveItem) && (m_item->asImageFrame()))
+ {
+
+ widthim = m_item->pixm.width();
+ //heightim = m_item->pixm.height();
+ widthf = m_item->width();
+ //heightf = m_item->height();
+
+ if (in == 0);
+ else if (in == 1)imagex = 0;
+ else if (in == 2)imagex = (widthf - widthim)/2.0;
+ else imagex = widthf - widthim ;
+
+ imagey = m_item->imageYOffset();
+ m_doc->itemSelection_SetImageOffset(imagex, imagey);
+ m_item->update();
+
+ }
+ else ; //add error message
+}
+
Index: scribus/ui/propertiespalette_image.h
===================================================================
--- scribus/ui/propertiespalette_image.h (revision 20473)
+++ scribus/ui/propertiespalette_image.h (working copy)
@@ -102,6 +102,8 @@
void handleImageEffects();
void handleExtImgProperties();
+ void alignImageVertical(int);
+ void alignImageHorozintal(int);
signals:
void UpdtGui(int);
Index: scribus/ui/propertiespalette_imagebase.ui
===================================================================
--- scribus/ui/propertiespalette_imagebase.ui (revision 20473)
+++ scribus/ui/propertiespalette_imagebase.ui (working copy)
@@ -6,8 +6,8 @@
<rect>
<x>0</x>
<y>0</y>
- <width>286</width>
- <height>617</height>
+ <width>297</width>
+ <height>682</height>
</rect>
</property>
<property name="windowTitle">
@@ -17,9 +17,18 @@
<property name="spacing">
<number>2</number>
</property>
- <property name="margin">
+ <property name="leftMargin">
<number>2</number>
</property>
+ <property name="topMargin">
+ <number>2</number>
+ </property>
+ <property name="rightMargin">
+ <number>2</number>
+ </property>
+ <property name="bottomMargin">
+ <number>2</number>
+ </property>
<item>
<layout class="QGridLayout" name="gridLayout">
<item row="2" column="0">
@@ -63,13 +72,6 @@
</property>
</widget>
</item>
- <item row="3" column="0">
- <widget class="QLabel" name="yposImgLabel">
- <property name="text">
- <string>Y-Pos:</string>
- </property>
- </widget>
- </item>
<item row="3" column="1">
<widget class="ScrSpinBox" name="imageYOffsetSpinBox">
<property name="sizePolicy">
@@ -80,6 +82,13 @@
</property>
</widget>
</item>
+ <item row="3" column="0">
+ <widget class="QLabel" name="yposImgLabel">
+ <property name="text">
+ <string>Y-Pos:</string>
+ </property>
+ </widget>
+ </item>
<item row="1" column="1">
<widget class="ScrSpinBox" name="imagePageNumber">
<property name="specialValueText">
@@ -151,10 +160,10 @@
</property>
</widget>
</item>
- <item row="4" column="0">
- <widget class="QLabel" name="imgDPIXLabel">
+ <item row="5" column="0">
+ <widget class="QLabel" name="imgDPIYLabel">
<property name="text">
- <string>Actual X-DPI:</string>
+ <string>Actual Y-DPI:</string>
</property>
</widget>
</item>
@@ -161,10 +170,10 @@
<item row="4" column="1">
<widget class="ScrSpinBox" name="imgDpiX"/>
</item>
- <item row="5" column="0">
- <widget class="QLabel" name="imgDPIYLabel">
+ <item row="4" column="0">
+ <widget class="QLabel" name="imgDPIXLabel">
<property name="text">
- <string>Actual Y-DPI:</string>
+ <string>Actual X-DPI:</string>
</property>
</widget>
</item>
@@ -200,14 +209,88 @@
</property>
</widget>
</item>
- <item row="7" column="1">
- <widget class="QCheckBox" name="cbProportional">
+ <item row="10" column="1">
+ <widget class="QLabel" name="label_3">
<property name="text">
- <string>Proportional</string>
+ <string>Horozental</string>
</property>
</widget>
</item>
- <item row="6" column="0">
+ <item row="11" column="0">
+ <widget class="QComboBox" name="alignvertical">
+ <item>
+ <property name="text">
+ <string>Default</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Top</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Center</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Bottom</string>
+ </property>
+ </item>
+ </widget>
+ </item>
+ <item row="11" column="1">
+ <widget class="QComboBox" name="alignhorozintal">
+ <item>
+ <property name="text">
+ <string>Default</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Left</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Center</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Right</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string/>
+ </property>
+ </item>
+ </widget>
+ </item>
+ <item row="9" column="0">
+ <widget class="QLabel" name="label">
+ <property name="font">
+ <font>
+ <pointsize>11</pointsize>
+ <weight>75</weight>
+ <bold>true</bold>
+ </font>
+ </property>
+ <property name="text">
+ <string>Align Image</string>
+ </property>
+ </widget>
+ </item>
+ <item row="10" column="0">
+ <widget class="QLabel" name="label_2">
+ <property name="text">
+ <string>Vertical </string>
+ </property>
+ </widget>
+ </item>
+ <item row="7" column="0">
<widget class="QRadioButton" name="frameScale">
<property name="text">
<string>To Frame Size</string>
@@ -214,6 +297,13 @@
</property>
</widget>
</item>
+ <item row="8" column="0">
+ <widget class="QCheckBox" name="cbProportional">
+ <property name="text">
+ <string>Proportional</string>
+ </property>
+ </widget>
+ </item>
</layout>
</widget>
</item>
@@ -223,13 +313,6 @@
<string>Color Management</string>
</property>
<layout class="QGridLayout" name="gridLayout_4">
- <item row="0" column="0">
- <widget class="QLabel" name="inputProfLabel">
- <property name="text">
- <string>Input Profile</string>
- </property>
- </widget>
- </item>
<item row="0" column="1">
<widget class="QComboBox" name="inputProfiles">
<property name="sizePolicy">
@@ -250,6 +333,13 @@
<item row="1" column="1">
<widget class="QComboBox" name="renderIntent"/>
</item>
+ <item row="0" column="0">
+ <widget class="QLabel" name="inputProfLabel">
+ <property name="text">
+ <string>Input Profile</string>
+ </property>
+ </widget>
+ </item>
</layout>
</widget>
</item>
@@ -327,6 +417,9 @@
</layout>
</item>
<item>
+ <layout class="QVBoxLayout" name="verticalLayout_2"/>
+ </item>
+ <item>
<spacer name="verticalSpacer">
<property name="orientation">
<enum>Qt::Vertical</enum>
@@ -365,8 +458,6 @@
<tabstop>imgDpiY</tabstop>
<tabstop>keepImageWHRatioButton</tabstop>
<tabstop>keepImageDPIRatioButton</tabstop>
- <tabstop>frameScale</tabstop>
- <tabstop>cbProportional</tabstop>
<tabstop>inputProfiles</tabstop>
<tabstop>renderIntent</tabstop>
<tabstop>compressionMethod</tabstop>
|
|
|
|
When I load the scribus splashscreen into an image frame, it doesn't center vertically and doesnt go to the bottom of the frame either. Center horizontal mightbe ok, but right horizontall is again off.
Typo in Horizontal in GUI.
There's issues with the selection of Default. I assume it should return the image to the top left but it doesn't.
Also, I think the controls might need to be nearer to the X/Y position to understand that it just updates those values.
Also, the case where an image has been scaled needs to be handled properly, by using the scaled width.
Thanks for the patch, let's see how the next revision is. |
|
|
|
Thank you mr cbradny
I dont know why the options doesn't work properly with u ... i try it in to 2 different machines and it works fine but i will check it again and about other points i totally agree with u
I will try to fix it soon
Thank you |
|
|
|
I suspect that it relates to the height/width calculation .. see documentchecker.cpp isPartFilledImageFrame() for some hints. |
|
|
|
sorry I was not understanding what you are meaning last night but now I know
I did handle scale properly in updated patch and I change the location of the alignment control as you request and I made some changes in code layout it looks nice now
I hope there will be no problems now
thank you
|
|
|
|
alignImageUpdated.diff (8,950 bytes)
Index: scribus/ui/propertiespalette_image.cpp
===================================================================
--- scribus/ui/propertiespalette_image.cpp (revision 20505)
+++ scribus/ui/propertiespalette_image.cpp (working copy)
@@ -110,6 +110,8 @@
connect(renderIntent , SIGNAL(activated(int)) , this, SLOT(handleIntent()));
connect(compressionMethod , SIGNAL(activated(int)) , this, SLOT(handleCompressionMethod()));
connect(compressionQuality , SIGNAL(activated(int)) , this, SLOT(handleCompressionQuality()));
+ connect(alignvertical , SIGNAL(currentIndexChanged(int)) , this, SLOT(alignImageVertical(int)));
+ connect(alignhorozintal , SIGNAL(currentIndexChanged(int)), this, SLOT(alignImageHorozintal(int)));
}
void PropertiesPalette_Image::changeEvent(QEvent *e)
@@ -890,4 +892,59 @@
}
}
+void PropertiesPalette_Image::alignImageVertical(int idx){
+ if (!m_ScMW || m_ScMW->scriptIsRunning())
+ return;
+ if ((m_haveDoc) && (m_haveItem) && (m_item->asImageFrame()))
+ {
+ double newY;
+ double imageHeight = m_item->pixm.height() * m_item->imageYScale() * m_item->pixm.imgInfo.lowResScale;
+ double frameHeight= m_item->height();
+
+ switch (idx)
+ {
+ case 1:
+ newY = 0;
+ break;
+ case 2:
+ newY = (frameHeight - imageHeight) / 2.0;
+ break;
+ case 3:
+ newY = frameHeight - imageHeight;
+ break;
+ default:
+ newY = m_item->imageYOffset(); //do nothing
+ break;
+ }
+ m_doc->itemSelection_SetImageOffset(m_item->imageXOffset(), newY / m_item->imageYScale());
+ }
+}
+
+void PropertiesPalette_Image::alignImageHorozintal(int idx) {
+ if (!m_ScMW || m_ScMW->scriptIsRunning())
+ return;
+
+ if ((m_haveDoc) && (m_haveItem) && (m_item->asImageFrame()))
+ {
+ double newX;
+ double imageWidth = m_item->pixm.width() * m_item->imageXScale() * m_item->pixm.imgInfo.lowResScale;
+ double frameWidth = m_item->width();
+ switch (idx)
+ {
+ case 1:
+ newX = 0;
+ break;
+ case 2:
+ newX = (frameWidth - imageWidth) / 2.0;
+ break;
+ case 3:
+ newX = frameWidth - imageWidth;
+ break;
+ default:
+ newX = m_item->imageXOffset(); // do nothing
+ break;
+ }
+ m_doc->itemSelection_SetImageOffset(newX / m_item->imageXScale(), m_item->imageYOffset());
+ }
+}
Index: scribus/ui/propertiespalette_image.h
===================================================================
--- scribus/ui/propertiespalette_image.h (revision 20505)
+++ scribus/ui/propertiespalette_image.h (working copy)
@@ -102,6 +102,8 @@
void handleImageEffects();
void handleExtImgProperties();
+ void alignImageVertical(int);
+ void alignImageHorozintal(int);
signals:
void UpdtGui(int);
Index: scribus/ui/propertiespalette_imagebase.ui
===================================================================
--- scribus/ui/propertiespalette_imagebase.ui (revision 20505)
+++ scribus/ui/propertiespalette_imagebase.ui (working copy)
@@ -6,8 +6,8 @@
<rect>
<x>0</x>
<y>0</y>
- <width>286</width>
- <height>617</height>
+ <width>297</width>
+ <height>690</height>
</rect>
</property>
<property name="windowTitle">
@@ -17,9 +17,18 @@
<property name="spacing">
<number>2</number>
</property>
- <property name="margin">
+ <property name="leftMargin">
<number>2</number>
</property>
+ <property name="topMargin">
+ <number>2</number>
+ </property>
+ <property name="rightMargin">
+ <number>2</number>
+ </property>
+ <property name="bottomMargin">
+ <number>2</number>
+ </property>
<item>
<layout class="QGridLayout" name="gridLayout">
<item row="2" column="0">
@@ -63,13 +72,6 @@
</property>
</widget>
</item>
- <item row="3" column="0">
- <widget class="QLabel" name="yposImgLabel">
- <property name="text">
- <string>Y-Pos:</string>
- </property>
- </widget>
- </item>
<item row="3" column="1">
<widget class="ScrSpinBox" name="imageYOffsetSpinBox">
<property name="sizePolicy">
@@ -80,6 +82,13 @@
</property>
</widget>
</item>
+ <item row="3" column="0">
+ <widget class="QLabel" name="yposImgLabel">
+ <property name="text">
+ <string>Y-Pos:</string>
+ </property>
+ </widget>
+ </item>
<item row="1" column="1">
<widget class="ScrSpinBox" name="imagePageNumber">
<property name="specialValueText">
@@ -90,6 +99,77 @@
</layout>
</item>
<item>
+ <widget class="QGroupBox" name="alignmentGroupBox">
+ <property name="title">
+ <string>Alignment</string>
+ </property>
+ <layout class="QFormLayout" name="formLayout">
+ <item row="0" column="0">
+ <widget class="QLabel" name="label_2">
+ <property name="text">
+ <string>Horizontal</string>
+ </property>
+ </widget>
+ </item>
+ <item row="2" column="0">
+ <widget class="QLabel" name="label_3">
+ <property name="text">
+ <string>Vertical</string>
+ </property>
+ </widget>
+ </item>
+ <item row="0" column="1">
+ <widget class="QComboBox" name="alignhorozintal">
+ <item>
+ <property name="text">
+ <string>None</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Left</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Center</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Right</string>
+ </property>
+ </item>
+ </widget>
+ </item>
+ <item row="2" column="1">
+ <widget class="QComboBox" name="alignvertical">
+ <item>
+ <property name="text">
+ <string>None</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Top</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Middle</string>
+ </property>
+ </item>
+ <item>
+ <property name="text">
+ <string>Bottom</string>
+ </property>
+ </item>
+ </widget>
+ </item>
+ </layout>
+ </widget>
+ </item>
+ <item>
<widget class="QGroupBox" name="scalingGroupBox">
<property name="title">
<string>Scaling</string>
@@ -200,17 +280,17 @@
</property>
</widget>
</item>
- <item row="7" column="1">
- <widget class="QCheckBox" name="cbProportional">
+ <item row="7" column="0">
+ <widget class="QRadioButton" name="frameScale">
<property name="text">
- <string>Proportional</string>
+ <string>To Frame Size</string>
</property>
</widget>
</item>
- <item row="6" column="0">
- <widget class="QRadioButton" name="frameScale">
+ <item row="8" column="0">
+ <widget class="QCheckBox" name="cbProportional">
<property name="text">
- <string>To Frame Size</string>
+ <string>Proportional</string>
</property>
</widget>
</item>
@@ -223,13 +303,6 @@
<string>Color Management</string>
</property>
<layout class="QGridLayout" name="gridLayout_4">
- <item row="0" column="0">
- <widget class="QLabel" name="inputProfLabel">
- <property name="text">
- <string>Input Profile</string>
- </property>
- </widget>
- </item>
<item row="0" column="1">
<widget class="QComboBox" name="inputProfiles">
<property name="sizePolicy">
@@ -250,6 +323,13 @@
<item row="1" column="1">
<widget class="QComboBox" name="renderIntent"/>
</item>
+ <item row="0" column="0">
+ <widget class="QLabel" name="inputProfLabel">
+ <property name="text">
+ <string>Input Profile</string>
+ </property>
+ </widget>
+ </item>
</layout>
</widget>
</item>
@@ -327,6 +407,9 @@
</layout>
</item>
<item>
+ <layout class="QVBoxLayout" name="verticalLayout_2"/>
+ </item>
+ <item>
<spacer name="verticalSpacer">
<property name="orientation">
<enum>Qt::Vertical</enum>
@@ -365,8 +448,6 @@
<tabstop>imgDpiY</tabstop>
<tabstop>keepImageWHRatioButton</tabstop>
<tabstop>keepImageDPIRatioButton</tabstop>
- <tabstop>frameScale</tabstop>
- <tabstop>cbProportional</tabstop>
<tabstop>inputProfiles</tabstop>
<tabstop>renderIntent</tabstop>
<tabstop>compressionMethod</tabstop>
|
|
|
|
Nice to see that someone is taking care of these old issues ;-)
I will test the next days! |
|
|
|
i have the feeling that they work correctly.
but i really would prefer to have buttons rather than drop downs...
i've added a mock up of it and a zip containing a first possible version of the icons for 1.5.1 (and i would let dezso or another designer create the definitive icons) |
|
|
ale
2015-10-28 23:26
manager
|
|
|
|
ale
2015-10-28 23:26
manager
|
|
|
|
|
btw, i still would prefer to have the buttons in the align and distribute dialog...
and when the user is in image edit mode the align and distribute dialog should show only one tab with the above attached buttons... |
|
|
|
I agree that bottons will be very nice but I am zero in xml language
I will try to change it if I success I will update the patch
Thank you ale
|
|
|
|
This feature is awesome!
I totally agree that these should be buttons and not dropdowns.
Lets make that happen! |
|
|
|
I discuss the design with someone and he says that droplist is better than the bottons so I need to know what is the opinion of core developers , please informe me or make a note in mailling list to agreed about the final design before i change it
|
|
|
|
i would be interested in kwnowing why the other person is preferring the drop down list.
my rational for the buttons:
i would use drop downs for selecting a type of alignement for the image. a property that is then stored in the frame properties.
but here we are just sending the frame content to one of the directions (top, bottom, left, right, center) and the user is then free to further move the content.
the button should not be in pushed down state afte they have been used. it's just an action, you're not setting a property.
it's exactly the same as one is doing in "windows > align and distribute" and it should IMO work in the same way.
i would even go further and say that this function should be in the "align and distribute" dialog. but we can further move it later, if we want to do so.
conerning the editing of the .ui file: i don't know this spcific file, but generally, it's better to modify them by using the designer part of qtcreator (the IDE relating to Qt).
directly editing the xml file is fine for small changes... but, as you noticed, can get pretty tedious... |
|
|
|
ps: if testers have the scribus github repository cloned you can try:
git fetch origin pull/32/head:pr-32
git checkout pr-32
to get the patch in a new local branch called pr-32 with the patch i've applied from dawoodalbadi. |
|
|
|
Dawood, found an issue with the patch:
1) Open an image frame
2a) Make the image frame larger than the image itself in the vertical plane
3a) Click Vertical > Middle OR Vertical > Bottom
4a) Click Vertical > None
Image has disaapeared (Click Vertical > 'Top' for image to return)
OR
2b) Make the image frame larger than the image itself in the horizontal plane
3b) Click Horizontal > Center OR Horizontal > Left
4b) Click Horizontal > None
Image doesn't dissappear but it doesn't respond correctly |
|
|
|
I also added a screencast of the overal feature in action so people can see it in action (not the bug I found) |
|
|
Kunda
2015-10-29 15:58
updater
|
|
|
|
|
My vote goes for including this functionality in Align&Distribute dialog. |
|
|
|
Also, what scenario would someone have to not have the frame resized back down to the image size? I can think of some forced wrapping of text scenarios but I'm not sure this function even makes sense to include. |
|
|
|
mmm... i don't see why aligning the image to the frame should reset the image size.
i think that one of the guys shouting for this function was doing a catalog and he might have been working this way:
- resize the image until it fits horizontally
- align the image to the bottom of the frame |
|
|
|
I am willing to work in this patch again at the end of next week
So far i will change the control from menu to bottons and i will see the bug that kunda discover
If you have another problems tell me
Also if you think there is a need for other function like resize image tell me
And finally if you think this batch is not necessary or no need for it please inform me i will not wast my time on it
Thanks
Dawood |
|
|
|
craig, i thought again about what you wrote and i guess that: yes, somebody could achieve most tasks by resizing the frame to the image frame.
but not all of them.
as an example, "adjust frame to image" does not fit (correctly) when the image is not completely shown.
for others -- like in the catalog example -- it is more a faster way to get to the goal... |
|
|
|
@dawoodalbadi: if craig agrees with the the function being useful, please implement it as buttons in the properties palette.
as vlada notes, this function belongs in the align and distribute window (where, obviously, it would be implemented as buttons!) and we should move it there at some time (if possible before or during the transition to the new properties palette). |
|
|
|
When we get this implemented (crossing fingers) lets make sure to address 0005662 as well. |
|
