View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0012731 | Scribus | Translation | public | 2014-09-26 15:17 | 2016-04-02 13:34 |
| Reporter | FirasH | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | new | Resolution | open | ||
| Product Version | 1.5.0svn | ||||
| Summary | 0012731: "Default Paragraph/Character/Table/Cell Style" name should be translated | ||||
| Description | In the "Style Manager", under "Based On:" the entries for the default styles "Default Paragraph/Character/Table/Cell Style" are not translated. Their corresponding name in the list on the left of the Styles window are translated. Same happens in the Properties Palette where it is possible to select the Default Paragraph/Character/Table/Cell Style | ||||
| Additional Information | Issue present on: 1.4.5.svn (19540) 1.5.0.svn (19541) | ||||
| Tags | No tags attached. | ||||
| Patch | No | ||||
| related to | 0012742 | closed | cbradney | Save/Discard/Cancel should be translatable on document closing (QMessageBox translation) |
| related to | 0008238 | new | "Default Paragraph Style" and other default styles naming inconsistency | |
| related to | 0013384 | confirmed | Style name "Default Paragraph Style" non-switching language | |
| child of | 0005002 | acknowledged | Metabug - 1.5 Non-switching translations |
|
|
12731(1.5.0.svn).patch (1,802 bytes)
Index: scribus/scribusdoc.cpp =================================================================== --- scribus/scribusdoc.cpp (revisione 19541) +++ scribus/scribusdoc.cpp (copia locale) @@ -501,7 +501,7 @@ ParagraphStyle pstyle; pstyle.setDefaultStyle(true); - pstyle.setName(CommonStrings::DefaultParagraphStyle); + pstyle.setName(CommonStrings::trDefaultParagraphStyle); pstyle.setLineSpacingMode(ParagraphStyle::FixedLineSpacing); pstyle.setLineSpacing(15); pstyle.setAlignment(ParagraphStyle::Leftaligned); @@ -519,7 +519,7 @@ CharStyle cstyle; cstyle.setDefaultStyle(true); - cstyle.setName(CommonStrings::DefaultCharacterStyle); + cstyle.setName(CommonStrings::trDefaultCharacterStyle); cstyle.setFont(appPrefsData.fontPrefs.AvailFonts[docPrefsData.itemToolPrefs.textFont]); cstyle.setFontSize(docPrefsData.itemToolPrefs.textSize); cstyle.setFeatures(QStringList(CharStyle::INHERIT)); @@ -556,7 +556,7 @@ // TODO: We should have preferences for the default values. TableStyle defaultTableStyle; defaultTableStyle.setDefaultStyle(true); - defaultTableStyle.setName(CommonStrings::DefaultTableStyle); + defaultTableStyle.setName(CommonStrings::trDefaultTableStyle); defaultTableStyle.setFillColor(CommonStrings::None); defaultTableStyle.setFillShade(100); defaultTableStyle.setLeftBorder(TableBorder(1.0, Qt::SolidLine, "Black", 100)); @@ -570,7 +570,7 @@ // TODO: We should have preferences for the default values. CellStyle defaultCellStyle; defaultCellStyle.setDefaultStyle(true); - defaultCellStyle.setName(CommonStrings::DefaultCellStyle); + defaultCellStyle.setName(CommonStrings::trDefaultCellStyle); defaultCellStyle.setFillColor(CommonStrings::None); defaultCellStyle.setFillShade(100); defaultCellStyle.setLeftBorder(TableBorder(1.0, Qt::SolidLine, "Black", 100)); |
|
|
mmm, I tested a bit the patch and there is something going wrong... (when loading with a different UI language) |
|
|
Firash, did you stumble on another bug or create one ? |
|
|
At some point, ie when the document is created, those are names of the styles, not default texts. We dont support translation of document data, eg colour names, style names, object names |
|
|
so this is a "won't fix" ? |
|
|
resolving as "won't fix" since this is by design |
|
|
I'm not in a hurry, issue is de facto present anyway. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-09-26 15:17 | FirasH | New Issue | |
| 2014-09-26 15:31 | FirasH | Summary | "Default Paragraph/Character/Table/Cell Style" name should be translatable => [PATCH] "Default Paragraph/Character/Table/Cell Style" name should be translatable |
| 2014-09-26 15:31 | FirasH | File Added: 12731(1.5.0.svn).patch | |
| 2014-09-26 15:35 | FirasH | Summary | [PATCH] "Default Paragraph/Character/Table/Cell Style" name should be translatable => [PATCH] "Default Paragraph/Character/Table/Cell Style" name should be translated |
| 2014-09-26 17:45 | FirasH | Note Added: 0033840 | |
| 2014-09-26 17:49 | FirasH | Note Edited: 0033840 | |
| 2014-09-26 17:56 | FirasH | Summary | [PATCH] "Default Paragraph/Character/Table/Cell Style" name should be translated => "Default Paragraph/Character/Table/Cell Style" name should be translated |
| 2014-10-06 10:26 | FirasH | Relationship added | related to 0012742 |
| 2015-02-01 00:14 | Kunda | Note Added: 0034402 | |
| 2015-02-01 10:47 | cbradney | Note Added: 0034406 | |
| 2016-02-23 19:33 | Kunda | Note Added: 0038868 | |
| 2016-03-25 13:19 | Kunda | Note Added: 0039407 | |
| 2016-03-25 13:19 | Kunda | Status | new => resolved |
| 2016-03-25 13:19 | Kunda | Resolution | open => won't fix |
| 2016-03-25 13:19 | Kunda | Assigned To | => cbradney |
| 2016-03-25 16:36 | FirasH | Patch | => No |
| 2016-03-25 16:36 | FirasH | Note Added: 0039420 | |
| 2016-03-25 16:36 | FirasH | Assigned To | cbradney => |
| 2016-03-25 16:36 | FirasH | Status | resolved => new |
| 2016-03-25 16:36 | FirasH | Resolution | won't fix => open |
| 2016-04-02 13:33 | Kunda | Relationship added | related to 0008238 |
| 2016-04-02 13:33 | Kunda | Relationship added | related to 0013384 |
| 2016-04-02 13:34 | Kunda | Relationship added | child of 0005002 |
