View Issue Details

IDProjectCategoryView StatusLast Update
0012742ScribusTranslationpublic2015-06-30 17:20
ReporterFirasH Assigned Tocbradney  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.5.0svn 
Target Version1.5.0Fixed in Version1.5.0svn 
Summary0012742: Save/Discard/Cancel should be translatable on document closing (QMessageBox translation)
DescriptionSave/Discard/Cancel should be translatable on document closing.
Steps To Reproduce0) Create a new document
1) Apply a change
2) Go to: File > Close

Save/Discard/Cancel are non translatable.
Additional Information1.5.0.svn (19545)
TagsNo tags attached.
PatchNo

Relationships

duplicate of 0010221 closedjghali langage for "save, discard or cancel" dialog 
related to 0012731 new "Default Paragraph/Character/Table/Cell Style" name should be translated 
related to 0012819 closedjghali [PATCH] Fix some non translated UI strings 
related to 0013107 closedcbradney Wrong language on document closing dialogue: Save - Close without Saving - Cancel 

Activities

FirasH

2014-10-06 10:25

developer   ~0033914

There are some other entries that have a similar problem like
Before/After when linking Text Frames
OK/Cancel in various dialogs

I have no idea if the fix itself is easy or not...

cbradney

2014-10-07 22:00

administrator   ~0033919

We use QMessageBox::Save | QMessageBox::Discard | QMessageBox::Cancel in, eg, void ScribusWin::closeEvent(QCloseEvent *ce)

See if adding the strings in the translationdummy.cpp file helps you out.

FirasH

2014-10-08 11:00

developer   ~0033930

I've already tried that but nothing happens

FirasH

2014-10-08 11:35

developer   ~0033931

Probably there is something I'm missing in editing translationdummy.cpp

FirasH

2014-11-17 15:28

developer   ~0034206

Uploaded a patch which allows the translation of those buttons.
I also found that in line 191 of "canvasmode_framelinks.cpp" tr("Linking Text Frames") was not translated, now is fixed.

Basically rather than using QMessageBox I used QPushButton. Everything is tested and working as expected. If there is an easy way to allow QMessageBox translation that would be nice...

If that is not accepted there are some spacings + the previous non-translated string that can be applied to the code.

cbradney

2014-11-17 21:00

administrator   ~0034211

We've needed the extra spaces around the quoted areas due to Qt bugs in the past.

FirasH

2014-11-18 12:25

developer   ~0034213

Thanks cbradney for revising the patch,
I'll report the non-translated string in another report + patch.
This issue is now only about QMessageBox translation.

Kunda

2015-02-01 00:13

updater   ~0034401

Making sure this doesn't fall to the wayside. Assigning to 1.5.1

FirasH

2015-02-01 13:43

developer   ~0034408

Fixed in 1.5.0.svn (19779).

cbradney

2015-02-01 13:55

administrator   ~0034409

FYI looks like the French Qt translation doesnt work well, but DE, IT confirm this fix.

Kunda

2015-02-12 00:58

updater   ~0034486

Craig, to be clear, this is Qt French localization issue right, not Scribus? If so maybe someone in the Scribus community would be interested in helping to translate the upstream Qt localization for french ?

FirasH

2015-02-19 13:40

developer   ~0034539

Thanks cbradney!
The fix is working correctly with Italian UI.

Issue History

Date Modified Username Field Change
2014-10-02 13:24 FirasH New Issue
2014-10-05 23:04 Kunda Tag Attached: easyhack
2014-10-06 10:25 FirasH Note Added: 0033914
2014-10-06 10:26 FirasH Relationship added related to 0012731
2014-10-07 22:00 cbradney Note Added: 0033919
2014-10-08 11:00 FirasH Note Added: 0033930
2014-10-08 11:35 FirasH Note Added: 0033931
2014-10-15 17:07 Kunda Tag Renamed easyhack => #easyhack
2014-11-17 15:28 FirasH Note Added: 0034206
2014-11-17 15:29 FirasH File Added: 12742-PossiblePatch.diff
2014-11-17 17:50 FirasH Patch => Yes
2014-11-17 21:00 cbradney Note Added: 0034211
2014-11-18 12:25 FirasH Note Added: 0034213
2014-11-18 12:25 FirasH Patch Yes => No
2014-11-18 12:29 FirasH Relationship added related to 0012819
2014-11-20 13:57 FirasH File Deleted: 12742-PossiblePatch.diff
2015-01-29 23:23 Kunda Assigned To => FirasH
2015-01-29 23:23 Kunda Status new => assigned
2015-02-01 00:13 Kunda Note Added: 0034401
2015-02-01 00:13 Kunda Target Version => 1.5.1
2015-02-01 00:13 Kunda Summary Save/Discard/Cancel should be translatable on document closing => Save/Discard/Cancel should be translatable on document closing (QMessageBox translation)
2015-02-01 11:18 JLuc Relationship added duplicate of 0010221
2015-02-01 12:49 cbradney Status assigned => resolved
2015-02-01 12:49 cbradney Fixed in Version => 1.5.0svn
2015-02-01 12:49 cbradney Resolution open => fixed
2015-02-01 12:49 cbradney Assigned To FirasH => cbradney
2015-02-01 12:52 cbradney Target Version 1.5.1 => 1.5.0
2015-02-01 13:43 FirasH Note Added: 0034408
2015-02-01 13:55 cbradney Note Added: 0034409
2015-02-05 15:43 FirasH Tag Detached: #easyhack
2015-02-12 00:58 Kunda Note Added: 0034486
2015-02-19 13:40 FirasH Note Added: 0034539
2015-02-19 13:40 FirasH Status resolved => closed
2015-06-30 17:20 Kunda Relationship added related to 0013107